All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Bamvor Jian Zhang" <bamv2005@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH 1/3] gpio: mockup: fix indicated direction
Date: Thu,  8 Nov 2018 17:52:53 +0100	[thread overview]
Message-ID: <20181108165255.9940-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20181108165255.9940-1-brgl@bgdev.pl>

Commit 3edfb7bd76bd ("gpiolib: Show correct direction from the
beginning") fixed an existing issue but broke libgpiod tests by
changing the default direction of dummy lines to output.

We don't break user-space so make gpio-mockup behave as before.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 drivers/gpio/gpio-mockup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 8269cffc2967..6a50f9f59c90 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -35,8 +35,8 @@
 #define gpio_mockup_err(...)	pr_err(GPIO_MOCKUP_NAME ": " __VA_ARGS__)
 
 enum {
-	GPIO_MOCKUP_DIR_OUT = 0,
-	GPIO_MOCKUP_DIR_IN = 1,
+	GPIO_MOCKUP_DIR_IN = 0,
+	GPIO_MOCKUP_DIR_OUT = 1,
 };
 
 /*
@@ -131,7 +131,7 @@ static int gpio_mockup_get_direction(struct gpio_chip *gc, unsigned int offset)
 {
 	struct gpio_mockup_chip *chip = gpiochip_get_data(gc);
 
-	return chip->lines[offset].dir;
+	return !chip->lines[offset].dir;
 }
 
 static int gpio_mockup_to_irq(struct gpio_chip *gc, unsigned int offset)
-- 
2.19.1

  reply	other threads:[~2018-11-08 16:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 16:52 [PATCH 0/3] gpio: mockup: misc updates Bartosz Golaszewski
2018-11-08 16:52 ` Bartosz Golaszewski [this message]
2018-11-08 20:35   ` [PATCH 1/3] gpio: mockup: fix indicated direction Uwe Kleine-König
2018-11-09 11:13     ` Bartosz Golaszewski
2018-11-09 11:54       ` Uwe Kleine-König
2018-11-09 12:24         ` Bartosz Golaszewski
2018-11-09 13:10           ` Uwe Kleine-König
2018-11-09 13:53             ` Bartosz Golaszewski
2018-11-09 14:39               ` Uwe Kleine-König
2018-11-09 15:24                 ` Bartosz Golaszewski
2018-11-09 17:03                   ` Uwe Kleine-König
2018-11-09 17:23                     ` Bartosz Golaszewski
2018-11-11 16:59                       ` Uwe Kleine-König
2018-11-12 14:14                         ` Bartosz Golaszewski
2018-11-13  6:57                           ` Uwe Kleine-König
2018-11-16 21:38   ` Linus Walleij
2018-11-08 16:52 ` [PATCH 2/3] gpio: mockup: add locking Bartosz Golaszewski
2018-11-08 21:13   ` Uwe Kleine-König
2018-11-16 21:43   ` Linus Walleij
2018-11-19  9:09     ` Bartosz Golaszewski
2018-11-20  8:46       ` Linus Walleij
2018-11-08 16:52 ` [PATCH 3/3] gpio: mockup: implement get_multiple() Bartosz Golaszewski
2018-11-08 20:36   ` Uwe Kleine-König
2018-11-16 21:44   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108165255.9940-2-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=bamv2005@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.