From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 1/2] net: phy: use phy_id_mask value zero for
 exact match
Date: Thu, 8 Nov 2018 19:34:51 +0100
Message-ID: <20181108183451.GD5259@lunn.ch>
References: <08d52675-f308-4ebb-4ec4-f6c7ac0b6b06@gmail.com>
 <e69ac41d-7c1a-78dd-06b2-cb7bffab9e80@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:55663 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727289AbeKIEmI (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 8 Nov 2018 23:42:08 -0500
Content-Disposition: inline
In-Reply-To: <e69ac41d-7c1a-78dd-06b2-cb7bffab9e80@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Nov 07, 2018 at 09:53:32PM +0100, Heiner Kallweit wrote:
> @@ -500,7 +500,7 @@ struct phy_driver {
>  	struct mdio_driver_common mdiodrv;
>  	u32 phy_id;
>  	char *name;
> -	u32 phy_id_mask;
> +	u32 phy_id_mask; /* value 0 means exact match */

Hi Heiner

Please make this comment part of the kerneldoc which is just above:

 * phy_id: The result of reading the UID registers of this PHY
 *   type, and ANDing them with the phy_id_mask.

 Andrew