From: Michael Halstead <mhalstead@linuxfoundation.org>
To: openembedded-core@lists.openembedded.org
Cc: rpurdie@linuxfoundation.org
Subject: [PATCH 2/3] scripts/runqemu: Replace subprocess.run() for compatibilty
Date: Thu, 8 Nov 2018 12:58:39 -0800 [thread overview]
Message-ID: <20181108205840.24972-2-mhalstead@linuxfoundation.org> (raw)
In-Reply-To: <20181108205840.24972-1-mhalstead@linuxfoundation.org>
subprocess.run() was introduced in Python 3.5. We currently support down to
Python 3.4 so I've replaced it with subprocess.check_call() which is available
in that version.
Signed-off-by: Michael Halstead <mhalstead@linuxfoundation.org>
---
scripts/runqemu | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index 0c61253d6a..c79be9a846 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -1321,7 +1321,7 @@ def main():
logger.info("SIGTERM received")
os.kill(config.qemupid, signal.SIGTERM)
config.cleanup()
- subprocess.run(["tput", "smam"])
+ subprocess.check_call(["tput", "smam"])
signal.signal(signal.SIGTERM, sigterm_handler)
config.check_args()
@@ -1343,7 +1343,7 @@ def main():
return 1
finally:
config.cleanup()
- subprocess.run(["tput", "smam"])
+ subprocess.check_call(["tput", "smam"])
if __name__ == "__main__":
sys.exit(main())
--
2.17.2
next prev parent reply other threads:[~2018-11-08 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 20:58 [PATCH 1/3] scripts/runqemu: Add serialstdio mode Michael Halstead
2018-11-08 20:58 ` Michael Halstead [this message]
2018-11-08 20:58 ` [PATCH 3/3] scripts/autobuilder-worker-prereq-tests: Shore up qemu testing Michael Halstead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108205840.24972-2-mhalstead@linuxfoundation.org \
--to=mhalstead@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=rpurdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.