From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 8/8] kernel-shark-qt: Update Sched Events plugin
Date: Thu, 8 Nov 2018 21:37:40 -0500 [thread overview]
Message-ID: <20181108213740.4d638565@vmware.local.home> (raw)
In-Reply-To: <20181108213527.78b5cba3@vmware.local.home>
On Thu, 8 Nov 2018 21:35:27 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 7 Nov 2018 16:14:40 +0000
> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
>
> > This patch updates the Sched Events plugin to use the recently
> > introduced "Missed events" entries and tot_count field of the
> > Visualization model descriptor in its plotting logic.
> >
>
> I also noticed that it appears that you are drawing the red box for
> every sched switch. The red box is only suppose to be drawn if the
> previous state is R. The red box should not be drawn for any other
> state (because they were blocked, and not preempted).
>
In other words, a red box should never connect to a green one.
-- Steve
prev parent reply other threads:[~2018-11-09 12:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 16:14 [PATCH 0/8] New/improved KernelShark plugins Yordan Karadzhov
2018-11-07 16:14 ` [PATCH 1/8] kernel-shark-qt: Reset the second pass hash when reloading Sched plugin Yordan Karadzhov
2018-11-07 16:14 ` [PATCH 2/8] kernel-shark-qt: Improve the plotting logic of the Sched event plugin Yordan Karadzhov
2018-11-07 16:14 ` [PATCH 3/8] kernel-shark-qt: Update the visualization model before plotting new graphs Yordan Karadzhov
2018-11-07 16:14 ` [PATCH 4/8] kernel-shark-qt: Add "Missed events" custom kshark_entry Yordan Karadzhov
2018-11-07 16:14 ` [PATCH 5/8] kernel-shark-qt: Add instrumentation for "Missed events" to the model Yordan Karadzhov
2018-11-07 16:14 ` [PATCH 6/8] kernel-shark-qt: Add tot_count field to the model descriptor Yordan Karadzhov
2018-11-09 2:12 ` Steven Rostedt
2018-11-07 16:14 ` [PATCH 7/8] kernel-shark-qt: Add "Missed events" plugin for KernelShark Yordan Karadzhov
2018-11-07 16:14 ` [PATCH 8/8] kernel-shark-qt: Update Sched Events plugin Yordan Karadzhov
2018-11-09 2:16 ` Steven Rostedt
2018-11-09 2:35 ` Steven Rostedt
2018-11-09 2:37 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108213740.4d638565@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.