From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next] net: phy: improve struct phy_device member interrupts handling Date: Thu, 8 Nov 2018 23:24:36 +0100 Message-ID: <20181108222436.GH5259@lunn.ch> References: <44805a11-3063-4f1f-2fd2-b268155d4935@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" To: Heiner Kallweit Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:55878 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727603AbeKIICP (ORCPT ); Fri, 9 Nov 2018 03:02:15 -0500 Content-Disposition: inline In-Reply-To: <44805a11-3063-4f1f-2fd2-b268155d4935@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Nov 08, 2018 at 10:36:33PM +0100, Heiner Kallweit wrote: > As a heritage from the very early days of phylib member interrupts is > defined as u32 even though it's just a flag whether interrupts are > enabled. So we can change it to a bitfield member. In addition change > the code dealing with this member in a way that it's clear we're > dealing with a bool value. > > Signed-off-by: Heiner Kallweit > --- > Actually this member isn't needed at all and could be replaced with > a parameter in phy_driver->config_intr. But this would mean an API > change, maybe I come up with a proposal later. > --- > drivers/net/phy/phy.c | 2 +- > include/linux/phy.h | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index dd5bff955..a5e6acfe6 100644 > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -115,7 +115,7 @@ static int phy_clear_interrupt(struct phy_device *phydev) > * > * Returns 0 on success or < 0 on error. > */ > -static int phy_config_interrupt(struct phy_device *phydev, u32 interrupts) > +static int phy_config_interrupt(struct phy_device *phydev, bool interrupts) > { > phydev->interrupts = interrupts; > if (phydev->drv->config_intr) > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 5dd85c441..fc90af152 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -263,8 +263,8 @@ static inline struct mii_bus *devm_mdiobus_alloc(struct device *dev) > void devm_mdiobus_free(struct device *dev, struct mii_bus *bus); > struct phy_device *mdiobus_scan(struct mii_bus *bus, int addr); > > -#define PHY_INTERRUPT_DISABLED 0x0 > -#define PHY_INTERRUPT_ENABLED 0x80000000 > +#define PHY_INTERRUPT_DISABLED 0 > +#define PHY_INTERRUPT_ENABLED 1 Hi Heiner Since this is passed around as a bool, false/true would be better than 0/1. Andrew