From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 0/5] net: phy: improve and simplify phylib state machine Date: Fri, 9 Nov 2018 00:01:30 +0100 Message-ID: <20181108230130.GK5259@lunn.ch> References: <922c223b-7bc0-e0ec-345d-2034b796af91@gmail.com> <20181108.145846.295661679780466934.davem@davemloft.net> <911ca9fa-e994-d3f3-2e8d-6f16631c1757@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , hkallweit1@gmail.com, netdev@vger.kernel.org To: Florian Fainelli Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:55939 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726831AbeKIIjU (ORCPT ); Fri, 9 Nov 2018 03:39:20 -0500 Content-Disposition: inline In-Reply-To: <911ca9fa-e994-d3f3-2e8d-6f16631c1757@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Nov 08, 2018 at 03:00:01PM -0800, Florian Fainelli wrote: > On 11/8/18 2:58 PM, David Miller wrote: > > From: Heiner Kallweit > > Date: Wed, 7 Nov 2018 20:41:52 +0100 > > > >> This patch series is based on two axioms: > >> > >> - During autoneg a PHY always reports the link being down > >> > >> - Info in clause 22/45 registers doesn't allow to differentiate between > >> these two states: > >> 1. Link is physically down > >> 2. A link partner is connected and PHY is autonegotiating > >> In both cases "link up" and "aneg finished" bits aren't set. > >> One consequence is that having separate states PHY_NOLINK and PHY_AN > >> isn't needed. > >> > >> By using these two axioms the state machine can be significantly > >> simplified. > > > > So how are we going to move forward on this? > > > > Maybe we can apply this series and just watch carefully for any > > problems that get reported or are found? > > Given Heiner is always responsive and taking care of fixing what might > be/have broken, no objections with me on that. Yes, lets try it. Andrew