Re: [PATCH 3/4] staging: rtlwifi: Add blank lines

[Maya Nakamura <m.maya.nakamura@gmail.com>]

On Thu, Nov 08, 2018 at 03:28:57AM -0800, Greg KH wrote:
> On Wed, Nov 07, 2018 at 11:23:07PM -0800, Maya Nakamura wrote:
> > Add blank lines after if statements.
> 
> That says what you did, but not _why_ you did this.
> 
> > 
> > Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> > ---
> >  drivers/staging/rtlwifi/phydm/phydm_adc_sampling.c | 1 +
> >  drivers/staging/rtlwifi/phydm/phydm_ccx.c          | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/drivers/staging/rtlwifi/phydm/phydm_adc_sampling.c b/drivers/staging/rtlwifi/phydm/phydm_adc_sampling.c
> > index 7eb54d2e48f3..7d578241326b 100644
> > --- a/drivers/staging/rtlwifi/phydm/phydm_adc_sampling.c
> > +++ b/drivers/staging/rtlwifi/phydm/phydm_adc_sampling.c
> > @@ -563,6 +563,7 @@ void phydm_lamode_trigger_setting(void *dm_void, char input[][16], u32 *_used,
> >  				PHYDM_SSCANF(input[3], DCMD_HEX, &var1[2]);
> >  			else
> >  				PHYDM_SSCANF(input[3], DCMD_DECIMAL, &var1[2]);
> > +
> >  			trig_sig_sel = var1[2];
> >  
> >  			PHYDM_SSCANF(input[4], DCMD_DECIMAL, &var1[3]);
> > diff --git a/drivers/staging/rtlwifi/phydm/phydm_ccx.c b/drivers/staging/rtlwifi/phydm/phydm_ccx.c
> > index ded6642bdf64..c0da601be6cf 100644
> > --- a/drivers/staging/rtlwifi/phydm/phydm_ccx.c
> > +++ b/drivers/staging/rtlwifi/phydm/phydm_ccx.c
> > @@ -357,6 +357,7 @@ bool phydm_check_nhm_ready(void *dm_void)
> >  			}
> >  		}
> >  	}
> > +
> 
> Is this one really needed?
> 
> thanks,
> 
> greg k-h

Hi Greg,

Thank you for accepting three of my four patches in this patchset!

I read several examples that use if statements in K&R and didn't find a
blank line between them and the next statements. I thought that it is
easier to read with a blank line, but it is just my personal preference,
so it is not necessary. Therefore, I won't resubmit this patch.

Maya