All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Brajeswar Ghosh <brajeswar.linux@gmail.com>
Cc: arve@android.com, tkjos@android.com, maco@android.com,
	joel@joelfernandes.org, devel@driverdev.osuosl.org,
	sabyasachi.linux@gmail.com, jrdr.linux@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/android/binder.c: Remove duplicate header
Date: Fri, 9 Nov 2018 03:24:34 -0800	[thread overview]
Message-ID: <20181109112434.GA29324@kroah.com> (raw)
In-Reply-To: <20181109041425.GA2950@hp-pavilion-15-notebook-pc-brajeswar>

On Fri, Nov 09, 2018 at 09:44:25AM +0530, Brajeswar Ghosh wrote:
> Remove binder_trace.h which is included more than once
> 
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> ---
>  drivers/android/binder.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index cb30a524d16d..719f35a5c04b 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -5852,6 +5852,5 @@ static int __init binder_init(void)
>  device_initcall(binder_init);
>  
>  #define CREATE_TRACE_POINTS
> -#include "binder_trace.h"
>  
>  MODULE_LICENSE("GPL v2");

Are you sure about this?  Did you test the tracepoint functionality
after removing that line?  I think you just broke it :(

thanks,

greg k-h

  reply	other threads:[~2018-11-09 11:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09  4:14 [PATCH] drivers/android/binder.c: Remove duplicate header Brajeswar Ghosh
2018-11-09 11:24 ` Greg KH [this message]
2018-11-09 14:40 ` kbuild test robot
2018-11-09 14:47   ` Greg KH
2018-11-10  6:28     ` Souptick Joarder
2018-11-10  1:51 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109112434.GA29324@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=brajeswar.linux@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=joel@joelfernandes.org \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=sabyasachi.linux@gmail.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.