From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Husemann Date: Fri, 9 Nov 2018 13:08:42 +0100 Subject: [U-Boot] Portability of sh scripts Message-ID: <20181109120842.GA21976@mail.duskware.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hey folks, I noticed that tools/imx_cntr_image.sh contains non-portable code: if [ $f == "u-boot-dtb.bin" ]; then This is a "bash-ism", the operator "==" is not implemented by most test(1) or sh(1) impmlementations. Simply replacing it with "=" fixes this. Should I send a trivial patch or do you just fix it? Thanks, Martin