From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 9 Nov 2018 07:11:15 -0500 Subject: [U-Boot] Portability of sh scripts In-Reply-To: <20181109120842.GA21976@mail.duskware.de> References: <20181109120842.GA21976@mail.duskware.de> Message-ID: <20181109121115.GL11247@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Nov 09, 2018 at 01:08:42PM +0100, Martin Husemann wrote: > Hey folks, > > I noticed that tools/imx_cntr_image.sh contains non-portable code: > > if [ $f == "u-boot-dtb.bin" ]; then > > This is a "bash-ism", the operator "==" is not implemented by most test(1) > or sh(1) impmlementations. Simply replacing it with "=" fixes this. > > Should I send a trivial patch or do you just fix it? Please send a patch, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: