From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 09 Nov 2018 14:45:53 +0100 (CET) Received: from mail.bootlin.com ([62.4.15.54]:40761 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23990439AbeKINpsx73nw (ORCPT ); Fri, 9 Nov 2018 14:45:48 +0100 Received: by mail.bootlin.com (Postfix, from userid 110) id BB94520757; Fri, 9 Nov 2018 14:45:40 +0100 (CET) Received: from localhost (242.171.71.37.rev.sfr.net [37.71.171.242]) by mail.bootlin.com (Postfix) with ESMTPSA id 802A7206A7; Fri, 9 Nov 2018 14:45:30 +0100 (CET) Date: Fri, 9 Nov 2018 14:45:30 +0100 From: Alexandre Belloni To: Christoph Hellwig Cc: Paul Burton , linux-mips@linux-mips.org Subject: Re: dma_pool broken on MIPS generic? Message-ID: <20181109134530.GB29768@piout.net> References: <20181109131014.GA29768@piout.net> <20181109132440.GA12787@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181109132440.GA12787@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 67192 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: alexandre.belloni@bootlin.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 09/11/2018 14:24:40+0100, Christoph Hellwig wrote: > On Fri, Nov 09, 2018 at 02:10:14PM +0100, Alexandre Belloni wrote: > > Hello, > > > > I'm working on a (not yet upstreamed) dmaengine driver. While rebasing > > from v4.19 to v4.20-rc1, I saw that it is not working properly anymore > > because dma_pool is allocating descriptors in kseg0 which is cached > > while in v4.19, it was allocating them in kseg1. > > > > Am I missing something to explicitely state that the cache is not dma > > coherent? How could I track this behaviour change? > > You probably want this commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?h=mips-fixes&id=d01501f85249848a2497968d46dd46d5c6fe32e6 Yep, this helped, thanks a lot! -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com