From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:6844:0:0:0:0:0 with SMTP id o4-v6csp748904wrw; Fri, 9 Nov 2018 06:27:52 -0800 (PST) X-Google-Smtp-Source: AJdET5d3Qs+bXsVnNrP3REdav31M1jfdbDd4yZh8VljKkGmzcYs/i2cSudC6+p+vOcQ5JNfIL/mm X-Received: by 2002:a0c:bb82:: with SMTP id i2mr8817089qvg.159.1541773672258; Fri, 09 Nov 2018 06:27:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541773672; cv=none; d=google.com; s=arc-20160816; b=tbTfQWsqEpPY7C2cKK3thGsLGLf8OeUyVU3ieVU4zwqCW2Xf87QNxntm1wQ+0AfZhF xwioBjDQ7NSOf7fiS2xwRmGWJEbn7tXZZxMyn7OhDsXsdA+O8+uu0xfAWtX9Of+vA4J1 xlEYDs1JgCn/zNKjnVY9MUnPsw7e5HAGoPcUWNYtaUVYWpLvejWobDGJR/N51j+GCvEd jSBQpOyxSRKbYPhYfF7mBADX4VgI8TRk4jfvny+7Fi7cCpUzkm3UoLXo1R0c52aSzTpU w346D8W/vrO/Uk3xKDKukZjEnCr5mxZ5X891xR+JcoBohEhOPZI4JsZA9iVeluNqRKnG KJJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:to:from:date; bh=hNMjJkbuNY23hO4lqqsoNxmH4FhzrVgAGA8RwkDTHvE=; b=L5yJsPRWqXBZoSFKxtrQfU2ya+hDJ5vVByi9CM/Ta1kDu/QtKtrweaV7VyxJ4m3m3H mnyPESHDtOZ0K2AJEcDqqgLkeK2qtPf75l1HwdSJjtNdgQWssuAuhw1iWMS/U/S2RnGJ ZrLwlEC6jy4FpjxrjdNNEtLGaZF+m9w2lJgLAz3eL/JEBFtTSvDH8HzBlPUnFymye2pp NKCiIL24/stl8p0d9o/XAAV9u76idkKzKcg+AyGDbSN4fvyW3FV8Op0rTkYiNTASCjH5 +/G91DJYQR6lRzExeT8UoXzyilug15YgjK+vxIuivCFdXugSlcP31W0w5pPD3t4On5Z1 6Q9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v40si935502qtv.322.2018.11.09.06.27.52 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 09 Nov 2018 06:27:52 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:34423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL7lH-0001X4-Q3 for alex.bennee@linaro.org; Fri, 09 Nov 2018 09:27:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL7l8-0001VB-0C for qemu-arm@nongnu.org; Fri, 09 Nov 2018 09:27:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gL7ky-0003Nc-C9 for qemu-arm@nongnu.org; Fri, 09 Nov 2018 09:27:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46892) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gL7kx-0003K9-Lu; Fri, 09 Nov 2018 09:27:32 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BAFC5C050DEE; Fri, 9 Nov 2018 14:27:23 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CE615D717; Fri, 9 Nov 2018 14:27:18 +0000 (UTC) Date: Fri, 9 Nov 2018 15:27:16 +0100 From: Igor Mammedov To: Samuel Ortiz Message-ID: <20181109152716.236d3c6e@redhat.com> In-Reply-To: <20181105014047.26447-3-sameo@linux.intel.com> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-3-sameo@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 09 Nov 2018 14:27:23 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: gio9/FjbZ3at On Mon, 5 Nov 2018 02:40:25 +0100 Samuel Ortiz wrote: > This is going to be needed by the Hardware-reduced ACPI routines. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Tested-by: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Samuel Ortiz the patch is probably misplaced withing series, if there is an external user within this series then this patch should be squashed there, otherwise it doesn't belong to this series. > --- > include/hw/acpi/aml-build.h | 2 ++ > hw/acpi/aml-build.c | 8 ++++++++ > hw/i386/acpi-build.c | 8 -------- > 3 files changed, 10 insertions(+), 8 deletions(-) >=20 > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 6c36903c0a..73fc6659f2 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -384,6 +384,8 @@ build_header(BIOSLinker *linker, GArray *table_data, > const char *oem_id, const char *oem_table_id); > void *acpi_data_push(GArray *table_data, unsigned size); > unsigned acpi_data_len(GArray *table); > +/* Align AML blob size to a multiple of 'align' */ > +void acpi_align_size(GArray *blob, unsigned align); > void acpi_add_table(GArray *table_offsets, GArray *table_data); > void acpi_build_tables_init(AcpiBuildTables *tables); > void acpi_build_tables_cleanup(AcpiBuildTables *tables, bool mfre); > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 1e43cd736d..51b608432f 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -1565,6 +1565,14 @@ unsigned acpi_data_len(GArray *table) > return table->len; > } > =20 > +void acpi_align_size(GArray *blob, unsigned align) > +{ > + /* Align size to multiple of given size. This reduces the chance > + * we need to change size in the future (breaking cross version migr= ation). > + */ > + g_array_set_size(blob, ROUND_UP(acpi_data_len(blob), align)); > +} > + > void acpi_add_table(GArray *table_offsets, GArray *table_data) > { > uint32_t offset =3D table_data->len; > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index d0362e1382..81d98fa34f 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -282,14 +282,6 @@ static void acpi_get_pci_holes(Range *hole, Range *h= ole64) > NULL)); > } > =20 > -static void acpi_align_size(GArray *blob, unsigned align) > -{ > - /* Align size to multiple of given size. This reduces the chance > - * we need to change size in the future (breaking cross version migr= ation). > - */ > - g_array_set_size(blob, ROUND_UP(acpi_data_len(blob), align)); > -} > - > /* FACS */ > static void > build_facs(GArray *table_data, BIOSLinker *linker) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API Date: Fri, 9 Nov 2018 15:27:16 +0100 Message-ID: <20181109152716.236d3c6e@redhat.com> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-3-sameo@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gL7kr-0003S8-9c for xen-devel@lists.xenproject.org; Fri, 09 Nov 2018 14:27:25 +0000 In-Reply-To: <20181105014047.26447-3-sameo@linux.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Samuel Ortiz Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCAgNSBOb3YgMjAxOCAwMjo0MDoyNSArMDEwMApTYW11ZWwgT3J0aXogPHNhbWVvQGxp bnV4LmludGVsLmNvbT4gd3JvdGU6Cgo+IFRoaXMgaXMgZ29pbmcgdG8gYmUgbmVlZGVkIGJ5IHRo ZSBIYXJkd2FyZS1yZWR1Y2VkIEFDUEkgcm91dGluZXMuCj4gCj4gUmV2aWV3ZWQtYnk6IFBoaWxp cHBlIE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT4KPiBUZXN0ZWQtYnk6IFBoaWxp cHBlIE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBT YW11ZWwgT3J0aXogPHNhbWVvQGxpbnV4LmludGVsLmNvbT4KdGhlIHBhdGNoIGlzIHByb2JhYmx5 IG1pc3BsYWNlZCB3aXRoaW5nIHNlcmllcywKaWYgdGhlcmUgaXMgYW4gZXh0ZXJuYWwgdXNlciB3 aXRoaW4gdGhpcyBzZXJpZXMgdGhlbiB0aGlzIHBhdGNoIHNob3VsZApiZSBzcXVhc2hlZCB0aGVy ZSwgb3RoZXJ3aXNlIGl0IGRvZXNuJ3QgYmVsb25nIHRvIHRoaXMgc2VyaWVzLgoKPiAtLS0KPiAg aW5jbHVkZS9ody9hY3BpL2FtbC1idWlsZC5oIHwgMiArKwo+ICBody9hY3BpL2FtbC1idWlsZC5j ICAgICAgICAgfCA4ICsrKysrKysrCj4gIGh3L2kzODYvYWNwaS1idWlsZC5jICAgICAgICB8IDgg LS0tLS0tLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2h3L2FjcGkvYW1sLWJ1aWxkLmggYi9pbmNs dWRlL2h3L2FjcGkvYW1sLWJ1aWxkLmgKPiBpbmRleCA2YzM2OTAzYzBhLi43M2ZjNjY1OWYyIDEw MDY0NAo+IC0tLSBhL2luY2x1ZGUvaHcvYWNwaS9hbWwtYnVpbGQuaAo+ICsrKyBiL2luY2x1ZGUv aHcvYWNwaS9hbWwtYnVpbGQuaAo+IEBAIC0zODQsNiArMzg0LDggQEAgYnVpbGRfaGVhZGVyKEJJ T1NMaW5rZXIgKmxpbmtlciwgR0FycmF5ICp0YWJsZV9kYXRhLAo+ICAgICAgICAgICAgICAgY29u c3QgY2hhciAqb2VtX2lkLCBjb25zdCBjaGFyICpvZW1fdGFibGVfaWQpOwo+ICB2b2lkICphY3Bp X2RhdGFfcHVzaChHQXJyYXkgKnRhYmxlX2RhdGEsIHVuc2lnbmVkIHNpemUpOwo+ICB1bnNpZ25l ZCBhY3BpX2RhdGFfbGVuKEdBcnJheSAqdGFibGUpOwo+ICsvKiBBbGlnbiBBTUwgYmxvYiBzaXpl IHRvIGEgbXVsdGlwbGUgb2YgJ2FsaWduJyAqLwo+ICt2b2lkIGFjcGlfYWxpZ25fc2l6ZShHQXJy YXkgKmJsb2IsIHVuc2lnbmVkIGFsaWduKTsKPiAgdm9pZCBhY3BpX2FkZF90YWJsZShHQXJyYXkg KnRhYmxlX29mZnNldHMsIEdBcnJheSAqdGFibGVfZGF0YSk7Cj4gIHZvaWQgYWNwaV9idWlsZF90 YWJsZXNfaW5pdChBY3BpQnVpbGRUYWJsZXMgKnRhYmxlcyk7Cj4gIHZvaWQgYWNwaV9idWlsZF90 YWJsZXNfY2xlYW51cChBY3BpQnVpbGRUYWJsZXMgKnRhYmxlcywgYm9vbCBtZnJlKTsKPiBkaWZm IC0tZ2l0IGEvaHcvYWNwaS9hbWwtYnVpbGQuYyBiL2h3L2FjcGkvYW1sLWJ1aWxkLmMKPiBpbmRl eCAxZTQzY2Q3MzZkLi41MWI2MDg0MzJmIDEwMDY0NAo+IC0tLSBhL2h3L2FjcGkvYW1sLWJ1aWxk LmMKPiArKysgYi9ody9hY3BpL2FtbC1idWlsZC5jCj4gQEAgLTE1NjUsNiArMTU2NSwxNCBAQCB1 bnNpZ25lZCBhY3BpX2RhdGFfbGVuKEdBcnJheSAqdGFibGUpCj4gICAgICByZXR1cm4gdGFibGUt PmxlbjsKPiAgfQo+ICAKPiArdm9pZCBhY3BpX2FsaWduX3NpemUoR0FycmF5ICpibG9iLCB1bnNp Z25lZCBhbGlnbikKPiArewo+ICsgICAgLyogQWxpZ24gc2l6ZSB0byBtdWx0aXBsZSBvZiBnaXZl biBzaXplLiBUaGlzIHJlZHVjZXMgdGhlIGNoYW5jZQo+ICsgICAgICogd2UgbmVlZCB0byBjaGFu Z2Ugc2l6ZSBpbiB0aGUgZnV0dXJlIChicmVha2luZyBjcm9zcyB2ZXJzaW9uIG1pZ3JhdGlvbiku Cj4gKyAgICAgKi8KPiArICAgIGdfYXJyYXlfc2V0X3NpemUoYmxvYiwgUk9VTkRfVVAoYWNwaV9k YXRhX2xlbihibG9iKSwgYWxpZ24pKTsKPiArfQo+ICsKPiAgdm9pZCBhY3BpX2FkZF90YWJsZShH QXJyYXkgKnRhYmxlX29mZnNldHMsIEdBcnJheSAqdGFibGVfZGF0YSkKPiAgewo+ICAgICAgdWlu dDMyX3Qgb2Zmc2V0ID0gdGFibGVfZGF0YS0+bGVuOwo+IGRpZmYgLS1naXQgYS9ody9pMzg2L2Fj cGktYnVpbGQuYyBiL2h3L2kzODYvYWNwaS1idWlsZC5jCj4gaW5kZXggZDAzNjJlMTM4Mi4uODFk OThmYTM0ZiAxMDA2NDQKPiAtLS0gYS9ody9pMzg2L2FjcGktYnVpbGQuYwo+ICsrKyBiL2h3L2kz ODYvYWNwaS1idWlsZC5jCj4gQEAgLTI4MiwxNCArMjgyLDYgQEAgc3RhdGljIHZvaWQgYWNwaV9n ZXRfcGNpX2hvbGVzKFJhbmdlICpob2xlLCBSYW5nZSAqaG9sZTY0KQo+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwpKTsKPiAgfQo+ICAKPiAtc3Rh dGljIHZvaWQgYWNwaV9hbGlnbl9zaXplKEdBcnJheSAqYmxvYiwgdW5zaWduZWQgYWxpZ24pCj4g LXsKPiAtICAgIC8qIEFsaWduIHNpemUgdG8gbXVsdGlwbGUgb2YgZ2l2ZW4gc2l6ZS4gVGhpcyBy ZWR1Y2VzIHRoZSBjaGFuY2UKPiAtICAgICAqIHdlIG5lZWQgdG8gY2hhbmdlIHNpemUgaW4gdGhl IGZ1dHVyZSAoYnJlYWtpbmcgY3Jvc3MgdmVyc2lvbiBtaWdyYXRpb24pLgo+IC0gICAgICovCj4g LSAgICBnX2FycmF5X3NldF9zaXplKGJsb2IsIFJPVU5EX1VQKGFjcGlfZGF0YV9sZW4oYmxvYiks IGFsaWduKSk7Cj4gLX0KPiAtCj4gIC8qIEZBQ1MgKi8KPiAgc3RhdGljIHZvaWQKPiAgYnVpbGRf ZmFjcyhHQXJyYXkgKnRhYmxlX2RhdGEsIEJJT1NMaW5rZXIgKmxpbmtlcikKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBs aXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2pl Y3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL7lG-0001a7-U5 for qemu-devel@nongnu.org; Fri, 09 Nov 2018 09:27:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gL7lF-0003Zw-W1 for qemu-devel@nongnu.org; Fri, 09 Nov 2018 09:27:50 -0500 Date: Fri, 9 Nov 2018 15:27:16 +0100 From: Igor Mammedov Message-ID: <20181109152716.236d3c6e@redhat.com> In-Reply-To: <20181105014047.26447-3-sameo@linux.intel.com> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-3-sameo@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Ortiz Cc: qemu-devel@nongnu.org, Shannon Zhao , Stefano Stabellini , Anthony Perard , Richard Henderson , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Peter Maydell , Eduardo Habkost On Mon, 5 Nov 2018 02:40:25 +0100 Samuel Ortiz wrote: > This is going to be needed by the Hardware-reduced ACPI routines. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Tested-by: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Samuel Ortiz the patch is probably misplaced withing series, if there is an external user within this series then this patch should be squashed there, otherwise it doesn't belong to this series. > --- > include/hw/acpi/aml-build.h | 2 ++ > hw/acpi/aml-build.c | 8 ++++++++ > hw/i386/acpi-build.c | 8 -------- > 3 files changed, 10 insertions(+), 8 deletions(-) >=20 > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 6c36903c0a..73fc6659f2 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -384,6 +384,8 @@ build_header(BIOSLinker *linker, GArray *table_data, > const char *oem_id, const char *oem_table_id); > void *acpi_data_push(GArray *table_data, unsigned size); > unsigned acpi_data_len(GArray *table); > +/* Align AML blob size to a multiple of 'align' */ > +void acpi_align_size(GArray *blob, unsigned align); > void acpi_add_table(GArray *table_offsets, GArray *table_data); > void acpi_build_tables_init(AcpiBuildTables *tables); > void acpi_build_tables_cleanup(AcpiBuildTables *tables, bool mfre); > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 1e43cd736d..51b608432f 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -1565,6 +1565,14 @@ unsigned acpi_data_len(GArray *table) > return table->len; > } > =20 > +void acpi_align_size(GArray *blob, unsigned align) > +{ > + /* Align size to multiple of given size. This reduces the chance > + * we need to change size in the future (breaking cross version migr= ation). > + */ > + g_array_set_size(blob, ROUND_UP(acpi_data_len(blob), align)); > +} > + > void acpi_add_table(GArray *table_offsets, GArray *table_data) > { > uint32_t offset =3D table_data->len; > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index d0362e1382..81d98fa34f 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -282,14 +282,6 @@ static void acpi_get_pci_holes(Range *hole, Range *h= ole64) > NULL)); > } > =20 > -static void acpi_align_size(GArray *blob, unsigned align) > -{ > - /* Align size to multiple of given size. This reduces the chance > - * we need to change size in the future (breaking cross version migr= ation). > - */ > - g_array_set_size(blob, ROUND_UP(acpi_data_len(blob), align)); > -} > - > /* FACS */ > static void > build_facs(GArray *table_data, BIOSLinker *linker)