From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 1/2] drm/vc4: ->x_scaling[1] should never be set to VC4_SCALING_NONE Date: Fri, 9 Nov 2018 15:31:38 +0100 Message-ID: <20181109153138.65566573@bbrezillon> References: <20181109102633.32603-1-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id C8A1F6E42C for ; Fri, 9 Nov 2018 14:31:49 +0000 (UTC) In-Reply-To: <20181109102633.32603-1-boris.brezillon@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAgOSBOb3YgMjAxOCAxMToyNjozMiArMDEwMApCb3JpcyBCcmV6aWxsb24gPGJvcmlz LmJyZXppbGxvbkBib290bGluLmNvbT4gd3JvdGU6Cgo+IEZvciB0aGUgWVVWIGNvbnZlcnNpb24g dG8gd29yayBwcm9wZXJseSwgLT54X3NjYWxpbmdbMV0gc2hvdWxkIG5ldmVyCj4gYmUgc2V0IHRv IFZDNF9TQ0FMSU5HX05PTkUsIGJ1dCB2YzRfZ2V0X3NjYWxpbmdfbW9kZSgpIG1pZ2h0IHJldHVy bgo+IFZDNF9TQ0FMSU5HX05PTkUgaWYgdGhlIGhvcml6b250YWwgc2NhbGluZyByYXRpbyBleGFj dGx5IG1hdGNoZXMgdGhlCj4gaG9yaXpvbnRhbCBzdWJzYW1wbGluZyBmYWN0b3IuIEFkZCBhIHRl c3QgdG8gdHVybiBWQzRfU0NBTElOR19OT05FCj4gaW50byBWQzRfU0NBTElOR19QUEYgd2hlbiB0 aGF0IGhhcHBlbnMuCj4gCj4gVGhlIG9sZCAtPnhfc2NhbGluZ1swXSBhZGp1c3RtZW50IGlzIGRy b3BwZWQgYXMgSSBjb3VsZG4ndCBmaW5kIGFueQo+IG1lbnRpb24gdG8gdGhpcyBjb25zdHJhaW50 IGluIHRoZSBzcGVjIGFuZCBpdCdzIHByb3ZlbiB0byBiZQo+IHVubmVjZXNzYXJ5IChJIHRlc3Rl ZCB2YXJpb3VzIG11bHRpLXBsYW5hciBZVVYgZm9ybWF0cyB3aXRoIHNjYWxpbmcKPiBkaXNhYmxl ZCwgYW5kIGFsbCBvZiB0aGVtIHdvcmtlZCBmaW5lIHdpdGhvdXQgdGhpcyBhZGp1c3RtZW50KS4K PiAKPiBGaXhlczogZmMwNDAyM2ZhZmVjICgiZHJtL3ZjNDogQWRkIHN1cHBvcnQgZm9yIFlVViBw bGFuZXMuIikKPiBTaWduZWQtb2ZmLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxv bkBib290bGluLmNvbT4KPiBSZXZpZXdlZC1ieTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5l dD4KClNlcmllcyBxdWV1ZWQgdG8gZHJtLW1pc2MtbmV4dC4KCj4gLS0tCj4gQ2hhbmdlcyBpbiB2 MjoKPiAtIFJlbW92ZSB0aGUgdGhlIC0+eF9zY2FsaW5nWzBdID0gVkM0X1NDQUxJTkdfUFBGCj4g ICBhc3NpZ25tZW50IHdoZW4gLT5pc191bml0eSBpcyB0cnVlIGFuZCB1cGRhdGUgdGhlIGNvbW1l bnQKPiAtIEFkZCBFcmljJ3MgUi1iCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3Bs YW5lLmMgfCAxMiArKysrKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygr KSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZjNC92 YzRfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMKPiBpbmRleCA5OGZh ZTRkYWEwOGMuLjZjYWE2NzhlZGNmZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0 L3ZjNF9wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUuYwo+IEBA IC0zNDEsMTIgKzM0MSwxNCBAQCBzdGF0aWMgaW50IHZjNF9wbGFuZV9zZXR1cF9jbGlwcGluZ19h bmRfc2NhbGluZyhzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiAgCQkJdmM0X2dldF9z Y2FsaW5nX21vZGUodmM0X3N0YXRlLT5zcmNfaFsxXSwKPiAgCQkJCQkgICAgIHZjNF9zdGF0ZS0+ Y3J0Y19oKTsKPiAgCj4gLQkJLyogWVVWIGNvbnZlcnNpb24gcmVxdWlyZXMgdGhhdCBob3Jpem9u dGFsIHNjYWxpbmcgYmUgZW5hYmxlZCwKPiAtCQkgKiBldmVuIG9uIGEgcGxhbmUgdGhhdCdzIG90 aGVyd2lzZSAxOjEuIExvb2tzIGxpa2Ugb25seSBQUEYKPiAtCQkgKiB3b3JrcyBpbiB0aGF0IGNh c2UsIHNvIGxldCdzIHBpY2sgdGhhdCBvbmUuCj4gKwkJLyogWVVWIGNvbnZlcnNpb24gcmVxdWly ZXMgdGhhdCBob3Jpem9udGFsIHNjYWxpbmcgYmUgZW5hYmxlZAo+ICsJCSAqIG9uIHRoZSBVViBw bGFuZSBldmVuIGlmIHZjNF9nZXRfc2NhbGluZ19tb2RlKCkgcmV0dXJuZWQKPiArCQkgKiBWQzRf U0NBTElOR19OT05FICh3aGljaCBjYW4gaGFwcGVuIHdoZW4gdGhlIGRvd24tc2NhbGluZwo+ICsJ CSAqIHJhdGlvIGlzIDAuNSkuIExldCdzIGZvcmNlIGl0IHRvIFZDNF9TQ0FMSU5HX1BQRiBpbiB0 aGlzCj4gKwkJICogY2FzZS4KPiAgCQkgKi8KPiAtCQlpZiAodmM0X3N0YXRlLT5pc191bml0eSkK PiAtCQkJdmM0X3N0YXRlLT54X3NjYWxpbmdbMF0gPSBWQzRfU0NBTElOR19QUEY7Cj4gKwkJaWYg KHZjNF9zdGF0ZS0+eF9zY2FsaW5nWzFdID09IFZDNF9TQ0FMSU5HX05PTkUpCj4gKwkJCXZjNF9z dGF0ZS0+eF9zY2FsaW5nWzFdID0gVkM0X1NDQUxJTkdfUFBGOwo+ICAJfSBlbHNlIHsKPiAgCQl2 YzRfc3RhdGUtPmlzX3l1diA9IGZhbHNlOwo+ICAJCXZjNF9zdGF0ZS0+eF9zY2FsaW5nWzFdID0g VkM0X1NDQUxJTkdfTk9ORTsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=