From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: Enable Glibc for all little-endian ARCs with atomic ops
Date: Fri, 9 Nov 2018 17:40:17 +0100 [thread overview]
Message-ID: <20181109174017.1236dd5e@windsurf> (raw)
In-Reply-To: <7fa29470264912aadb3241fb2981f1d2872aef36.camel@synopsys.com>
Hello,
On Fri, 9 Nov 2018 16:34:50 +0000, Alexey Brodkin wrote:
> On Fri, 2018-11-09 at 17:32 +0100, Thomas Petazzoni wrote:
> > Hello,
> >
> > On Fri, 9 Nov 2018 17:00:23 +0300, Alexey Brodkin wrote:
> >
> > > diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in
> > > index 7d9428c70ed0..8d6997e7790b 100644
> > > --- a/toolchain/toolchain-buildroot/Config.in
> > > +++ b/toolchain/toolchain-buildroot/Config.in
> > > @@ -48,7 +48,7 @@ config BR2_TOOLCHAIN_BUILDROOT_GLIBC
> > > BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
> > > BR2_riscv || BR2_sh || BR2_sparc64 || \
> > > BR2_x86_64 || BR2_microblaze || BR2_nios2 || \
> > > - BR2_archs38
> > > + BR2_arcle
> >
> > What about:
> >
> > (BR2_arcle && BR2_ARC_ATOMIC_EXT)
> >
> > instead ?
>
> Sure, but I didn't want to ruin the beauty of above construction
> thus split in 2 parts.
>
> If you're OK with (x & y) among other pure arch mentions
> I may send a respin.
If you truly want beauty (which is good!) then I think it would be best
to have in package/glibc/Config.in:
config BR2_PACKAGE_GLIBC_ARCH_SUPPORTS
bool
default y if ...
default y if ...
and then use that in toolchain/toolchain-buildroot/Config.in. But that
requires doing the same for uclibc and musl to keep consistency :)
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-11-09 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 14:00 [Buildroot] [PATCH] toolchain: Enable Glibc for all little-endian ARCs with atomic ops Alexey Brodkin
2018-11-09 16:32 ` Thomas Petazzoni
2018-11-09 16:34 ` Alexey Brodkin
2018-11-09 16:40 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109174017.1236dd5e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.