All of lore.kernel.org
 help / color / mirror / Atom feed
From: geomatsi@gmail.com (Sergey Matyukevich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: sysreg: fix sparse warnings
Date: Sat, 10 Nov 2018 14:16:47 +0300	[thread overview]
Message-ID: <20181110111647.GA3511@speedy.hunter> (raw)
In-Reply-To: <20181110001615.GA5665@brain-police>

On Sat, Nov 10, 2018 at 12:16:16AM +0000, Will Deacon wrote:
> On Fri, Nov 09, 2018 at 11:47:47PM +0300, Sergey Matyukevich wrote:
> > Specify correct type for the constants to avoid
> > the following sparse complaints:
> > 
> > ./arch/arm64/include/asm/sysreg.h:471:42: warning: constant 0xffffffffffffffff is so big it is unsigned long
> > ./arch/arm64/include/asm/sysreg.h:512:42: warning: constant 0xffffffffffffffff is so big it is unsigned long
> > 
> > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> > ---
> >  arch/arm64/include/asm/sysreg.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> I thought this was fixed in newer versions of sparse so that it treats
> AArch64 as 64-bit? [see sparse commit 49d56b6969d2f]

I am using up-to-date sparse. However this warning still appears,
not sure why. Maybe sparse treats such constants as unsigned int ?

Meanwhile it looks like I chose wrong type: it is enough to use UL
instead of ULL to make sparse happy. In fact warning is clear
about it.

Regards,
Sergey

  reply	other threads:[~2018-11-10 11:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 20:47 [PATCH] arm64: sysreg: fix sparse warnings Sergey Matyukevich
2018-11-10  0:16 ` Will Deacon
2018-11-10 11:16   ` Sergey Matyukevich [this message]
2018-11-10 17:03     ` Will Deacon
2018-11-10 17:54       ` Luc Van Oostenryck
2018-11-10 17:54         ` Luc Van Oostenryck
2018-11-12 16:32         ` Ramsay Jones
2018-11-12 16:32           ` Ramsay Jones
2018-11-14 22:25           ` Luc Van Oostenryck
2018-11-14 22:25             ` Luc Van Oostenryck
2018-11-15  8:35             ` Sergey Matyukevich
2018-11-15  8:35               ` Sergey Matyukevich
2018-11-16 10:34               ` Luc Van Oostenryck
2018-11-16 10:34                 ` Luc Van Oostenryck
2018-11-16 13:54                 ` Sergey Matyukevich
2018-11-16 13:54                   ` Sergey Matyukevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181110111647.GA3511@speedy.hunter \
    --to=geomatsi@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.