Re: [Qemu-devel] [PATCH for-3.2 10/13] slirp: improve subprocess socket creation

[Samuel Thibault <samuel.thibault@gnu.org>]

Peter Maydell, le sam. 10 nov. 2018 14:04:10 +0000, a ecrit:
> On 10 November 2018 at 13:53, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > Marc-André Lureau, le sam. 10 nov. 2018 17:45:45 +0400, a ecrit:
> >> @@ -163,23 +183,14 @@ fork_exec(struct socket *so, const char *ex)
> >>               exit(1);
> >>
> >>        default:
> >> -             qemu_add_child_watch(pid);
> >> -                /*
> >> -                 * XXX this could block us...
> >> -                 * XXX Should set a timer here, and if accept() doesn't
> >> -                 * return after X seconds, declare it a failure
> >> -                 * The only reason this will block forever is if socket()
> >> -                 * of connect() fail in the child process
> >> -                 */
> >
> > At least this got fixed by Peter lately, so please rebase.
> 
> My patches aren't in master yet, though -- do you have a
> public slirp tree that slirp patches should be based on?
> (I'm assuming you're planning a pull request too.)

Ah, right.
My tree is documented in MAINTAINERS :)
git https://people.debian.org/~sthibault/qemu.git slirp

Let me push that to master indeed.

Samuel