diff for duplicates of <20181110182405.GB242356@google.com> diff --git a/a/1.txt b/N1/1.txt index 6405d16..ba3ec85 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,12 +3,12 @@ Thanks Andy for your thoughts, my comments below: On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote: > > -> > On Nov 9, 2018, at 7:20 PM, Joel Fernandes <joel@joelfernandes.org> wrote: +> > On Nov 9, 2018, at 7:20 PM, Joel Fernandes <joel at joelfernandes.org> wrote: > > > >> On Fri, Nov 09, 2018 at 10:19:03PM +0100, Jann Horn wrote: -> >>> On Fri, Nov 9, 2018 at 10:06 PM Jann Horn <jannh@google.com> wrote: +> >>> On Fri, Nov 9, 2018 at 10:06 PM Jann Horn <jannh at google.com> wrote: > >>> On Fri, Nov 9, 2018 at 9:46 PM Joel Fernandes (Google) -> >>> <joel@joelfernandes.org> wrote: +> >>> <joel at joelfernandes.org> wrote: > >>>> Android uses ashmem for sharing memory regions. We are looking forward > >>>> to migrating all usecases of ashmem to memfd so that we can possibly > >>>> remove the ashmem driver in the future from staging while also @@ -35,13 +35,13 @@ On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote: > >>>> The following program shows the seal > >>>> working in action: > >>> [...] -> >>>> Cc: jreck@google.com -> >>>> Cc: john.stultz@linaro.org -> >>>> Cc: tkjos@google.com -> >>>> Cc: gregkh@linuxfoundation.org -> >>>> Cc: hch@infradead.org -> >>>> Reviewed-by: John Stultz <john.stultz@linaro.org> -> >>>> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> +> >>>> Cc: jreck at google.com +> >>>> Cc: john.stultz at linaro.org +> >>>> Cc: tkjos at google.com +> >>>> Cc: gregkh at linuxfoundation.org +> >>>> Cc: hch at infradead.org +> >>>> Reviewed-by: John Stultz <john.stultz at linaro.org> +> >>>> Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org> > >>>> --- > >>> [...] > >>>> diff --git a/mm/memfd.c b/mm/memfd.c @@ -115,7 +115,7 @@ On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote: > > to the new fix? The patch is based on top of this series. > > > > ---8<----------- -> > From: "Joel Fernandes (Google)" <joel@joelfernandes.org> +> > From: "Joel Fernandes (Google)" <joel at joelfernandes.org> > > Subject: [PATCH] mm/memfd: Fix possible promotion to writeable of sealed memfd > > > > Jann Horn found that reopening an F_SEAL_FUTURE_WRITE sealed memfd @@ -123,8 +123,8 @@ On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote: > > without causing ABI breakages and ugly VFS hacks is to simply deny all > > opens on F_SEAL_FUTURE_WRITE sealed fds. > > -> > Reported-by: Jann Horn <jannh@google.com> -> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> +> > Reported-by: Jann Horn <jannh at google.com> +> > Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org> > > --- > > mm/shmem.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) diff --git a/a/content_digest b/N1/content_digest index c24dda9..83cba79 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,34 +3,9 @@ "ref\0CAG48ez0kQ4d566bXTFOYANDgii-stL-Qj-oyaBzvfxdV=PU-7g@mail.gmail.com\0" "ref\020181110032005.GA22238@google.com\0" "ref\069CE06CC-E47C-4992-848A-66EB23EE6C74@amacapital.net\0" - "From\0Joel Fernandes <joel@joelfernandes.org>\0" - "Subject\0Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd\0" + "From\0joel at joelfernandes.org (Joel Fernandes)\0" + "Subject\0[PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd\0" "Date\0Sat, 10 Nov 2018 10:24:05 -0800\0" - "To\0Andy Lutomirski <luto@amacapital.net>\0" - "Cc\0Jann Horn <jannh@google.com>" - kernel list <linux-kernel@vger.kernel.org> - jreck@google.com - John Stultz <john.stultz@linaro.org> - Todd Kjos <tkjos@google.com> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - Christoph Hellwig <hch@infradead.org> - Al Viro <viro@zeniv.linux.org.uk> - Andrew Morton <akpm@linux-foundation.org> - Daniel Colascione <dancol@google.com> - Bruce Fields <bfields@fieldses.org> - jlayton@kernel.org - Khalid Aziz <khalid.aziz@oracle.com> - Lei.Yang@windriver.com - linux-fsdevel@vger.kernel.org - linux-kselftest@vger.kernel.org - Linux-MM <linux-mm@kvack.org> - marcandre.lureau@redhat.com - Mike Kravetz <mike.kravetz@oracle.com> - minchan@kernel.org - shuah@kernel.org - valdis.kletnieks@vt.edu - Hugh Dickins <hughd@google.com> - " Linux API <linux-api@vge>\0" "\00:1\0" "b\0" "Thanks Andy for your thoughts, my comments below:\n" @@ -38,12 +13,12 @@ "On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote:\n" "> \n" "> \n" - "> > On Nov 9, 2018, at 7:20 PM, Joel Fernandes <joel@joelfernandes.org> wrote:\n" + "> > On Nov 9, 2018, at 7:20 PM, Joel Fernandes <joel at joelfernandes.org> wrote:\n" "> > \n" "> >> On Fri, Nov 09, 2018 at 10:19:03PM +0100, Jann Horn wrote:\n" - "> >>> On Fri, Nov 9, 2018 at 10:06 PM Jann Horn <jannh@google.com> wrote:\n" + "> >>> On Fri, Nov 9, 2018 at 10:06 PM Jann Horn <jannh at google.com> wrote:\n" "> >>> On Fri, Nov 9, 2018 at 9:46 PM Joel Fernandes (Google)\n" - "> >>> <joel@joelfernandes.org> wrote:\n" + "> >>> <joel at joelfernandes.org> wrote:\n" "> >>>> Android uses ashmem for sharing memory regions. We are looking forward\n" "> >>>> to migrating all usecases of ashmem to memfd so that we can possibly\n" "> >>>> remove the ashmem driver in the future from staging while also\n" @@ -70,13 +45,13 @@ "> >>>> The following program shows the seal\n" "> >>>> working in action:\n" "> >>> [...]\n" - "> >>>> Cc: jreck@google.com\n" - "> >>>> Cc: john.stultz@linaro.org\n" - "> >>>> Cc: tkjos@google.com\n" - "> >>>> Cc: gregkh@linuxfoundation.org\n" - "> >>>> Cc: hch@infradead.org\n" - "> >>>> Reviewed-by: John Stultz <john.stultz@linaro.org>\n" - "> >>>> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>\n" + "> >>>> Cc: jreck at google.com\n" + "> >>>> Cc: john.stultz at linaro.org\n" + "> >>>> Cc: tkjos at google.com\n" + "> >>>> Cc: gregkh at linuxfoundation.org\n" + "> >>>> Cc: hch at infradead.org\n" + "> >>>> Reviewed-by: John Stultz <john.stultz at linaro.org>\n" + "> >>>> Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org>\n" "> >>>> ---\n" "> >>> [...]\n" "> >>>> diff --git a/mm/memfd.c b/mm/memfd.c\n" @@ -150,7 +125,7 @@ "> > to the new fix? The patch is based on top of this series.\n" "> > \n" "> > ---8<-----------\n" - "> > From: \"Joel Fernandes (Google)\" <joel@joelfernandes.org>\n" + "> > From: \"Joel Fernandes (Google)\" <joel at joelfernandes.org>\n" "> > Subject: [PATCH] mm/memfd: Fix possible promotion to writeable of sealed memfd\n" "> > \n" "> > Jann Horn found that reopening an F_SEAL_FUTURE_WRITE sealed memfd\n" @@ -158,8 +133,8 @@ "> > without causing ABI breakages and ugly VFS hacks is to simply deny all\n" "> > opens on F_SEAL_FUTURE_WRITE sealed fds.\n" "> > \n" - "> > Reported-by: Jann Horn <jannh@google.com>\n" - "> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>\n" + "> > Reported-by: Jann Horn <jannh at google.com>\n" + "> > Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org>\n" "> > ---\n" "> > mm/shmem.c | 18 ++++++++++++++++++\n" "> > 1 file changed, 18 insertions(+)\n" @@ -264,4 +239,4 @@ "\n" - Joel -f19bda9f4f40f7501daf69fcf248389a0429e3bb7b5a373e1ce9499b57ed0f64 +ec7d90245685ade225288e556acd45c835986d332ae6aef5d83271763d54630b
diff --git a/a/1.txt b/N2/1.txt index 6405d16..4dce18f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,12 +1,12 @@ Thanks Andy for your thoughts, my comments below: -On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote: +On Fri, Nov 09, 2018@10:05:14PM -0800, Andy Lutomirski wrote: > > -> > On Nov 9, 2018, at 7:20 PM, Joel Fernandes <joel@joelfernandes.org> wrote: +> > On Nov 9, 2018,@7:20 PM, Joel Fernandes <joel@joelfernandes.org> wrote: > > -> >> On Fri, Nov 09, 2018 at 10:19:03PM +0100, Jann Horn wrote: -> >>> On Fri, Nov 9, 2018 at 10:06 PM Jann Horn <jannh@google.com> wrote: +> >> On Fri, Nov 09, 2018@10:19:03PM +0100, Jann Horn wrote: +> >>> On Fri, Nov 9, 2018@10:06 PM Jann Horn <jannh@google.com> wrote: > >>> On Fri, Nov 9, 2018 at 9:46 PM Joel Fernandes (Google) > >>> <joel@joelfernandes.org> wrote: > >>>> Android uses ashmem for sharing memory regions. We are looking forward @@ -35,13 +35,13 @@ On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote: > >>>> The following program shows the seal > >>>> working in action: > >>> [...] -> >>>> Cc: jreck@google.com -> >>>> Cc: john.stultz@linaro.org -> >>>> Cc: tkjos@google.com -> >>>> Cc: gregkh@linuxfoundation.org -> >>>> Cc: hch@infradead.org -> >>>> Reviewed-by: John Stultz <john.stultz@linaro.org> -> >>>> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> +> >>>> Cc: jreck at google.com +> >>>> Cc: john.stultz at linaro.org +> >>>> Cc: tkjos at google.com +> >>>> Cc: gregkh at linuxfoundation.org +> >>>> Cc: hch at infradead.org +> >>>> Reviewed-by: John Stultz <john.stultz at linaro.org> +> >>>> Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org> > >>>> --- > >>> [...] > >>>> diff --git a/mm/memfd.c b/mm/memfd.c @@ -115,7 +115,7 @@ On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote: > > to the new fix? The patch is based on top of this series. > > > > ---8<----------- -> > From: "Joel Fernandes (Google)" <joel@joelfernandes.org> +> > From: "Joel Fernandes (Google)" <joel at joelfernandes.org> > > Subject: [PATCH] mm/memfd: Fix possible promotion to writeable of sealed memfd > > > > Jann Horn found that reopening an F_SEAL_FUTURE_WRITE sealed memfd @@ -123,8 +123,8 @@ On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote: > > without causing ABI breakages and ugly VFS hacks is to simply deny all > > opens on F_SEAL_FUTURE_WRITE sealed fds. > > -> > Reported-by: Jann Horn <jannh@google.com> -> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> +> > Reported-by: Jann Horn <jannh at google.com> +> > Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org> > > --- > > mm/shmem.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) diff --git a/a/content_digest b/N2/content_digest index c24dda9..13cddd4 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,45 +3,20 @@ "ref\0CAG48ez0kQ4d566bXTFOYANDgii-stL-Qj-oyaBzvfxdV=PU-7g@mail.gmail.com\0" "ref\020181110032005.GA22238@google.com\0" "ref\069CE06CC-E47C-4992-848A-66EB23EE6C74@amacapital.net\0" - "From\0Joel Fernandes <joel@joelfernandes.org>\0" - "Subject\0Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd\0" + "From\0joel@joelfernandes.org (Joel Fernandes)\0" + "Subject\0[PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd\0" "Date\0Sat, 10 Nov 2018 10:24:05 -0800\0" - "To\0Andy Lutomirski <luto@amacapital.net>\0" - "Cc\0Jann Horn <jannh@google.com>" - kernel list <linux-kernel@vger.kernel.org> - jreck@google.com - John Stultz <john.stultz@linaro.org> - Todd Kjos <tkjos@google.com> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - Christoph Hellwig <hch@infradead.org> - Al Viro <viro@zeniv.linux.org.uk> - Andrew Morton <akpm@linux-foundation.org> - Daniel Colascione <dancol@google.com> - Bruce Fields <bfields@fieldses.org> - jlayton@kernel.org - Khalid Aziz <khalid.aziz@oracle.com> - Lei.Yang@windriver.com - linux-fsdevel@vger.kernel.org - linux-kselftest@vger.kernel.org - Linux-MM <linux-mm@kvack.org> - marcandre.lureau@redhat.com - Mike Kravetz <mike.kravetz@oracle.com> - minchan@kernel.org - shuah@kernel.org - valdis.kletnieks@vt.edu - Hugh Dickins <hughd@google.com> - " Linux API <linux-api@vge>\0" "\00:1\0" "b\0" "Thanks Andy for your thoughts, my comments below:\n" "\n" - "On Fri, Nov 09, 2018 at 10:05:14PM -0800, Andy Lutomirski wrote:\n" + "On Fri, Nov 09, 2018@10:05:14PM -0800, Andy Lutomirski wrote:\n" "> \n" "> \n" - "> > On Nov 9, 2018, at 7:20 PM, Joel Fernandes <joel@joelfernandes.org> wrote:\n" + "> > On Nov 9, 2018,@7:20 PM, Joel Fernandes <joel@joelfernandes.org> wrote:\n" "> > \n" - "> >> On Fri, Nov 09, 2018 at 10:19:03PM +0100, Jann Horn wrote:\n" - "> >>> On Fri, Nov 9, 2018 at 10:06 PM Jann Horn <jannh@google.com> wrote:\n" + "> >> On Fri, Nov 09, 2018@10:19:03PM +0100, Jann Horn wrote:\n" + "> >>> On Fri, Nov 9, 2018@10:06 PM Jann Horn <jannh@google.com> wrote:\n" "> >>> On Fri, Nov 9, 2018 at 9:46 PM Joel Fernandes (Google)\n" "> >>> <joel@joelfernandes.org> wrote:\n" "> >>>> Android uses ashmem for sharing memory regions. We are looking forward\n" @@ -70,13 +45,13 @@ "> >>>> The following program shows the seal\n" "> >>>> working in action:\n" "> >>> [...]\n" - "> >>>> Cc: jreck@google.com\n" - "> >>>> Cc: john.stultz@linaro.org\n" - "> >>>> Cc: tkjos@google.com\n" - "> >>>> Cc: gregkh@linuxfoundation.org\n" - "> >>>> Cc: hch@infradead.org\n" - "> >>>> Reviewed-by: John Stultz <john.stultz@linaro.org>\n" - "> >>>> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>\n" + "> >>>> Cc: jreck at google.com\n" + "> >>>> Cc: john.stultz at linaro.org\n" + "> >>>> Cc: tkjos at google.com\n" + "> >>>> Cc: gregkh at linuxfoundation.org\n" + "> >>>> Cc: hch at infradead.org\n" + "> >>>> Reviewed-by: John Stultz <john.stultz at linaro.org>\n" + "> >>>> Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org>\n" "> >>>> ---\n" "> >>> [...]\n" "> >>>> diff --git a/mm/memfd.c b/mm/memfd.c\n" @@ -150,7 +125,7 @@ "> > to the new fix? The patch is based on top of this series.\n" "> > \n" "> > ---8<-----------\n" - "> > From: \"Joel Fernandes (Google)\" <joel@joelfernandes.org>\n" + "> > From: \"Joel Fernandes (Google)\" <joel at joelfernandes.org>\n" "> > Subject: [PATCH] mm/memfd: Fix possible promotion to writeable of sealed memfd\n" "> > \n" "> > Jann Horn found that reopening an F_SEAL_FUTURE_WRITE sealed memfd\n" @@ -158,8 +133,8 @@ "> > without causing ABI breakages and ugly VFS hacks is to simply deny all\n" "> > opens on F_SEAL_FUTURE_WRITE sealed fds.\n" "> > \n" - "> > Reported-by: Jann Horn <jannh@google.com>\n" - "> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>\n" + "> > Reported-by: Jann Horn <jannh at google.com>\n" + "> > Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org>\n" "> > ---\n" "> > mm/shmem.c | 18 ++++++++++++++++++\n" "> > 1 file changed, 18 insertions(+)\n" @@ -264,4 +239,4 @@ "\n" - Joel -f19bda9f4f40f7501daf69fcf248389a0429e3bb7b5a373e1ce9499b57ed0f64 +2b8606d0bb5121887f38fe6736b45c753f73e5da260186a1997b9ea553a5773a
diff --git a/a/content_digest b/N3/content_digest index c24dda9..e2e3f62 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -30,7 +30,7 @@ shuah@kernel.org valdis.kletnieks@vt.edu Hugh Dickins <hughd@google.com> - " Linux API <linux-api@vge>\0" + " Linux API <linux-api@vger.kernel.org>\0" "\00:1\0" "b\0" "Thanks Andy for your thoughts, my comments below:\n" @@ -264,4 +264,4 @@ "\n" - Joel -f19bda9f4f40f7501daf69fcf248389a0429e3bb7b5a373e1ce9499b57ed0f64 +a834fda0bfdb97ecf28869446a5154f4a491c6e6943d3a51dc9f2ce268ec3423
diff --git a/a/1.txt b/N4/1.txt index 6405d16..eaa6455 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -196,7 +196,7 @@ more details in the cover letter). > I see two reasonable solutions: > -> 1. Don’t fiddle with the struct file at all. Instead make the inode flag +> 1. Dona??t fiddle with the struct file at all. Instead make the inode flag > work by itself. Currently, the various VFS paths check only the struct file's f_mode to deny @@ -213,7 +213,7 @@ That will prevent both reopens, and writes from succeeding. However I worry a bit about 2 not being too familiar with VFS internals, about what the consequences of doing that may be. -> 2. Don’t call it a “seal”. Instead fix the /proc hole and add an API to +> 2. Dona??t call it a a??seala??. Instead fix the /proc hole and add an API to > drop write access on an existing struct file. > > I personally prefer #2. diff --git a/a/content_digest b/N4/content_digest index c24dda9..8ee84da 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -30,7 +30,7 @@ shuah@kernel.org valdis.kletnieks@vt.edu Hugh Dickins <hughd@google.com> - " Linux API <linux-api@vge>\0" + " Linux API <linux-api@vger.kernel.org>\0" "\00:1\0" "b\0" "Thanks Andy for your thoughts, my comments below:\n" @@ -231,7 +231,7 @@ "\n" "> I see two reasonable solutions:\n" "> \n" - "> 1. Don\342\200\231t fiddle with the struct file at all. Instead make the inode flag\n" + "> 1. Dona??t fiddle with the struct file at all. Instead make the inode flag\n" "> work by itself.\n" "\n" "Currently, the various VFS paths check only the struct file's f_mode to deny\n" @@ -248,7 +248,7 @@ "bit about 2 not being too familiar with VFS internals, about what the\n" "consequences of doing that may be.\n" "\n" - "> 2. Don\342\200\231t call it a \342\200\234seal\342\200\235. Instead fix the /proc hole and add an API to\n" + "> 2. Dona??t call it a a??seala??. Instead fix the /proc hole and add an API to\n" "> drop write access on an existing struct file.\n" "> \n" "> I personally prefer #2.\n" @@ -264,4 +264,4 @@ "\n" - Joel -f19bda9f4f40f7501daf69fcf248389a0429e3bb7b5a373e1ce9499b57ed0f64 +287112931a56eb52e80a3d255325dfe72444e3d3dafeeaf13520ea6736909fa3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.