diff for duplicates of <20181111023808.GA174670@google.com> diff --git a/a/1.txt b/N1/1.txt index 1d0e611..2296677 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,10 +1,10 @@ On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote: > -> > On Nov 10, 2018, at 2:09 PM, Joel Fernandes <joel@joelfernandes.org> wrote: +> > On Nov 10, 2018, at 2:09 PM, Joel Fernandes <joel at joelfernandes.org> wrote: > > > >> On Sat, Nov 10, 2018 at 11:11:27AM -0800, Daniel Colascione wrote: -> >>> On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione <dancol@google.com> wrote: -> >>>> On Sat, Nov 10, 2018 at 10:24 AM, Joel Fernandes <joel@joelfernandes.org> wrote: +> >>> On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione <dancol at google.com> wrote: +> >>>> On Sat, Nov 10, 2018 at 10:24 AM, Joel Fernandes <joel at joelfernandes.org> wrote: > >>>> Thanks Andy for your thoughts, my comments below: > >> [snip] > >>>> I don't see it as warty, different seals will work differently. It works diff --git a/a/content_digest b/N1/content_digest index e8e0d86..eaa0f44 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,41 +8,18 @@ "ref\0CAKOZueum8MtNvJ5P=W7_pRw62TdQdCgyjCwwbG1wezNboC1cxQ@mail.gmail.com\0" "ref\020181110220933.GB96924@google.com\0" "ref\0907D942E-E321-4BD7-BED7-ACD1D96A3643@amacapital.net\0" - "From\0Joel Fernandes <joel@joelfernandes.org>\0" - "Subject\0Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd\0" + "From\0joel at joelfernandes.org (Joel Fernandes)\0" + "Subject\0[PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd\0" "Date\0Sat, 10 Nov 2018 18:38:08 -0800\0" - "To\0Andy Lutomirski <luto@amacapital.net>\0" - "Cc\0Daniel Colascione <dancol@google.com>" - Jann Horn <jannh@google.com> - kernel list <linux-kernel@vger.kernel.org> - John Reck <jreck@google.com> - John Stultz <john.stultz@linaro.org> - Todd Kjos <tkjos@google.com> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - Christoph Hellwig <hch@infradead.org> - Al Viro <viro@zeniv.linux.org.uk> - Andrew Morton <akpm@linux-foundation.org> - Bruce Fields <bfields@fieldses.org> - Jeff Layton <jlayton@kernel.org> - Khalid Aziz <khalid.aziz@oracle.com> - Lei.Yang@windriver.com - linux-fsdevel@vger.kernel.org - linux-kselftest@vger.kernel.org - Linux-MM <linux-mm@kvack.org> - marcandre.lureau@redhat.com - Mike Kravetz <mike.kravetz@oracle.com> - Minchan Kim <minchan@kernel.org> - Shuah Khan <shuah@kernel.org> - " Valdis\0" "\00:1\0" "b\0" "On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote:\n" "> \n" - "> > On Nov 10, 2018, at 2:09 PM, Joel Fernandes <joel@joelfernandes.org> wrote:\n" + "> > On Nov 10, 2018, at 2:09 PM, Joel Fernandes <joel at joelfernandes.org> wrote:\n" "> > \n" "> >> On Sat, Nov 10, 2018 at 11:11:27AM -0800, Daniel Colascione wrote:\n" - "> >>> On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione <dancol@google.com> wrote:\n" - "> >>>> On Sat, Nov 10, 2018 at 10:24 AM, Joel Fernandes <joel@joelfernandes.org> wrote:\n" + "> >>> On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione <dancol at google.com> wrote:\n" + "> >>>> On Sat, Nov 10, 2018 at 10:24 AM, Joel Fernandes <joel at joelfernandes.org> wrote:\n" "> >>>> Thanks Andy for your thoughts, my comments below:\n" "> >> [snip]\n" "> >>>> I don't see it as warty, different seals will work differently. It works\n" @@ -158,4 +135,4 @@ "\n" - Joel -238d25a87cbe3af0815c1934c6b530066d9774c2b445d1459da5c7afc128a04f +b67ebeb41f17466b03eb1cba7075ed1e5795a250e410f928e55515989732fda6
diff --git a/a/1.txt b/N2/1.txt index 1d0e611..73d8d09 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,10 +1,10 @@ -On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote: +On Sat, Nov 10, 2018@02:18:23PM -0800, Andy Lutomirski wrote: > -> > On Nov 10, 2018, at 2:09 PM, Joel Fernandes <joel@joelfernandes.org> wrote: +> > On Nov 10, 2018,@2:09 PM, Joel Fernandes <joel@joelfernandes.org> wrote: > > -> >> On Sat, Nov 10, 2018 at 11:11:27AM -0800, Daniel Colascione wrote: -> >>> On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione <dancol@google.com> wrote: -> >>>> On Sat, Nov 10, 2018 at 10:24 AM, Joel Fernandes <joel@joelfernandes.org> wrote: +> >> On Sat, Nov 10, 2018@11:11:27AM -0800, Daniel Colascione wrote: +> >>> On Sat, Nov 10, 2018@10:45 AM, Daniel Colascione <dancol@google.com> wrote: +> >>>> On Sat, Nov 10, 2018@10:24 AM, Joel Fernandes <joel@joelfernandes.org> wrote: > >>>> Thanks Andy for your thoughts, my comments below: > >> [snip] > >>>> I don't see it as warty, different seals will work differently. It works diff --git a/a/content_digest b/N2/content_digest index e8e0d86..9ecfa30 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -8,41 +8,18 @@ "ref\0CAKOZueum8MtNvJ5P=W7_pRw62TdQdCgyjCwwbG1wezNboC1cxQ@mail.gmail.com\0" "ref\020181110220933.GB96924@google.com\0" "ref\0907D942E-E321-4BD7-BED7-ACD1D96A3643@amacapital.net\0" - "From\0Joel Fernandes <joel@joelfernandes.org>\0" - "Subject\0Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd\0" + "From\0joel@joelfernandes.org (Joel Fernandes)\0" + "Subject\0[PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd\0" "Date\0Sat, 10 Nov 2018 18:38:08 -0800\0" - "To\0Andy Lutomirski <luto@amacapital.net>\0" - "Cc\0Daniel Colascione <dancol@google.com>" - Jann Horn <jannh@google.com> - kernel list <linux-kernel@vger.kernel.org> - John Reck <jreck@google.com> - John Stultz <john.stultz@linaro.org> - Todd Kjos <tkjos@google.com> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - Christoph Hellwig <hch@infradead.org> - Al Viro <viro@zeniv.linux.org.uk> - Andrew Morton <akpm@linux-foundation.org> - Bruce Fields <bfields@fieldses.org> - Jeff Layton <jlayton@kernel.org> - Khalid Aziz <khalid.aziz@oracle.com> - Lei.Yang@windriver.com - linux-fsdevel@vger.kernel.org - linux-kselftest@vger.kernel.org - Linux-MM <linux-mm@kvack.org> - marcandre.lureau@redhat.com - Mike Kravetz <mike.kravetz@oracle.com> - Minchan Kim <minchan@kernel.org> - Shuah Khan <shuah@kernel.org> - " Valdis\0" "\00:1\0" "b\0" - "On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote:\n" + "On Sat, Nov 10, 2018@02:18:23PM -0800, Andy Lutomirski wrote:\n" "> \n" - "> > On Nov 10, 2018, at 2:09 PM, Joel Fernandes <joel@joelfernandes.org> wrote:\n" + "> > On Nov 10, 2018,@2:09 PM, Joel Fernandes <joel@joelfernandes.org> wrote:\n" "> > \n" - "> >> On Sat, Nov 10, 2018 at 11:11:27AM -0800, Daniel Colascione wrote:\n" - "> >>> On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione <dancol@google.com> wrote:\n" - "> >>>> On Sat, Nov 10, 2018 at 10:24 AM, Joel Fernandes <joel@joelfernandes.org> wrote:\n" + "> >> On Sat, Nov 10, 2018@11:11:27AM -0800, Daniel Colascione wrote:\n" + "> >>> On Sat, Nov 10, 2018@10:45 AM, Daniel Colascione <dancol@google.com> wrote:\n" + "> >>>> On Sat, Nov 10, 2018@10:24 AM, Joel Fernandes <joel@joelfernandes.org> wrote:\n" "> >>>> Thanks Andy for your thoughts, my comments below:\n" "> >> [snip]\n" "> >>>> I don't see it as warty, different seals will work differently. It works\n" @@ -158,4 +135,4 @@ "\n" - Joel -238d25a87cbe3af0815c1934c6b530066d9774c2b445d1459da5c7afc128a04f +88cc42a54196b7491e6f4c63db4ce3ea5b3b5893bfc01fb7e33f45b3c06f217f
diff --git a/a/content_digest b/N3/content_digest index e8e0d86..b9212cf 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -33,7 +33,9 @@ Mike Kravetz <mike.kravetz@oracle.com> Minchan Kim <minchan@kernel.org> Shuah Khan <shuah@kernel.org> - " Valdis\0" + Valdis Kletnieks <valdis.kletnieks@vt.edu> + Hugh Dickins <hughd@google.com> + " Linux API <linux-api@vger.kernel.org>\0" "\00:1\0" "b\0" "On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote:\n" @@ -158,4 +160,4 @@ "\n" - Joel -238d25a87cbe3af0815c1934c6b530066d9774c2b445d1459da5c7afc128a04f +daa5c3488ca3c763e778e3f05cb46096a37dfca13b6e52aee174685b302389af
diff --git a/a/1.txt b/N4/1.txt index 1d0e611..9640954 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -46,7 +46,7 @@ On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote: > >>>> > >>>>> I see two reasonable solutions: > >>>>> -> >>>>> 1. Don’t fiddle with the struct file at all. Instead make the inode flag +> >>>>> 1. Dona??t fiddle with the struct file at all. Instead make the inode flag > >>>>> work by itself. > >>>> > >>>> Currently, the various VFS paths check only the struct file's f_mode to deny @@ -105,9 +105,9 @@ Also, it means we have to keep CONFIG_TMPFS enabled so that the shmem_file_operations write handlers like write_iter are hooked up. Currently memfd works even with !CONFIG_TMPFS. -> - add_seals won’t need the wait_for_pins and mapping_deny_write logic. +> - add_seals wona??t need the wait_for_pins and mapping_deny_write logic. > -> That really should be all that’s needed. +> That really should be all thata??s needed. It seems a fair idea what you're saying. But I don't see how its less complex.. IMO its far more simple to have VFS do the denial of the operations diff --git a/a/content_digest b/N4/content_digest index e8e0d86..f579468 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -33,7 +33,9 @@ Mike Kravetz <mike.kravetz@oracle.com> Minchan Kim <minchan@kernel.org> Shuah Khan <shuah@kernel.org> - " Valdis\0" + Valdis Kletnieks <valdis.kletnieks@vt.edu> + Hugh Dickins <hughd@google.com> + " Linux API <linux-api@vger.kernel.org>\0" "\00:1\0" "b\0" "On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote:\n" @@ -84,7 +86,7 @@ "> >>>> \n" "> >>>>> I see two reasonable solutions:\n" "> >>>>> \n" - "> >>>>> 1. Don\342\200\231t fiddle with the struct file at all. Instead make the inode flag\n" + "> >>>>> 1. Dona??t fiddle with the struct file at all. Instead make the inode flag\n" "> >>>>> work by itself.\n" "> >>>> \n" "> >>>> Currently, the various VFS paths check only the struct file's f_mode to deny\n" @@ -143,9 +145,9 @@ "shmem_file_operations write handlers like write_iter are hooked up. Currently\n" "memfd works even with !CONFIG_TMPFS.\n" "\n" - "> - add_seals won\342\200\231t need the wait_for_pins and mapping_deny_write logic.\n" + "> - add_seals wona??t need the wait_for_pins and mapping_deny_write logic.\n" "> \n" - "> That really should be all that\342\200\231s needed.\n" + "> That really should be all thata??s needed.\n" "\n" "It seems a fair idea what you're saying. But I don't see how its less\n" "complex.. IMO its far more simple to have VFS do the denial of the operations\n" @@ -158,4 +160,4 @@ "\n" - Joel -238d25a87cbe3af0815c1934c6b530066d9774c2b445d1459da5c7afc128a04f +b167aff60d81de7bfd15ed03c883c0171a76bdf4983becdb317baf729ee7a013
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.