From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
"yipeng1.wang@intel.com" <yipeng1.wang@intel.com>,
"dharmik.thakkar@arm.com" <dharmik.thakkar@arm.com>,
"gavin.hu@arm.com" <gavin.hu@arm.com>, "nd@arm.com" <nd@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Kapoor, Prasun" <Prasun.Kapoor@cavium.com>
Subject: Re: [PATCH v2 1/1] hash: separate lf and rw lock lookup code paths
Date: Sun, 11 Nov 2018 07:48:22 +0000 [thread overview]
Message-ID: <20181111074805.GA3496@jerin> (raw)
In-Reply-To: <20181110185534.5444-2-honnappa.nagarahalli@arm.com>
-----Original Message-----
> Date: Sat, 10 Nov 2018 12:55:34 -0600
> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> To: bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com
> CC: dev@dpdk.org, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
> chaozhu@linux.vnet.ibm.com, yipeng1.wang@intel.com,
> dharmik.thakkar@arm.com, gavin.hu@arm.com, honnappa.nagarahalli@arm.com,
> nd@arm.com
> Subject: [PATCH v2 1/1] hash: separate lf and rw lock lookup code paths
> X-Mailer: git-send-email 2.17.1
>
>
> The lock-free algorithm has caused significant lookup
> performance regression for certain use cases. The
> regression is attributed to the use of non-relaxed
> memory orderings. 2 versions of the lookup functions
> are created. One that uses the RW lock and the one that
> is lock-free. This restores the performance regression
> caused for use cases that used RW lock version of the
> lookup function.
>
> Fixes: e605a1d36 ("hash: add lock-free r/w concurrency")
> Cc: honnappa.nagarahalli@arm.com
>
> Suggested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
- Reported l3fwd hash regression for ARMv8 platform fixed
with this patch by introducing two different code path(obviously!!)
- Verified lock version of lookup() is same as e605a1d36~1 changeset
+ Thomas,
If there is no objection, please consider this patch into -RC3
next prev parent reply other threads:[~2018-11-11 7:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 16:39 [PATCH 0/4] hash: separate lf and rw lock lookup code paths Honnappa Nagarahalli
2018-11-09 16:39 ` [PATCH 1/4] hash: prepare for lock-free and rw-lock separation Honnappa Nagarahalli
2018-11-09 16:39 ` [PATCH 2/4] hash: remove rw-lock calls from lock-free functions Honnappa Nagarahalli
2018-11-09 16:39 ` [PATCH 3/4] hash: remove memory orderings from rw-lock lookup fns Honnappa Nagarahalli
2018-11-10 8:51 ` Jerin Jacob
2018-11-10 18:58 ` Honnappa Nagarahalli
2018-11-09 16:39 ` [PATCH 4/4] hash: separate lf and rw lock lookup code paths Honnappa Nagarahalli
2018-11-10 18:55 ` [PATCH v2 0/1] " Honnappa Nagarahalli
2018-11-10 18:55 ` [PATCH v2 1/1] " Honnappa Nagarahalli
2018-11-11 7:48 ` Jerin Jacob [this message]
2018-11-13 16:37 ` Thomas Monjalon
2018-11-11 21:43 ` Wang, Yipeng1
2018-11-12 4:50 ` Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181111074805.GA3496@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=Prasun.Kapoor@cavium.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.