diff for duplicates of <20181111121954.145cbd2f@archlinux> diff --git a/a/1.txt b/N1/1.txt index cde3853..df532d4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,11 +2,10 @@ On Fri, 9 Nov 2018 17:43:00 +0200 Stefan Popa <stefan.popa@analog.com> wrote: > Add support for Analog Devices AD7124 4-channels and 8-channels ADC. ->=20 +> > Signed-off-by: Stefan Popa <stefan.popa@analog.com> -Your example still includes the other things that I think you have now drop= -ped. +Your example still includes the other things that I think you have now dropped. gain and odr. > --- @@ -14,24 +13,18 @@ gain and odr. > - Nothing changed. > Changes in v3: > - Removed the "adi,channels" property. -> - Used the "reg" property to get the channel number and "adi,diff-channe= -ls" -> for the differential pins. The "adi,channel-number" property was remov= -ed. +> - Used the "reg" property to get the channel number and "adi,diff-channels" +> for the differential pins. The "adi,channel-number" property was removed. > - adi,bipolar is of boolean type. > Changes in v4: -> - Used the bipolar and diff-channels properties defined in the new adc.t= -xt doc. ->=20 -> .../devicetree/bindings/iio/adc/adi,ad7124.txt | 81 ++++++++++++++++= -++++++ +> - Used the bipolar and diff-channels properties defined in the new adc.txt doc. +> +> .../devicetree/bindings/iio/adc/adi,ad7124.txt | 81 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 82 insertions(+) -> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7124.= -txt ->=20 -> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt b/D= -ocumentation/devicetree/bindings/iio/adc/adi,ad7124.txt +> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt +> +> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt b/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt > new file mode 100644 > index 0000000..fa0c43b > --- /dev/null @@ -48,8 +41,7 @@ ocumentation/devicetree/bindings/iio/adc/adi,ad7124.txt > + see: Documentation/devicetree/bindings/clock/clock-bindings.txt > + - clock-names: Must be "mclk". > + - interrupts: IRQ line for the ADC -> + see: Documentation/devicetree/bindings/interrupt-controller/interrupts= -.txt +> + see: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Given the driver doesn't currently use it, should perhaps be optional? @@ -58,21 +50,19 @@ Given the driver doesn't currently use it, should perhaps be optional? > + * #address-cells: Must be 1. > + * #size-cells: Must be 0. > + -> + Subnode(s) represent the external channels which are connected to the= - ADC. +> + Subnode(s) represent the external channels which are connected to the ADC. > + Each subnode represents one channel and has the following properties: > + Required properties: > + * reg: The channel number. It can have up to 4 channels on ad7124-4 > + and 8 channels on ad7124-8, numbered from 0 to 15. -> + * diff-channels: see: Documentation/devicetree/bindings/iio/adc/adc.t= -xt +> + * diff-channels: see: Documentation/devicetree/bindings/iio/adc/adc.txt > + > + Optional properties: > + * bipolar: see: Documentation/devicetree/bindings/iio/adc/adc.txt > + * adi,reference-select: Select the reference source to use when > + converting on the the specific channel. Valid values are: -> + 0: REFIN1(+)/REFIN1(=E2=88=92). -> + 1: REFIN2(+)/REFIN2(=E2=88=92). +> + 0: REFIN1(+)/REFIN1(−). +> + 1: REFIN2(+)/REFIN2(−). > + 3: AVDD > + If this field is left empty, internal reference is selected. > + @@ -83,47 +73,47 @@ xt > + > +Example: > + adc@0 { -> + compatible =3D "adi,ad7124-4"; -> + reg =3D <0>; -> + spi-max-frequency =3D <5000000>; -> + interrupts =3D <25 2>; -> + interrupt-parent =3D <&gpio>; -> + refin1-supply =3D <&adc_vref>; -> + clocks =3D <&ad7124_mclk>; -> + clock-names =3D "mclk"; +> + compatible = "adi,ad7124-4"; +> + reg = <0>; +> + spi-max-frequency = <5000000>; +> + interrupts = <25 2>; +> + interrupt-parent = <&gpio>; +> + refin1-supply = <&adc_vref>; +> + clocks = <&ad7124_mclk>; +> + clock-names = "mclk"; > + -> + #address-cells =3D <1>; -> + #size-cells =3D <0>; +> + #address-cells = <1>; +> + #size-cells = <0>; > + > + channel@0 { -> + reg =3D <0>; -> + adi,diff-channels =3D <0 1>; -> + adi,reference-select =3D <0>; -> + adi,gain =3D <2>; -> + adi,odr-hz =3D <10>; +> + reg = <0>; +> + adi,diff-channels = <0 1>; +> + adi,reference-select = <0>; +> + adi,gain = <2>; +> + adi,odr-hz = <10>; I think you have dropped these two.. > + }; > + > + channel@1 { -> + reg =3D <1>; +> + reg = <1>; > + adi,bipolar; -> + adi,diff-channels =3D <2 3>; -> + adi,reference-select =3D <0>; -> + adi,gain =3D <4>; -> + adi,odr-hz =3D <50>; +> + adi,diff-channels = <2 3>; +> + adi,reference-select = <0>; +> + adi,gain = <4>; +> + adi,odr-hz = <50>; > + }; > + > + channel@2 { -> + reg =3D <2>; -> + adi,diff-channels =3D <4 5>; -> + adi,gain =3D <128>; -> + adi,odr-hz =3D <19200>; +> + reg = <2>; +> + adi,diff-channels = <4 5>; +> + adi,gain = <128>; +> + adi,odr-hz = <19200>; > + }; > + > + channel@3 { -> + reg =3D <3>; -> + adi,diff-channels =3D <6 7>; +> + reg = <3>; +> + adi,diff-channels = <6 7>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS @@ -135,6 +125,6 @@ I think you have dropped these two.. > S: Supported > F: drivers/iio/adc/ad7124.c > +F: Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt -> =20 +> > ANALOG DEVICES INC AD9389B DRIVER > M: Hans Verkuil <hans.verkuil@cisco.com> diff --git a/a/content_digest b/N1/content_digest index b06ffbe..aae9355 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,27 +3,26 @@ "Subject\0Re: [PATCH v4 4/4] dt-bindings: iio: adc: Add docs for ad7124\0" "Date\0Sun, 11 Nov 2018 12:19:54 +0000\0" "To\0Stefan Popa <stefan.popa@analog.com>\0" - "Cc\0<robh+dt@kernel.org>" - <mark.rutland@arm.com> - <knaack.h@gmx.de> - <lars@metafoo.de> - <pmeerw@pmeerw.net> - <Michael.Hennerich@analog.com> - <gregkh@linuxfoundation.org> - <linux-iio@vger.kernel.org> - <devicetree@vger.kernel.org> - " <linux-kernel@vger.kernel.org>\0" + "Cc\0robh+dt@kernel.org" + mark.rutland@arm.com + knaack.h@gmx.de + lars@metafoo.de + pmeerw@pmeerw.net + Michael.Hennerich@analog.com + gregkh@linuxfoundation.org + linux-iio@vger.kernel.org + devicetree@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Fri, 9 Nov 2018 17:43:00 +0200\n" "Stefan Popa <stefan.popa@analog.com> wrote:\n" "\n" "> Add support for Analog Devices AD7124 4-channels and 8-channels ADC.\n" - ">=20\n" + "> \n" "> Signed-off-by: Stefan Popa <stefan.popa@analog.com>\n" "\n" - "Your example still includes the other things that I think you have now drop=\n" - "ped.\n" + "Your example still includes the other things that I think you have now dropped.\n" "gain and odr.\n" "\n" "> ---\n" @@ -31,24 +30,18 @@ "> \t- Nothing changed.\n" "> Changes in v3:\n" "> \t- Removed the \"adi,channels\" property.\n" - "> \t- Used the \"reg\" property to get the channel number and \"adi,diff-channe=\n" - "ls\"\n" - "> \t for the differential pins. The \"adi,channel-number\" property was remov=\n" - "ed.\n" + "> \t- Used the \"reg\" property to get the channel number and \"adi,diff-channels\"\n" + "> \t for the differential pins. The \"adi,channel-number\" property was removed.\n" "> \t- adi,bipolar is of boolean type.\n" "> Changes in v4:\n" - "> \t- Used the bipolar and diff-channels properties defined in the new adc.t=\n" - "xt doc.\n" - ">=20\n" - "> .../devicetree/bindings/iio/adc/adi,ad7124.txt | 81 ++++++++++++++++=\n" - "++++++\n" + "> \t- Used the bipolar and diff-channels properties defined in the new adc.txt doc.\n" + "> \n" + "> .../devicetree/bindings/iio/adc/adi,ad7124.txt | 81 ++++++++++++++++++++++\n" "> MAINTAINERS | 1 +\n" "> 2 files changed, 82 insertions(+)\n" - "> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7124.=\n" - "txt\n" - ">=20\n" - "> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt b/D=\n" - "ocumentation/devicetree/bindings/iio/adc/adi,ad7124.txt\n" + "> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt\n" + "> \n" + "> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt b/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt\n" "> new file mode 100644\n" "> index 0000000..fa0c43b\n" "> --- /dev/null\n" @@ -65,8 +58,7 @@ "> +\t\tsee: Documentation/devicetree/bindings/clock/clock-bindings.txt\n" "> +\t- clock-names: Must be \"mclk\".\n" "> +\t- interrupts: IRQ line for the ADC\n" - "> +\t\tsee: Documentation/devicetree/bindings/interrupt-controller/interrupts=\n" - ".txt\n" + "> +\t\tsee: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt\n" "\n" "Given the driver doesn't currently use it, should perhaps be optional?\n" "\n" @@ -75,21 +67,19 @@ "> +\t\t* #address-cells: Must be 1.\n" "> +\t\t* #size-cells: Must be 0.\n" "> +\n" - "> +\t Subnode(s) represent the external channels which are connected to the=\n" - " ADC.\n" + "> +\t Subnode(s) represent the external channels which are connected to the ADC.\n" "> +\t Each subnode represents one channel and has the following properties:\n" "> +\t\tRequired properties:\n" "> +\t\t\t* reg: The channel number. It can have up to 4 channels on ad7124-4\n" "> +\t\t\t and 8 channels on ad7124-8, numbered from 0 to 15.\n" - "> +\t\t\t* diff-channels: see: Documentation/devicetree/bindings/iio/adc/adc.t=\n" - "xt\n" + "> +\t\t\t* diff-channels: see: Documentation/devicetree/bindings/iio/adc/adc.txt\n" "> +\n" "> +\t\tOptional properties:\n" "> +\t\t\t* bipolar: see: Documentation/devicetree/bindings/iio/adc/adc.txt\n" "> +\t\t\t* adi,reference-select: Select the reference source to use when\n" "> +\t\t\t converting on the the specific channel. Valid values are:\n" - "> +\t\t\t 0: REFIN1(+)/REFIN1(=E2=88=92).\n" - "> +\t\t\t 1: REFIN2(+)/REFIN2(=E2=88=92).\n" + "> +\t\t\t 0: REFIN1(+)/REFIN1(\342\210\222).\n" + "> +\t\t\t 1: REFIN2(+)/REFIN2(\342\210\222).\n" "> +\t\t\t 3: AVDD\n" "> +\t\t\t If this field is left empty, internal reference is selected.\n" "> +\n" @@ -100,47 +90,47 @@ "> +\n" "> +Example:\n" "> +\tadc@0 {\n" - "> +\t\tcompatible =3D \"adi,ad7124-4\";\n" - "> +\t\treg =3D <0>;\n" - "> +\t\tspi-max-frequency =3D <5000000>;\n" - "> +\t\tinterrupts =3D <25 2>;\n" - "> +\t\tinterrupt-parent =3D <&gpio>;\n" - "> +\t\trefin1-supply =3D <&adc_vref>;\n" - "> +\t\tclocks =3D <&ad7124_mclk>;\n" - "> +\t\tclock-names =3D \"mclk\";\n" + "> +\t\tcompatible = \"adi,ad7124-4\";\n" + "> +\t\treg = <0>;\n" + "> +\t\tspi-max-frequency = <5000000>;\n" + "> +\t\tinterrupts = <25 2>;\n" + "> +\t\tinterrupt-parent = <&gpio>;\n" + "> +\t\trefin1-supply = <&adc_vref>;\n" + "> +\t\tclocks = <&ad7124_mclk>;\n" + "> +\t\tclock-names = \"mclk\";\n" "> +\n" - "> +\t\t#address-cells =3D <1>;\n" - "> +\t\t#size-cells =3D <0>;\n" + "> +\t\t#address-cells = <1>;\n" + "> +\t\t#size-cells = <0>;\n" "> +\n" "> +\t\tchannel@0 {\n" - "> +\t\t\treg =3D <0>;\n" - "> +\t\t\tadi,diff-channels =3D <0 1>;\n" - "> +\t\t\tadi,reference-select =3D <0>;\n" - "> +\t\t\tadi,gain =3D <2>;\n" - "> +\t\t\tadi,odr-hz =3D <10>;\n" + "> +\t\t\treg = <0>;\n" + "> +\t\t\tadi,diff-channels = <0 1>;\n" + "> +\t\t\tadi,reference-select = <0>;\n" + "> +\t\t\tadi,gain = <2>;\n" + "> +\t\t\tadi,odr-hz = <10>;\n" "I think you have dropped these two..\n" "\n" "> +\t\t};\n" "> +\n" "> +\t\tchannel@1 {\n" - "> +\t\t\treg =3D <1>;\n" + "> +\t\t\treg = <1>;\n" "> +\t\t\tadi,bipolar;\n" - "> +\t\t\tadi,diff-channels =3D <2 3>;\n" - "> +\t\t\tadi,reference-select =3D <0>;\n" - "> +\t\t\tadi,gain =3D <4>;\n" - "> +\t\t\tadi,odr-hz =3D <50>;\n" + "> +\t\t\tadi,diff-channels = <2 3>;\n" + "> +\t\t\tadi,reference-select = <0>;\n" + "> +\t\t\tadi,gain = <4>;\n" + "> +\t\t\tadi,odr-hz = <50>;\n" "> +\t\t};\n" "> +\n" "> +\t\tchannel@2 {\n" - "> +\t\t\treg =3D <2>;\n" - "> +\t\t\tadi,diff-channels =3D <4 5>;\n" - "> +\t\t\tadi,gain =3D <128>;\n" - "> +\t\t\tadi,odr-hz =3D <19200>;\n" + "> +\t\t\treg = <2>;\n" + "> +\t\t\tadi,diff-channels = <4 5>;\n" + "> +\t\t\tadi,gain = <128>;\n" + "> +\t\t\tadi,odr-hz = <19200>;\n" "> +\t\t};\n" "> +\n" "> +\t\tchannel@3 {\n" - "> +\t\t\treg =3D <3>;\n" - "> +\t\t\tadi,diff-channels =3D <6 7>;\n" + "> +\t\t\treg = <3>;\n" + "> +\t\t\tadi,diff-channels = <6 7>;\n" "> +\t\t};\n" "> +\t};\n" "> diff --git a/MAINTAINERS b/MAINTAINERS\n" @@ -152,8 +142,8 @@ "> S:\tSupported\n" "> F:\tdrivers/iio/adc/ad7124.c\n" "> +F:\tDocumentation/devicetree/bindings/iio/adc/adi,ad7124.txt\n" - "> =20\n" + "> \n" "> ANALOG DEVICES INC AD9389B DRIVER\n" "> M:\tHans Verkuil <hans.verkuil@cisco.com>" -96663c0e50b089d5e3a0cc0c1887132f3c106a4f9743780194d08b27c34da4e1 +9edecef2b2885999c3e7b90951559b96c7c7f3c75cdf268374e62d4d9e33a7d3
diff --git a/a/1.txt b/N2/1.txt index cde3853..df532d4 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,11 +2,10 @@ On Fri, 9 Nov 2018 17:43:00 +0200 Stefan Popa <stefan.popa@analog.com> wrote: > Add support for Analog Devices AD7124 4-channels and 8-channels ADC. ->=20 +> > Signed-off-by: Stefan Popa <stefan.popa@analog.com> -Your example still includes the other things that I think you have now drop= -ped. +Your example still includes the other things that I think you have now dropped. gain and odr. > --- @@ -14,24 +13,18 @@ gain and odr. > - Nothing changed. > Changes in v3: > - Removed the "adi,channels" property. -> - Used the "reg" property to get the channel number and "adi,diff-channe= -ls" -> for the differential pins. The "adi,channel-number" property was remov= -ed. +> - Used the "reg" property to get the channel number and "adi,diff-channels" +> for the differential pins. The "adi,channel-number" property was removed. > - adi,bipolar is of boolean type. > Changes in v4: -> - Used the bipolar and diff-channels properties defined in the new adc.t= -xt doc. ->=20 -> .../devicetree/bindings/iio/adc/adi,ad7124.txt | 81 ++++++++++++++++= -++++++ +> - Used the bipolar and diff-channels properties defined in the new adc.txt doc. +> +> .../devicetree/bindings/iio/adc/adi,ad7124.txt | 81 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 82 insertions(+) -> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7124.= -txt ->=20 -> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt b/D= -ocumentation/devicetree/bindings/iio/adc/adi,ad7124.txt +> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt +> +> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt b/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt > new file mode 100644 > index 0000000..fa0c43b > --- /dev/null @@ -48,8 +41,7 @@ ocumentation/devicetree/bindings/iio/adc/adi,ad7124.txt > + see: Documentation/devicetree/bindings/clock/clock-bindings.txt > + - clock-names: Must be "mclk". > + - interrupts: IRQ line for the ADC -> + see: Documentation/devicetree/bindings/interrupt-controller/interrupts= -.txt +> + see: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Given the driver doesn't currently use it, should perhaps be optional? @@ -58,21 +50,19 @@ Given the driver doesn't currently use it, should perhaps be optional? > + * #address-cells: Must be 1. > + * #size-cells: Must be 0. > + -> + Subnode(s) represent the external channels which are connected to the= - ADC. +> + Subnode(s) represent the external channels which are connected to the ADC. > + Each subnode represents one channel and has the following properties: > + Required properties: > + * reg: The channel number. It can have up to 4 channels on ad7124-4 > + and 8 channels on ad7124-8, numbered from 0 to 15. -> + * diff-channels: see: Documentation/devicetree/bindings/iio/adc/adc.t= -xt +> + * diff-channels: see: Documentation/devicetree/bindings/iio/adc/adc.txt > + > + Optional properties: > + * bipolar: see: Documentation/devicetree/bindings/iio/adc/adc.txt > + * adi,reference-select: Select the reference source to use when > + converting on the the specific channel. Valid values are: -> + 0: REFIN1(+)/REFIN1(=E2=88=92). -> + 1: REFIN2(+)/REFIN2(=E2=88=92). +> + 0: REFIN1(+)/REFIN1(−). +> + 1: REFIN2(+)/REFIN2(−). > + 3: AVDD > + If this field is left empty, internal reference is selected. > + @@ -83,47 +73,47 @@ xt > + > +Example: > + adc@0 { -> + compatible =3D "adi,ad7124-4"; -> + reg =3D <0>; -> + spi-max-frequency =3D <5000000>; -> + interrupts =3D <25 2>; -> + interrupt-parent =3D <&gpio>; -> + refin1-supply =3D <&adc_vref>; -> + clocks =3D <&ad7124_mclk>; -> + clock-names =3D "mclk"; +> + compatible = "adi,ad7124-4"; +> + reg = <0>; +> + spi-max-frequency = <5000000>; +> + interrupts = <25 2>; +> + interrupt-parent = <&gpio>; +> + refin1-supply = <&adc_vref>; +> + clocks = <&ad7124_mclk>; +> + clock-names = "mclk"; > + -> + #address-cells =3D <1>; -> + #size-cells =3D <0>; +> + #address-cells = <1>; +> + #size-cells = <0>; > + > + channel@0 { -> + reg =3D <0>; -> + adi,diff-channels =3D <0 1>; -> + adi,reference-select =3D <0>; -> + adi,gain =3D <2>; -> + adi,odr-hz =3D <10>; +> + reg = <0>; +> + adi,diff-channels = <0 1>; +> + adi,reference-select = <0>; +> + adi,gain = <2>; +> + adi,odr-hz = <10>; I think you have dropped these two.. > + }; > + > + channel@1 { -> + reg =3D <1>; +> + reg = <1>; > + adi,bipolar; -> + adi,diff-channels =3D <2 3>; -> + adi,reference-select =3D <0>; -> + adi,gain =3D <4>; -> + adi,odr-hz =3D <50>; +> + adi,diff-channels = <2 3>; +> + adi,reference-select = <0>; +> + adi,gain = <4>; +> + adi,odr-hz = <50>; > + }; > + > + channel@2 { -> + reg =3D <2>; -> + adi,diff-channels =3D <4 5>; -> + adi,gain =3D <128>; -> + adi,odr-hz =3D <19200>; +> + reg = <2>; +> + adi,diff-channels = <4 5>; +> + adi,gain = <128>; +> + adi,odr-hz = <19200>; > + }; > + > + channel@3 { -> + reg =3D <3>; -> + adi,diff-channels =3D <6 7>; +> + reg = <3>; +> + adi,diff-channels = <6 7>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS @@ -135,6 +125,6 @@ I think you have dropped these two.. > S: Supported > F: drivers/iio/adc/ad7124.c > +F: Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt -> =20 +> > ANALOG DEVICES INC AD9389B DRIVER > M: Hans Verkuil <hans.verkuil@cisco.com> diff --git a/a/content_digest b/N2/content_digest index b06ffbe..1c4e611 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -19,11 +19,10 @@ "Stefan Popa <stefan.popa@analog.com> wrote:\n" "\n" "> Add support for Analog Devices AD7124 4-channels and 8-channels ADC.\n" - ">=20\n" + "> \n" "> Signed-off-by: Stefan Popa <stefan.popa@analog.com>\n" "\n" - "Your example still includes the other things that I think you have now drop=\n" - "ped.\n" + "Your example still includes the other things that I think you have now dropped.\n" "gain and odr.\n" "\n" "> ---\n" @@ -31,24 +30,18 @@ "> \t- Nothing changed.\n" "> Changes in v3:\n" "> \t- Removed the \"adi,channels\" property.\n" - "> \t- Used the \"reg\" property to get the channel number and \"adi,diff-channe=\n" - "ls\"\n" - "> \t for the differential pins. The \"adi,channel-number\" property was remov=\n" - "ed.\n" + "> \t- Used the \"reg\" property to get the channel number and \"adi,diff-channels\"\n" + "> \t for the differential pins. The \"adi,channel-number\" property was removed.\n" "> \t- adi,bipolar is of boolean type.\n" "> Changes in v4:\n" - "> \t- Used the bipolar and diff-channels properties defined in the new adc.t=\n" - "xt doc.\n" - ">=20\n" - "> .../devicetree/bindings/iio/adc/adi,ad7124.txt | 81 ++++++++++++++++=\n" - "++++++\n" + "> \t- Used the bipolar and diff-channels properties defined in the new adc.txt doc.\n" + "> \n" + "> .../devicetree/bindings/iio/adc/adi,ad7124.txt | 81 ++++++++++++++++++++++\n" "> MAINTAINERS | 1 +\n" "> 2 files changed, 82 insertions(+)\n" - "> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7124.=\n" - "txt\n" - ">=20\n" - "> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt b/D=\n" - "ocumentation/devicetree/bindings/iio/adc/adi,ad7124.txt\n" + "> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt\n" + "> \n" + "> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt b/Documentation/devicetree/bindings/iio/adc/adi,ad7124.txt\n" "> new file mode 100644\n" "> index 0000000..fa0c43b\n" "> --- /dev/null\n" @@ -65,8 +58,7 @@ "> +\t\tsee: Documentation/devicetree/bindings/clock/clock-bindings.txt\n" "> +\t- clock-names: Must be \"mclk\".\n" "> +\t- interrupts: IRQ line for the ADC\n" - "> +\t\tsee: Documentation/devicetree/bindings/interrupt-controller/interrupts=\n" - ".txt\n" + "> +\t\tsee: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt\n" "\n" "Given the driver doesn't currently use it, should perhaps be optional?\n" "\n" @@ -75,21 +67,19 @@ "> +\t\t* #address-cells: Must be 1.\n" "> +\t\t* #size-cells: Must be 0.\n" "> +\n" - "> +\t Subnode(s) represent the external channels which are connected to the=\n" - " ADC.\n" + "> +\t Subnode(s) represent the external channels which are connected to the ADC.\n" "> +\t Each subnode represents one channel and has the following properties:\n" "> +\t\tRequired properties:\n" "> +\t\t\t* reg: The channel number. It can have up to 4 channels on ad7124-4\n" "> +\t\t\t and 8 channels on ad7124-8, numbered from 0 to 15.\n" - "> +\t\t\t* diff-channels: see: Documentation/devicetree/bindings/iio/adc/adc.t=\n" - "xt\n" + "> +\t\t\t* diff-channels: see: Documentation/devicetree/bindings/iio/adc/adc.txt\n" "> +\n" "> +\t\tOptional properties:\n" "> +\t\t\t* bipolar: see: Documentation/devicetree/bindings/iio/adc/adc.txt\n" "> +\t\t\t* adi,reference-select: Select the reference source to use when\n" "> +\t\t\t converting on the the specific channel. Valid values are:\n" - "> +\t\t\t 0: REFIN1(+)/REFIN1(=E2=88=92).\n" - "> +\t\t\t 1: REFIN2(+)/REFIN2(=E2=88=92).\n" + "> +\t\t\t 0: REFIN1(+)/REFIN1(\342\210\222).\n" + "> +\t\t\t 1: REFIN2(+)/REFIN2(\342\210\222).\n" "> +\t\t\t 3: AVDD\n" "> +\t\t\t If this field is left empty, internal reference is selected.\n" "> +\n" @@ -100,47 +90,47 @@ "> +\n" "> +Example:\n" "> +\tadc@0 {\n" - "> +\t\tcompatible =3D \"adi,ad7124-4\";\n" - "> +\t\treg =3D <0>;\n" - "> +\t\tspi-max-frequency =3D <5000000>;\n" - "> +\t\tinterrupts =3D <25 2>;\n" - "> +\t\tinterrupt-parent =3D <&gpio>;\n" - "> +\t\trefin1-supply =3D <&adc_vref>;\n" - "> +\t\tclocks =3D <&ad7124_mclk>;\n" - "> +\t\tclock-names =3D \"mclk\";\n" + "> +\t\tcompatible = \"adi,ad7124-4\";\n" + "> +\t\treg = <0>;\n" + "> +\t\tspi-max-frequency = <5000000>;\n" + "> +\t\tinterrupts = <25 2>;\n" + "> +\t\tinterrupt-parent = <&gpio>;\n" + "> +\t\trefin1-supply = <&adc_vref>;\n" + "> +\t\tclocks = <&ad7124_mclk>;\n" + "> +\t\tclock-names = \"mclk\";\n" "> +\n" - "> +\t\t#address-cells =3D <1>;\n" - "> +\t\t#size-cells =3D <0>;\n" + "> +\t\t#address-cells = <1>;\n" + "> +\t\t#size-cells = <0>;\n" "> +\n" "> +\t\tchannel@0 {\n" - "> +\t\t\treg =3D <0>;\n" - "> +\t\t\tadi,diff-channels =3D <0 1>;\n" - "> +\t\t\tadi,reference-select =3D <0>;\n" - "> +\t\t\tadi,gain =3D <2>;\n" - "> +\t\t\tadi,odr-hz =3D <10>;\n" + "> +\t\t\treg = <0>;\n" + "> +\t\t\tadi,diff-channels = <0 1>;\n" + "> +\t\t\tadi,reference-select = <0>;\n" + "> +\t\t\tadi,gain = <2>;\n" + "> +\t\t\tadi,odr-hz = <10>;\n" "I think you have dropped these two..\n" "\n" "> +\t\t};\n" "> +\n" "> +\t\tchannel@1 {\n" - "> +\t\t\treg =3D <1>;\n" + "> +\t\t\treg = <1>;\n" "> +\t\t\tadi,bipolar;\n" - "> +\t\t\tadi,diff-channels =3D <2 3>;\n" - "> +\t\t\tadi,reference-select =3D <0>;\n" - "> +\t\t\tadi,gain =3D <4>;\n" - "> +\t\t\tadi,odr-hz =3D <50>;\n" + "> +\t\t\tadi,diff-channels = <2 3>;\n" + "> +\t\t\tadi,reference-select = <0>;\n" + "> +\t\t\tadi,gain = <4>;\n" + "> +\t\t\tadi,odr-hz = <50>;\n" "> +\t\t};\n" "> +\n" "> +\t\tchannel@2 {\n" - "> +\t\t\treg =3D <2>;\n" - "> +\t\t\tadi,diff-channels =3D <4 5>;\n" - "> +\t\t\tadi,gain =3D <128>;\n" - "> +\t\t\tadi,odr-hz =3D <19200>;\n" + "> +\t\t\treg = <2>;\n" + "> +\t\t\tadi,diff-channels = <4 5>;\n" + "> +\t\t\tadi,gain = <128>;\n" + "> +\t\t\tadi,odr-hz = <19200>;\n" "> +\t\t};\n" "> +\n" "> +\t\tchannel@3 {\n" - "> +\t\t\treg =3D <3>;\n" - "> +\t\t\tadi,diff-channels =3D <6 7>;\n" + "> +\t\t\treg = <3>;\n" + "> +\t\t\tadi,diff-channels = <6 7>;\n" "> +\t\t};\n" "> +\t};\n" "> diff --git a/MAINTAINERS b/MAINTAINERS\n" @@ -152,8 +142,8 @@ "> S:\tSupported\n" "> F:\tdrivers/iio/adc/ad7124.c\n" "> +F:\tDocumentation/devicetree/bindings/iio/adc/adi,ad7124.txt\n" - "> =20\n" + "> \n" "> ANALOG DEVICES INC AD9389B DRIVER\n" "> M:\tHans Verkuil <hans.verkuil@cisco.com>" -96663c0e50b089d5e3a0cc0c1887132f3c106a4f9743780194d08b27c34da4e1 +dc46ccaca24a8efd1f3ebd8b91e7b575f756719c9659d9572c9f10d63f3f00dc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.