diff for duplicates of <20181111153405.45ccb948@archlinux> diff --git a/a/1.txt b/N1/1.txt index 4b416e6..6684b5a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,101 +3,94 @@ On Thu, 8 Nov 2018 16:48:02 +0000 > On Jo, 2018-11-08 at 10:34 -0600, Rob Herring wrote: > > On Thu, Nov 8, 2018 at 9:02 AM Popa, Stefan Serban -> > <StefanSerban.Popa@analog.com> wrote: =20 -> > >=20 -> > >=20 -> > > On Sb, 2018-11-03 at 12:16 +0000, Jonathan Cameron wrote: =20 -> > > >=20 +> > <StefanSerban.Popa@analog.com> wrote: +> > > +> > > +> > > On Sb, 2018-11-03 at 12:16 +0000, Jonathan Cameron wrote: +> > > > > > > > On Mon, 29 Oct 2018 18:38:31 +0200 > > > > Stefan Popa <stefan.popa@analog.com> wrote: -> > > > =20 -> > > > >=20 -> > > > >=20 +> > > > +> > > > > +> > > > > > > > > > The ad7124-4 and ad7124-8 are a family of 4 and 8 channel sigma- > > > > > delta > > > > > ADCs > > > > > with 24-bit precision and reference. -> > > > >=20 +> > > > > > > > > > Three power modes are available which in turn affect the output > > > > > data > > > > > rate: -> > > > > =C2=A0* Full power: 9.38 SPS to 19,200 SPS -> > > > > =C2=A0* Mid power: 2.34 SPS to 4800 SPS -> > > > > =C2=A0* Low power: 1.17 SPS to 2400 SPS -> > > > >=20 +> > > > > * Full power: 9.38 SPS to 19,200 SPS +> > > > > * Mid power: 2.34 SPS to 4800 SPS +> > > > > * Low power: 1.17 SPS to 2400 SPS +> > > > > > > > > > The ad7124-4 can be configured to have four differential inputs, > > > > > while > > > > > ad7124-8 can have 8. Moreover, ad7124 also supports per channel > > > > > configuration. Each configuration consists of gain, reference > > > > > source, > > > > > output data rate and bipolar/unipolar configuration. -> > > > >=20 +> > > > > > > > > > Datasheets: -> > > > > Link: http://www.analog.com/media/en/technical-documentation/data= --s +> > > > > Link: http://www.analog.com/media/en/technical-documentation/data-s > > > > > heet > > > > > s/AD7124-4.pdf -> > > > > Link: http://www.analog.com/media/en/technical-documentation/data= --s +> > > > > Link: http://www.analog.com/media/en/technical-documentation/data-s > > > > > heet > > > > > s/ad7124-8.pdf -> > > > >=20 -> > > > > Signed-off-by: Stefan Popa <stefan.popa@analog.com> =20 +> > > > > +> > > > > Signed-off-by: Stefan Popa <stefan.popa@analog.com> > > > > Hi Stefan, -> > > >=20 +> > > > > > > > The discussion around the DT binding has gotten me looking at bit > > > > more closely at that for this version. -> > > >=20 -> > > > Some most comments in that section.=C2=A0=C2=A0Also a really minor = -ordering +> > > > +> > > > Some most comments in that section. Also a really minor ordering > > > > issue > > > > in -> > > > remove which I'd just have fixed if we weren't going around again f= -or +> > > > remove which I'd just have fixed if we weren't going around again for > > > > the binding. -> > > >=20 +> > > > > > > > Main binding thing is I don't think the odr value belongs in DT. > > > > Gain is more marginal (unless the part can actually be damaged by -> > > > a wrong value - which I hope it can't!).=C2=A0=C2=A0I'm not that fu= -ssed +> > > > a wrong value - which I hope it can't!). I'm not that fussed > > > > as there are definitely reasons to specify a default scale to > > > > cover the reasonable range on a pin. -> > > >=20 +> > > > > > > > Thanks, -> > > >=20 -> > > > Jonathan =20 +> > > > +> > > > Jonathan > > > Hi Jonathan, -> > >=20 +> > > > > > Thank you for the review! So, how should I proceed? -> > >=20 +> > > > > > First, we need an adc.txt file where "bipolar" and something like > > > "diff- > > > channels" should be documented. Should the file be placed under -> > > Documentation/devicetree/bindings/iio/adc? =20 +> > > Documentation/devicetree/bindings/iio/adc? > > Yes. -> > =20 -> > >=20 +> > +> > > > > > Regarding the "odr-hz" property, it totally makes sense to remove it > > > from -> > > the DT. How about the "gain"? Should we leave it in the DT and also a= -dd +> > > the DT. How about the "gain"? Should we leave it in the DT and also add > > > the -> > > possibility to be configured from user space? =20 +> > > possibility to be configured from user space? > > Look at other bindings. I think there are others having gain. If not, > > then it probably should only be user space configurable. If so, then > > can it be a common property too. -> >=20 +> > > > Rob -> > =20 ->=20 +> > +> > Hi Rob, ->=20 +> > I found only a couple of examples using gain in other bindings, so I guess > it's not common practice. I will remove the gain as well from the DT and > set it with the default of 1. ->=20 -> @Jonathan: I think that=C2=A0IIO_CHAN_INFO_HARDWAREGAIN is the attribute = -that +> +> @Jonathan: I think that IIO_CHAN_INFO_HARDWAREGAIN is the attribute that > can be used in user space? Sorry, I missed this. Guess you will see my review anyway around now. Nope, hardwaregain is an oddity for devices where we aren't controlling @@ -111,6 +104,6 @@ question so best left to userspace. Jonathan ->=20 +> > Thank you! > -Stefan diff --git a/a/content_digest b/N1/content_digest index 4d0d64e..728c930 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -24,101 +24,94 @@ "\n" "> On Jo, 2018-11-08 at 10:34 -0600, Rob Herring wrote:\n" "> > On Thu, Nov 8, 2018 at 9:02 AM Popa, Stefan Serban\n" - "> > <StefanSerban.Popa@analog.com> wrote: =20\n" - "> > >=20\n" - "> > >=20\n" - "> > > On Sb, 2018-11-03 at 12:16 +0000, Jonathan Cameron wrote: =20\n" - "> > > >=20\n" + "> > <StefanSerban.Popa@analog.com> wrote: \n" + "> > > \n" + "> > > \n" + "> > > On Sb, 2018-11-03 at 12:16 +0000, Jonathan Cameron wrote: \n" + "> > > > \n" "> > > > On Mon, 29 Oct 2018 18:38:31 +0200\n" "> > > > Stefan Popa <stefan.popa@analog.com> wrote:\n" - "> > > > =20\n" - "> > > > >=20\n" - "> > > > >=20\n" + "> > > > \n" + "> > > > > \n" + "> > > > > \n" "> > > > > The ad7124-4 and ad7124-8 are a family of 4 and 8 channel sigma-\n" "> > > > > delta\n" "> > > > > ADCs\n" "> > > > > with 24-bit precision and reference.\n" - "> > > > >=20\n" + "> > > > > \n" "> > > > > Three power modes are available which in turn affect the output\n" "> > > > > data\n" "> > > > > rate:\n" - "> > > > > =C2=A0* Full power: 9.38 SPS to 19,200 SPS\n" - "> > > > > =C2=A0* Mid power: 2.34 SPS to 4800 SPS\n" - "> > > > > =C2=A0* Low power: 1.17 SPS to 2400 SPS\n" - "> > > > >=20\n" + "> > > > > \302\240* Full power: 9.38 SPS to 19,200 SPS\n" + "> > > > > \302\240* Mid power: 2.34 SPS to 4800 SPS\n" + "> > > > > \302\240* Low power: 1.17 SPS to 2400 SPS\n" + "> > > > > \n" "> > > > > The ad7124-4 can be configured to have four differential inputs,\n" "> > > > > while\n" "> > > > > ad7124-8 can have 8. Moreover, ad7124 also supports per channel\n" "> > > > > configuration. Each configuration consists of gain, reference\n" "> > > > > source,\n" "> > > > > output data rate and bipolar/unipolar configuration.\n" - "> > > > >=20\n" + "> > > > > \n" "> > > > > Datasheets:\n" - "> > > > > Link: http://www.analog.com/media/en/technical-documentation/data=\n" - "-s\n" + "> > > > > Link: http://www.analog.com/media/en/technical-documentation/data-s\n" "> > > > > heet\n" "> > > > > s/AD7124-4.pdf\n" - "> > > > > Link: http://www.analog.com/media/en/technical-documentation/data=\n" - "-s\n" + "> > > > > Link: http://www.analog.com/media/en/technical-documentation/data-s\n" "> > > > > heet\n" "> > > > > s/ad7124-8.pdf\n" - "> > > > >=20\n" - "> > > > > Signed-off-by: Stefan Popa <stefan.popa@analog.com> =20\n" + "> > > > > \n" + "> > > > > Signed-off-by: Stefan Popa <stefan.popa@analog.com> \n" "> > > > Hi Stefan,\n" - "> > > >=20\n" + "> > > > \n" "> > > > The discussion around the DT binding has gotten me looking at bit\n" "> > > > more closely at that for this version.\n" - "> > > >=20\n" - "> > > > Some most comments in that section.=C2=A0=C2=A0Also a really minor =\n" - "ordering\n" + "> > > > \n" + "> > > > Some most comments in that section.\302\240\302\240Also a really minor ordering\n" "> > > > issue\n" "> > > > in\n" - "> > > > remove which I'd just have fixed if we weren't going around again f=\n" - "or\n" + "> > > > remove which I'd just have fixed if we weren't going around again for\n" "> > > > the binding.\n" - "> > > >=20\n" + "> > > > \n" "> > > > Main binding thing is I don't think the odr value belongs in DT.\n" "> > > > Gain is more marginal (unless the part can actually be damaged by\n" - "> > > > a wrong value - which I hope it can't!).=C2=A0=C2=A0I'm not that fu=\n" - "ssed\n" + "> > > > a wrong value - which I hope it can't!).\302\240\302\240I'm not that fussed\n" "> > > > as there are definitely reasons to specify a default scale to\n" "> > > > cover the reasonable range on a pin.\n" - "> > > >=20\n" + "> > > > \n" "> > > > Thanks,\n" - "> > > >=20\n" - "> > > > Jonathan =20\n" + "> > > > \n" + "> > > > Jonathan \n" "> > > Hi Jonathan,\n" - "> > >=20\n" + "> > > \n" "> > > Thank you for the review! So, how should I proceed?\n" - "> > >=20\n" + "> > > \n" "> > > First, we need an adc.txt file where \"bipolar\" and something like\n" "> > > \"diff-\n" "> > > channels\" should be documented. Should the file be placed under\n" - "> > > Documentation/devicetree/bindings/iio/adc? =20\n" + "> > > Documentation/devicetree/bindings/iio/adc? \n" "> > Yes.\n" - "> > =20\n" - "> > >=20\n" + "> > \n" + "> > > \n" "> > > Regarding the \"odr-hz\" property, it totally makes sense to remove it\n" "> > > from\n" - "> > > the DT. How about the \"gain\"? Should we leave it in the DT and also a=\n" - "dd\n" + "> > > the DT. How about the \"gain\"? Should we leave it in the DT and also add\n" "> > > the\n" - "> > > possibility to be configured from user space? =20\n" + "> > > possibility to be configured from user space? \n" "> > Look at other bindings. I think there are others having gain. If not,\n" "> > then it probably should only be user space configurable. If so, then\n" "> > can it be a common property too.\n" - "> >=20\n" + "> > \n" "> > Rob\n" - "> > =20\n" - ">=20\n" + "> > \n" + "> \n" "> Hi Rob,\n" - ">=20\n" + "> \n" "> I found only a couple of examples using gain in other bindings, so I guess\n" "> it's not common practice. I will remove the gain as well from the DT and\n" "> set it with the default of 1.\n" - ">=20\n" - "> @Jonathan: I think that=C2=A0IIO_CHAN_INFO_HARDWAREGAIN is the attribute =\n" - "that\n" + "> \n" + "> @Jonathan: I think that\302\240IIO_CHAN_INFO_HARDWAREGAIN is the attribute that\n" "> can be used in user space?\n" "Sorry, I missed this. Guess you will see my review anyway around now.\n" "Nope, hardwaregain is an oddity for devices where we aren't controlling\n" @@ -132,8 +125,8 @@ "\n" "Jonathan\n" "\n" - ">=20\n" + "> \n" "> Thank you!\n" > -Stefan -15bd977aea44eb12634dbed65aaa971a863e50d2d10ff8051a9eaac042500b23 +2e57c35196e73c4a52ccebff9dc9292481fc78860d35b20924907d43aa58402c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.