All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: Junchang Wang <junchangwang@gmail.com>, perfbook@vger.kernel.org
Subject: Re: [PATCH] cpu: Fix typos
Date: Sun, 11 Nov 2018 07:59:53 -0800	[thread overview]
Message-ID: <20181111155953.GR4170@linux.ibm.com> (raw)
In-Reply-To: <52e466f0-b57a-ed04-2ac5-7fb2022e82c7@gmail.com>

On Sun, Nov 11, 2018 at 08:51:33AM +0900, Akira Yokosawa wrote:
> On 2018/11/10 20:49:21 +0800, Junchang Wang wrote:
> > Signed-off-by: Junchang Wang <junchangwang@gmail.com>
> > ---
> > Hi Paul,
> > 
> > This is the only patch for Chapter CPU. Please take a look.
> > 
> > 
> > Thanks,
> > --Junchang
> > 
> > --
> >  cpu/overheads.tex | 4 ++--
> >  cpu/overview.tex  | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/cpu/overheads.tex b/cpu/overheads.tex
> > index 2474cfe..17b120b 100644
> > --- a/cpu/overheads.tex
> > +++ b/cpu/overheads.tex
> > @@ -155,7 +155,7 @@ displayed in
> >  Table~\ref{tab:cpu:Performance of Synchronization Mechanisms on 4-CPU 1.8GHz AMD Opteron 844 System}.
> >  This system's clock period rounds to 0.6\,ns.
> >  Although it is not unusual for modern microprocessors to be able to
> > -retire multiple instructions per clock period, the operations's costs are
> > +retire multiple instructions per clock period, the operations' costs are
> >  nevertheless normalized to a clock period in the third column, labeled
> >  ``Ratio''.
> >  The first thing to note about this table is the large values of many of
> > @@ -360,7 +360,7 @@ It is clear that the combination of speculative execution and cloud
> >  computing needs more than a bit of rework!
> >  
> >  A fifth hardware optimization is large caches, allowing individual
> > -CPUs to operate on larger datasets without incuring expensive cache
> > +CPUs to operate on larger datasets without incurring expensive cache
> >  misses.
> 
> Nice catches!

Indeed!!!  ;-)

> >  Although large caches can degrade energy efficiency and cache-miss
> >  latency, the ever-growing cache sizes on production microprocessors
> > diff --git a/cpu/overview.tex b/cpu/overview.tex
> > index 071cf7c..9e91a7b 100644
> > --- a/cpu/overview.tex
> > +++ b/cpu/overview.tex
> > @@ -15,7 +15,7 @@ where the race always goes to the swiftest.
> >  \ContributedBy{Figure}{fig:cpu:CPU Performance at its Best}{Melissa Broussard}
> >  \end{figure}
> >  
> > -Although there are a few CPU-bound benchmarks that approach the ideal
> > +Although there are a few CPU-bound benchmarks that approach the ideal case
> >  shown in Figure~\ref{fig:cpu:CPU Performance at its Best},
> 
> "ideal" can be used as a noun. I don't think this hunk is necessary.

This is quite true, but making it a bit less confusing to non-native
English speakers is worth something.  Not that I am volunteering to
confine myself to the 850-word vocabulary of Basic English, mind you!  ;-)

So Akira has a good point, but I will take Junchang's patch.

							Thanx, Paul

>         Thanks, Akira
> 
> >  the typical program more closely resembles an obstacle course than
> >  a race track.
> > 
> 


  reply	other threads:[~2018-11-12  1:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-10 12:49 [PATCH] cpu: Fix typos Junchang Wang
2018-11-10 23:51 ` Akira Yokosawa
2018-11-11 15:59   ` Paul E. McKenney [this message]
2018-11-12  2:25     ` Junchang Wang
2018-11-12 18:08       ` Paul E. McKenney
2018-11-11 16:39 ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181111155953.GR4170@linux.ibm.com \
    --to=paulmck@linux.ibm.com \
    --cc=akiyks@gmail.com \
    --cc=junchangwang@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.