From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs: introduce an always_cow mode
Date: Sun, 11 Nov 2018 17:30:01 +0100 [thread overview]
Message-ID: <20181111163001.GA3331@lst.de> (raw)
In-Reply-To: <20181110174752.GA4235@magnolia>
On Sat, Nov 10, 2018 at 09:47:52AM -0800, Darrick J. Wong wrote:
> > xfs_ilock(ip, iolock);
> > + if (xfs_is_always_cow_inode(ip) && mode != FALLOC_FL_PUNCH_HOLE) {
> > + error = -EOPNOTSUPP;
> > + goto out_unlock;
>
> It's the weekend, so I'm only doing a quick scan of patches:
>
> Why can't we support collapse range, insert range, zero range, or
> unshare in always_cow mode?
Yes, this a little agressive. I think we should be fine just
skipping modes zero and keep size (ugg, the fallocate flags
scheme is horrible..). I'll do that for the next version.
next prev parent reply other threads:[~2018-11-12 2:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 11:51 COW improvements and always_cow support Christoph Hellwig
2018-11-10 11:51 ` [PATCH 1/3] xfs: don't use delalloc extents for COW on files with extsize hints Christoph Hellwig
2018-11-10 11:51 ` [PATCH 2/3] xfs: merge COW handling into xfs_file_iomap_begin_delay Christoph Hellwig
2018-11-10 11:51 ` [PATCH 3/3] xfs: introduce an always_cow mode Christoph Hellwig
2018-11-10 17:47 ` Darrick J. Wong
2018-11-11 16:30 ` Christoph Hellwig [this message]
2018-11-12 7:20 ` Christoph Hellwig
2018-11-12 7:26 ` [PATCH 4/3] xfs: make COW fork unwritten extent conversions more robust Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181111163001.GA3331@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.