From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:59876 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727036AbeKLGju (ORCPT <rfc822;stable@vger.kernel.org>);
        Mon, 12 Nov 2018 01:39:50 -0500
Date: Sun, 11 Nov 2018 12:50:13 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: whissi@gentoo.org, stable@vger.kernel.org, dsahern@gmail.com,
        pupilla@libero.it
Subject: Re: stable request: net: sched: Remove TCA_OPTIONS from
 policy,stable request: net: sched: Remove TCA_OPTIONS from policy
Message-ID: <20181111205013.GA5213@kroah.com>
References: <6bead29b-b1d8-1c0b-7ef5-d5e6f1d192f3@gentoo.org>
 <20181110.134003.1813874858920783553.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181110.134003.1813874858920783553.davem@davemloft.net>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Sat, Nov 10, 2018 at 01:40:03PM -0800, David Miller wrote:
> From: Thomas Deutschmann <whissi@gentoo.org>
> Date: Sat, 10 Nov 2018 20:20:01 +0100
> 
> > Hi,
> > 
> > all stable kernels carrying
> > 
> >> From 8b4c3cdd9dd8290343ce959a132d3b334062c5b9 Mon Sep 17 00:00:00 2001
> >> From: David Ahern <dsahern@gmail.com>
> >> Date: Wed, 3 Oct 2018 15:05:36 -0700
> >> Subject: [PATCH] net: sched: Add policy validation for tc attributes
> >> 
> >> A number of TC attributes are processed without proper validation
> >> (e.g., length checks). Add a tca policy for all input attributes and use
> >> when invoking nlmsg_parse.
> >> 
> >> The 2 Fixes tags below cover the latest additions. The other attributes
> >> are a string (KIND), nested attribute (OPTIONS which does seem to have
> >> validation in most cases), for dumps only or a flag.
> >> 
> >> Fixes: 5bc1701881e39 ("net: sched: introduce multichain support for filters")
> >> Fixes: d47a6b0e7c492 ("net: sched: introduce ingress/egress block index attributes for qdisc")
> >> Signed-off-by: David Ahern <dsahern@gmail.com>
> >> Signed-off-by: David S. Miller <davem@davemloft.net>
> > 
> > should backport
> > 
> >> From e72bde6b66299602087c8c2350d36a525e75d06e Mon Sep 17 00:00:00 2001
> >> From: David Ahern <dsahern@gmail.com>
> >> Date: Wed, 24 Oct 2018 08:32:49 -0700
> >> Subject: [PATCH] net: sched: Remove TCA_OPTIONS from policy
> >> 
> >> Marco reported an error with hfsc:
> >> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> >> Error: Attribute failed policy validation.
> >> 
> >> Apparently a few implementations pass TCA_OPTIONS as a binary instead
> >> of nested attribute, so drop TCA_OPTIONS from the policy.
> >> 
> >> Fixes: 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes")
> >> Reported-by: Marco Berizzi <pupilla@libero.it>
> >> Signed-off-by: David Ahern <dsahern@gmail.com>
> >> Signed-off-by: David S. Miller <davem@davemloft.net>
> > 
> > See https://lkml.org/lkml/2018/10/26/80.
> 
> Indeed, -stable folks please add this latter patch on top.

Now queued up, thanks.

greg k-h