From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] acpid: Make bundled event files optional
Date: Sun, 11 Nov 2018 21:50:16 +0100 [thread overview]
Message-ID: <20181111215016.4bb45836@windsurf.home> (raw)
In-Reply-To: <20181111150652.17459-6-alexander.sverdlin@gmail.com>
Hello Alexander,
Adding in Cc: Carlos Santos, who recently tweakedthe powerbtn script
logic.
On Sun, 11 Nov 2018 16:06:51 +0100, Alexander Sverdlin wrote:
> On one hand the preinstalled /etc/acpi/events/powerbtn is not part of
> acpid, one other hand others might want to implement more complicated logic
> on power button. Therefore, make it optional.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
On the other hand, it makes quite a bit of sense to have some kind of
default/minimal behavior for this, which can easily be overridden in a
post-build script / root filesystem overlay.
To me, this is a little bit like "let's make the installation of the
OpenSSH server configuration file optional, because the default doesn't
suite me".
> +if BR2_PACKAGE_ACPID
> +
> +config BR2_PACKAGE_ACPID_SUPPLEMENTARY
If anything, the name of the option should be revisited, because
"supplementary" is quite vague.
But overall, I'm not really convinced that we need to change anything
here, I believe the current behavior is OK.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-11 20:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 15:06 [Buildroot] [PATCH] libtool: Make libltdl a separate package Alexander Sverdlin
2018-11-11 15:06 ` [Buildroot] [PATCH] Add syslinux installer host package Alexander Sverdlin
2018-11-11 20:33 ` Thomas Petazzoni
2018-11-12 0:03 ` Carlos Santos
2018-11-11 15:06 ` [Buildroot] [PATCH] linux-tools: Add liblockdep Alexander Sverdlin
2018-11-11 21:53 ` Thomas Petazzoni
2018-11-11 15:06 ` [Buildroot] [PATCH] Add mini-snmpd package Alexander Sverdlin
2018-11-13 21:52 ` Thomas Petazzoni
2018-11-22 17:55 ` Alexander Sverdlin
2018-11-11 15:06 ` [Buildroot] [PATCH] acpid: Add systemd service Alexander Sverdlin
2018-11-11 20:46 ` Thomas Petazzoni
2018-11-11 15:06 ` [Buildroot] [PATCH] acpid: Make bundled event files optional Alexander Sverdlin
2018-11-11 20:50 ` Thomas Petazzoni [this message]
2018-11-11 23:36 ` Carlos Santos
2018-11-11 15:06 ` [Buildroot] [PATCH] systemd: Explicitly configure split-usr=false and split-bin=true Alexander Sverdlin
2018-11-11 16:34 ` Yann E. MORIN
2018-11-11 20:55 ` Thomas Petazzoni
2018-11-11 23:41 ` Alexander Sverdlin
2018-11-12 8:08 ` Yann E. MORIN
2018-11-13 22:19 ` Alexander Sverdlin
2018-11-11 21:17 ` [Buildroot] [PATCH] libtool: Make libltdl a separate package Thomas Petazzoni
2018-11-11 22:15 ` Arnout Vandecappelle
2018-11-12 8:06 ` Yann E. MORIN
2018-11-22 19:02 ` Alexander Sverdlin
2018-11-23 8:04 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181111215016.4bb45836@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.