All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libmicrohttpd: fix build on riscv
Date: Sun, 11 Nov 2018 22:01:01 +0100	[thread overview]
Message-ID: <20181111220101.02bdfec7@windsurf.home> (raw)
In-Reply-To: <20181110160028.22033-1-fontaine.fabrice@gmail.com>

Hello,

+Mark Corbin in Cc.

On Sat, 10 Nov 2018 17:00:28 +0100, Fabrice Fontaine wrote:
> Define _REENTRANT like already done for ARC otherwise pthread detection
> will fail
> 
> Fixes:
>  - https://autobuild.buildroot.org/results/910dc7164312637bf4dcd89e4cb476ae198466c8
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libmicrohttpd/libmicrohttpd.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Mark: could you report upstream to the RISC-V gcc developers that the
gcc port should define _REENTRANT when -pthread is passed ?

I.E, most platforms do some variations of:

#define SUBTARGET_CPP_SPEC  "%{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"

in their gcc/config/<ARCH>/linux.h file.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-11-11 21:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-10 16:00 [Buildroot] [PATCH 1/1] libmicrohttpd: fix build on riscv Fabrice Fontaine
2018-11-11 21:01 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181111220101.02bdfec7@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.