From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Date: Mon, 12 Nov 2018 09:09:34 +0000 Subject: Re: [PATCH -next] USB: serial: quatech2: remove set but not used variable 'port_priv' Message-Id: <20181112090934.GB13311@localhost> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Oct 11, 2018 at 07:44:33AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': > drivers/usb/serial/quatech2.c:503:27: warning: > variable 'port_priv' set but not used [-Wunused-but-set-variable] > > It not used any more after > commit 2be818a116b2 ("Revert "USB: quatech2: only write to the tty if the port is open."") > > Signed-off-by: YueHaibing Now applied. Thanks for including the not-used-since information. Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] USB: serial: quatech2: remove set but not used variable 'port_priv' From: Johan Hovold Message-Id: <20181112090934.GB13311@localhost> Date: Mon, 12 Nov 2018 10:09:34 +0100 To: YueHaibing Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: T24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMDc6NDQ6MzNBTSArMDAwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiBGaXhlcyBnY2MgJy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUnIHdhcm5pbmc6Cj4gCj4g ZHJpdmVycy91c2Ivc2VyaWFsL3F1YXRlY2gyLmM6IEluIGZ1bmN0aW9uICdxdDJfcHJvY2Vzc19y ZWFkX3VyYic6Cj4gZHJpdmVycy91c2Ivc2VyaWFsL3F1YXRlY2gyLmM6NTAzOjI3OiB3YXJuaW5n Ogo+ICB2YXJpYWJsZSAncG9ydF9wcml2JyBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQt c2V0LXZhcmlhYmxlXQo+IAo+IEl0IG5vdCB1c2VkIGFueSBtb3JlIGFmdGVyCj4gY29tbWl0IDJi ZTgxOGExMTZiMiAoIlJldmVydCAiVVNCOiBxdWF0ZWNoMjogb25seSB3cml0ZSB0byB0aGUgdHR5 IGlmIHRoZSBwb3J0IGlzIG9wZW4uIiIpCj4gCj4gU2lnbmVkLW9mZi1ieTogWXVlSGFpYmluZyA8 eXVlaGFpYmluZ0BodWF3ZWkuY29tPgoKTm93IGFwcGxpZWQuIFRoYW5rcyBmb3IgaW5jbHVkaW5n IHRoZSBub3QtdXNlZC1zaW5jZSBpbmZvcm1hdGlvbi4KCkpvaGFuCg==