diff for duplicates of <20181112093855.GC17399@in.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 6f9ba91..fd6bbe4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -58,7 +58,7 @@ On Tue, Oct 30, 2018 at 04:26:46PM +1100, Paul Mackerras wrote: > > + hmm_hash = kvm->arch.hmm_hash; > > + list = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)]; > > + hlist_for_each_entry(p, list, hlist) { -> > + if (p->addr = gpa) { +> > + if (p->addr == gpa) { > > + hmm_page = pfn_to_page(p->hmm_pfn); > > + get_page(hmm_page); /* TODO: Necessary ? */ > > + pvt = (struct kvmppc_hmm_page_pvt *) @@ -72,7 +72,7 @@ On Tue, Oct 30, 2018 at 04:26:46PM +1100, Paul Mackerras wrote: > > + > > + ret = get_user_pages_fast(addr, 1, 0, &page); > -> Why are we calling this with write=0? Surely in general the secure +> Why are we calling this with write==0? Surely in general the secure > guest will expect to be able to write to the shared page? > > Also, in general get_user_pages_fast isn't sufficient to translate a diff --git a/a/content_digest b/N1/content_digest index f5d81bf..824b099 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,16 +3,16 @@ "ref\020181030052646.GB11072@blackberry\0" "From\0Bharata B Rao <bharata@linux.ibm.com>\0" "Subject\0Re: [RFC PATCH v1 2/4] kvmppc: Add support for shared pages in HMM driver\0" - "Date\0Mon, 12 Nov 2018 09:50:55 +0000\0" + "Date\0Mon, 12 Nov 2018 15:08:55 +0530\0" "To\0Paul Mackerras <paulus@ozlabs.org>\0" - "Cc\0linuxppc-dev@lists.ozlabs.org" + "Cc\0linuxram@us.ibm.com" kvm-ppc@vger.kernel.org - linux-mm@kvack.org - paulus@au1.ibm.com benh@linux.ibm.com - aneesh.kumar@linux.vnet.ibm.com + linux-mm@kvack.org jglisse@redhat.com - " linuxram@us.ibm.com\0" + aneesh.kumar@linux.vnet.ibm.com + paulus@au1.ibm.com + " linuxppc-dev@lists.ozlabs.org\0" "\00:1\0" "b\0" "On Tue, Oct 30, 2018 at 04:26:46PM +1100, Paul Mackerras wrote:\n" @@ -75,7 +75,7 @@ "> > +\thmm_hash = kvm->arch.hmm_hash;\n" "> > +\tlist = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)];\n" "> > +\thlist_for_each_entry(p, list, hlist) {\n" - "> > +\t\tif (p->addr = gpa) {\n" + "> > +\t\tif (p->addr == gpa) {\n" "> > +\t\t\thmm_page = pfn_to_page(p->hmm_pfn);\n" "> > +\t\t\tget_page(hmm_page); /* TODO: Necessary ? */\n" "> > +\t\t\tpvt = (struct kvmppc_hmm_page_pvt *)\n" @@ -89,7 +89,7 @@ "> > +\n" "> > +\tret = get_user_pages_fast(addr, 1, 0, &page);\n" "> \n" - "> Why are we calling this with write=0? Surely in general the secure\n" + "> Why are we calling this with write==0? Surely in general the secure\n" "> guest will expect to be able to write to the shared page?\n" "> \n" "> Also, in general get_user_pages_fast isn't sufficient to translate a\n" @@ -120,4 +120,4 @@ "Regards,\n" Bharata. -f46ff080debf74a93147f42c5e7e68b1b330477af3e0c185e745a48afe4524b6 +3d1af83093ac5629007605173e286f40dd92a5c3088abd7878b06fd6dc8c5333
diff --git a/a/1.txt b/N2/1.txt index 6f9ba91..fd6bbe4 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -58,7 +58,7 @@ On Tue, Oct 30, 2018 at 04:26:46PM +1100, Paul Mackerras wrote: > > + hmm_hash = kvm->arch.hmm_hash; > > + list = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)]; > > + hlist_for_each_entry(p, list, hlist) { -> > + if (p->addr = gpa) { +> > + if (p->addr == gpa) { > > + hmm_page = pfn_to_page(p->hmm_pfn); > > + get_page(hmm_page); /* TODO: Necessary ? */ > > + pvt = (struct kvmppc_hmm_page_pvt *) @@ -72,7 +72,7 @@ On Tue, Oct 30, 2018 at 04:26:46PM +1100, Paul Mackerras wrote: > > + > > + ret = get_user_pages_fast(addr, 1, 0, &page); > -> Why are we calling this with write=0? Surely in general the secure +> Why are we calling this with write==0? Surely in general the secure > guest will expect to be able to write to the shared page? > > Also, in general get_user_pages_fast isn't sufficient to translate a diff --git a/a/content_digest b/N2/content_digest index f5d81bf..9fedad5 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\020181030052646.GB11072@blackberry\0" "From\0Bharata B Rao <bharata@linux.ibm.com>\0" "Subject\0Re: [RFC PATCH v1 2/4] kvmppc: Add support for shared pages in HMM driver\0" - "Date\0Mon, 12 Nov 2018 09:50:55 +0000\0" + "Date\0Mon, 12 Nov 2018 15:08:55 +0530\0" "To\0Paul Mackerras <paulus@ozlabs.org>\0" "Cc\0linuxppc-dev@lists.ozlabs.org" kvm-ppc@vger.kernel.org @@ -75,7 +75,7 @@ "> > +\thmm_hash = kvm->arch.hmm_hash;\n" "> > +\tlist = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)];\n" "> > +\thlist_for_each_entry(p, list, hlist) {\n" - "> > +\t\tif (p->addr = gpa) {\n" + "> > +\t\tif (p->addr == gpa) {\n" "> > +\t\t\thmm_page = pfn_to_page(p->hmm_pfn);\n" "> > +\t\t\tget_page(hmm_page); /* TODO: Necessary ? */\n" "> > +\t\t\tpvt = (struct kvmppc_hmm_page_pvt *)\n" @@ -89,7 +89,7 @@ "> > +\n" "> > +\tret = get_user_pages_fast(addr, 1, 0, &page);\n" "> \n" - "> Why are we calling this with write=0? Surely in general the secure\n" + "> Why are we calling this with write==0? Surely in general the secure\n" "> guest will expect to be able to write to the shared page?\n" "> \n" "> Also, in general get_user_pages_fast isn't sufficient to translate a\n" @@ -120,4 +120,4 @@ "Regards,\n" Bharata. -f46ff080debf74a93147f42c5e7e68b1b330477af3e0c185e745a48afe4524b6 +154b8b00cd2513e45d084f946aa688acc10bc2c3b267d75b934fbff739419847
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.