All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Radu Pirea <radu.pirea@microchip.com>, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH] mfd: at91-usart: Add platform dependency
Date: Mon, 12 Nov 2018 10:49:42 +0100	[thread overview]
Message-ID: <20181112104942.765456f7@endymion> (raw)

It doesn't make sense to present option MFD_AT91_USART by default if
not building an AT91 kernel, as the drivers which depend on it are
not available.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
Cc: Radu Pirea <radu.pirea@microchip.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
As a side note, maybe it would make sense to have SPI_AT91_USART
select MFD_AT91_USART instead of depend on it, so that
MFD_AT91_USART could be hidden?

 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-4.20-rc2.orig/drivers/mfd/Kconfig	2018-11-12 09:34:20.096038788 +0100
+++ linux-4.20-rc2/drivers/mfd/Kconfig	2018-11-12 10:39:51.102170181 +0100
@@ -102,6 +102,7 @@ config MFD_AAT2870_CORE
 config MFD_AT91_USART
 	tristate "AT91 USART Driver"
 	select MFD_CORE
+	depends on ARCH_AT91 || COMPILE_TEST
 	help
 	  Select this to get support for AT91 USART IP. This is a wrapper
 	  over at91-usart-serial driver and usart-spi-driver. Only one function


-- 
Jean Delvare
SUSE L3 Support

             reply	other threads:[~2018-11-12  9:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12  9:49 Jean Delvare [this message]
2018-11-13  8:04 ` [PATCH] mfd: at91-usart: Add platform dependency Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181112104942.765456f7@endymion \
    --to=jdelvare@suse.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=radu.pirea@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.