All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/3] drm/i915: Use proper bool bitfield initializer in power well descs
Date: Mon, 12 Nov 2018 19:12:31 +0200	[thread overview]
Message-ID: <20181112171231.GQ9144@intel.com> (raw)
In-Reply-To: <20181109145822.15446-2-imre.deak@intel.com>

On Fri, Nov 09, 2018 at 04:58:21PM +0200, Imre Deak wrote:
> We can just use a proper true/false initializer even for bitfields,
> which is more descriptive.
> 
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 9c49b876055d..44a77de439f2 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -2098,7 +2098,7 @@ static const struct i915_power_well_ops chv_dpio_cmn_power_well_ops = {
>  static const struct i915_power_well_desc i9xx_always_on_power_well[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2115,7 +2115,7 @@ static const struct i915_power_well_ops i830_pipes_power_well_ops = {
>  static const struct i915_power_well_desc i830_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2159,7 +2159,7 @@ static const struct i915_power_well_regs hsw_power_well_regs = {
>  static const struct i915_power_well_desc hsw_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2180,7 +2180,7 @@ static const struct i915_power_well_desc hsw_power_wells[] = {
>  static const struct i915_power_well_desc bdw_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2223,7 +2223,7 @@ static const struct i915_power_well_ops vlv_dpio_power_well_ops = {
>  static const struct i915_power_well_desc vlv_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2299,7 +2299,7 @@ static const struct i915_power_well_desc vlv_power_wells[] = {
>  static const struct i915_power_well_desc chv_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2350,7 +2350,7 @@ bool intel_display_power_well_is_enabled(struct drm_i915_private *dev_priv,
>  static const struct i915_power_well_desc skl_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2442,7 +2442,7 @@ static const struct i915_power_well_desc skl_power_wells[] = {
>  static const struct i915_power_well_desc bxt_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2500,7 +2500,7 @@ static const struct i915_power_well_desc bxt_power_wells[] = {
>  static const struct i915_power_well_desc glk_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2628,7 +2628,7 @@ static const struct i915_power_well_desc glk_power_wells[] = {
>  static const struct i915_power_well_desc cnl_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> @@ -2795,7 +2795,7 @@ static const struct i915_power_well_regs icl_ddi_power_well_regs = {
>  static const struct i915_power_well_desc icl_power_wells[] = {
>  	{
>  		.name = "always-on",
> -		.always_on = 1,
> +		.always_on = true,
>  		.domains = POWER_DOMAIN_MASK,
>  		.ops = &i9xx_always_on_power_well_ops,
>  		.id = DISP_PW_ID_NONE,
> -- 
> 2.13.2

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-11-12 17:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 14:58 [PATCH 1/3] drm/i915/gen9_bc: Work around DMC bug zeroing power well requests Imre Deak
2018-11-09 14:58 ` [PATCH 2/3] drm/i915: Use proper bool bitfield initializer in power well descs Imre Deak
2018-11-12 17:12   ` Ville Syrjälä [this message]
2018-11-09 14:58 ` [PATCH 3/3] drm/i915: Remove special case for power well 1/MISC_IO state verification Imre Deak
2018-11-12 17:19   ` Ville Syrjälä
2018-11-14 11:43     ` Imre Deak
2018-11-09 15:04 ` [PATCH 1/3] drm/i915/gen9_bc: Work around DMC bug zeroing power well requests Ville Syrjälä
2018-11-09 17:48   ` Imre Deak
2018-11-09 17:18 ` ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
2018-11-10  0:57 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-14 11:55   ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181112171231.GQ9144@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.