From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm/i915: Remove special case for power well 1/MISC_IO state verification Date: Mon, 12 Nov 2018 19:19:44 +0200 Message-ID: <20181112171944.GR9144@intel.com> References: <20181109145822.15446-1-imre.deak@intel.com> <20181109145822.15446-3-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 152BF6E0BC for ; Mon, 12 Nov 2018 17:19:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181109145822.15446-3-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMDksIDIwMTggYXQgMDQ6NTg6MjJQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEV2ZW4gdGhvdWdoIFBXIzEgYW5kIHRoZSBNSVNDX0lPIHBvd2VyIHdlbGxzIGFyZSBtYW5h Z2VkIGJ5IHRoZQo+IERNQyBmaXJtd2FyZSAodG9nZ2xlZCBkeW5hbWljYWxseSBpZiBjb25kaXRp b25zIGFsbG93IGl0KSBmcm9tIHRoZQo+IGRyaXZlcidzIFBPViB0aGV5IGFyZSBhbHdheXMgb24g aWYgdGhlIGRpc3BsYXkgY29yZSBpcyBpbml0aWFsaXplZAo+IChhbHdheXMgcmVzdG9yZWQgYnkg RE1DIHRvIHRoZSBlbmFibGVkIHN0YXRlIGFmdGVyIGV4aXRpbmcgZnJvbSBEQzUvNgo+IGZvciBp bnN0YW5jZSBiL2Mgb2YgTU1JTyBhY2Nlc3MpLiBBY2NvcmRpbmdseSB3ZSBjYW4ganVzdCBtYXJr IHRoZW0gYXMKPiBhbHdheXMtb24gYW5kIHJlbW92ZSB0aGUgc3BlY2lhbCBjYXNpbmcgZm9yIHRo ZW0gZHVyaW5nIHN0YXRlCj4gdmVyaWZpY2F0aW9uICh0aHVzIGVuYWJsaW5nIHZlcmlmaWNhdGlv biBmb3IgdGhlc2UgcG93ZXIgd2VsbHMgdG9vKS4KPiAKPiBDYzogUmFtYWxpbmdhbSBDIDxyYW1h bGluZ2FtLmNAaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZm d2xsLmNoPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIHwgMTUgKysrKysr Ky0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVf cG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+IGluZGV4IDQ0 YTc3ZGU0MzlmMi4uNmIxNTc2YWU3NzhmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3J1bnRpbWVfcG0uYwo+IEBAIC0yMzU4LDYgKzIzNTgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IGk5MTVfcG93ZXJfd2VsbF9kZXNjIHNrbF9wb3dlcl93ZWxsc1tdID0gewo+ICAJewo+ICAJCS5u YW1lID0gInBvd2VyIHdlbGwgMSIsCj4gIAkJLyogSGFuZGxlZCBieSB0aGUgRE1DIGZpcm13YXJl ICovCj4gKwkJLmFsd2F5c19vbiA9IHRydWUsCj4gIAkJLmRvbWFpbnMgPSAwLAoKRmlyc3QgSSB3 YXMgd29uZGVyaW5nIGlmIHRoaXMgc29tZWhvdyBjaGFuZ2VzIHRoZSBiZWhhdmlvdXIgb2YKX19p bnRlbF9kaXNwbGF5X3Bvd2VyX2lzX2VuYWJsZWQoKSwgYnV0IGl0IHdvbid0IHNpbmNlIGFsbCB0 aGVzZQp3ZWxscyBoYXZlIGRvbWFpbnM9PTAgYW5kIHNvIHdvdWxkIGJlIHNraXBwZWQgdGhlcmUg YW55d2F5LgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cgo+ICAJCS5vcHMgPSAmaHN3X3Bvd2VyX3dlbGxfb3BzLAo+ICAJCS5pZCA9 IFNLTF9ESVNQX1BXXzEsCj4gQEAgLTIzNzAsNiArMjM3MSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgaTkxNV9wb3dlcl93ZWxsX2Rlc2Mgc2tsX3Bvd2VyX3dlbGxzW10gPSB7Cj4gIAl7Cj4gIAkJ Lm5hbWUgPSAiTUlTQyBJTyBwb3dlciB3ZWxsIiwKPiAgCQkvKiBIYW5kbGVkIGJ5IHRoZSBETUMg ZmlybXdhcmUgKi8KPiArCQkuYWx3YXlzX29uID0gdHJ1ZSwKPiAgCQkuZG9tYWlucyA9IDAsCj4g IAkJLm9wcyA9ICZoc3dfcG93ZXJfd2VsbF9vcHMsCj4gIAkJLmlkID0gU0tMX0RJU1BfUFdfTUlT Q19JTywKPiBAQCAtMjQ0OSw2ICsyNDUxLDggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBpOTE1X3Bv d2VyX3dlbGxfZGVzYyBieHRfcG93ZXJfd2VsbHNbXSA9IHsKPiAgCX0sCj4gIAl7Cj4gIAkJLm5h bWUgPSAicG93ZXIgd2VsbCAxIiwKPiArCQkvKiBIYW5kbGVkIGJ5IHRoZSBETUMgZmlybXdhcmUg Ki8KPiArCQkuYWx3YXlzX29uID0gdHJ1ZSwKPiAgCQkuZG9tYWlucyA9IDAsCj4gIAkJLm9wcyA9 ICZoc3dfcG93ZXJfd2VsbF9vcHMsCj4gIAkJLmlkID0gU0tMX0RJU1BfUFdfMSwKPiBAQCAtMjUw OCw2ICsyNTEyLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBpOTE1X3Bvd2VyX3dlbGxfZGVzYyBn bGtfcG93ZXJfd2VsbHNbXSA9IHsKPiAgCXsKPiAgCQkubmFtZSA9ICJwb3dlciB3ZWxsIDEiLAo+ ICAJCS8qIEhhbmRsZWQgYnkgdGhlIERNQyBmaXJtd2FyZSAqLwo+ICsJCS5hbHdheXNfb24gPSB0 cnVlLAo+ICAJCS5kb21haW5zID0gMCwKPiAgCQkub3BzID0gJmhzd19wb3dlcl93ZWxsX29wcywK PiAgCQkuaWQgPSBTS0xfRElTUF9QV18xLAo+IEBAIC0yNjM2LDYgKzI2NDEsNyBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IGk5MTVfcG93ZXJfd2VsbF9kZXNjIGNubF9wb3dlcl93ZWxsc1tdID0gewo+ ICAJewo+ICAJCS5uYW1lID0gInBvd2VyIHdlbGwgMSIsCj4gIAkJLyogSGFuZGxlZCBieSB0aGUg RE1DIGZpcm13YXJlICovCj4gKwkJLmFsd2F5c19vbiA9IHRydWUsCj4gIAkJLmRvbWFpbnMgPSAw LAo+ICAJCS5vcHMgPSAmaHN3X3Bvd2VyX3dlbGxfb3BzLAo+ICAJCS5pZCA9IFNLTF9ESVNQX1BX XzEsCj4gQEAgLTI4MDMsNiArMjgwOSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaTkxNV9wb3dl cl93ZWxsX2Rlc2MgaWNsX3Bvd2VyX3dlbGxzW10gPSB7Cj4gIAl7Cj4gIAkJLm5hbWUgPSAicG93 ZXIgd2VsbCAxIiwKPiAgCQkvKiBIYW5kbGVkIGJ5IHRoZSBETUMgZmlybXdhcmUgKi8KPiArCQku YWx3YXlzX29uID0gdHJ1ZSwKPiAgCQkuZG9tYWlucyA9IDAsCj4gIAkJLm9wcyA9ICZoc3dfcG93 ZXJfd2VsbF9vcHMsCj4gIAkJLmlkID0gU0tMX0RJU1BfUFdfMSwKPiBAQCAtMzkzNiwxNCArMzk0 Myw2IEBAIHN0YXRpYyB2b2lkIGludGVsX3Bvd2VyX2RvbWFpbnNfdmVyaWZ5X3N0YXRlKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlpbnQgZG9tYWluc19jb3VudDsKPiAg CQlib29sIGVuYWJsZWQ7Cj4gIAo+IC0JCS8qCj4gLQkJICogUG93ZXIgd2VsbHMgbm90IGJlbG9u Z2luZyB0byBhbnkgZG9tYWluIChsaWtlIHRoZSBNSVNDX0lPCj4gLQkJICogYW5kIFBXMSBwb3dl ciB3ZWxscykgYXJlIHVuZGVyIEZXIGNvbnRyb2wsIHNvIGlnbm9yZSB0aGVtLAo+IC0JCSAqIHNp bmNlIHRoZWlyIHN0YXRlIGNhbiBjaGFuZ2UgYXN5bmNocm9ub3VzbHkuCj4gLQkJICovCj4gLQkJ aWYgKCFwb3dlcl93ZWxsLT5kZXNjLT5kb21haW5zKQo+IC0JCQljb250aW51ZTsKPiAtCj4gIAkJ ZW5hYmxlZCA9IHBvd2VyX3dlbGwtPmRlc2MtPm9wcy0+aXNfZW5hYmxlZChkZXZfcHJpdiwKPiAg CQkJCQkJCSAgICBwb3dlcl93ZWxsKTsKPiAgCQlpZiAoKHBvd2VyX3dlbGwtPmNvdW50IHx8IHBv d2VyX3dlbGwtPmRlc2MtPmFsd2F5c19vbikgIT0KPiAtLSAKPiAyLjEzLjIKCi0tIApWaWxsZSBT eXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==