Re: [RFC 1/7] drm/i915: Remove has_pooled_eu static initializer

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Nov 12, 2018 at 05:12:36PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> It is only initialized to zero once so does not need an explicit
> initializer.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 4ccab8372dd4..e6e7fcdf0ab7 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -507,7 +507,6 @@ static const struct intel_device_info intel_skylake_gt4_info = {
>  	.has_fbc = 1, \
>  	.has_psr = 1, \
>  	.has_runtime_pm = 1, \
> -	.has_pooled_eu = 0, \
>  	.has_csr = 1, \
>  	.has_rc6 = 1, \
>  	.has_dp_mst = 1, \

I'm always a bit wary with the way we inherit these macros. But this
one looks safe since it's only ever unitialized at runtime, and also
this macro (GEN9_LP_FEATURES despite what diff says) doesn't currently
inherit anything.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

PS. I wonder if there any magic trick we could do to make these
    diffs actually legible?  

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx