From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Date: Mon, 12 Nov 2018 20:53:09 +0200
Subject: [U-Boot] [PATCH] qemu-arm: Enable VirtIO distro target
In-Reply-To: <1542016748-15974-1-git-send-email-sumit.garg@linaro.org>
References: <1542016748-15974-1-git-send-email-sumit.garg@linaro.org>
Message-ID: <20181112205309.0f9ad2ff@thinkpad>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Sumit,

On Mon, 12 Nov 2018 15:29:08 +0530
Sumit Garg <sumit.garg@linaro.org> wrote:

> With -device virtio-blk-device,drive=hd0, it could detect distro boot
> target.
> 
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
...
> diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h
> index fedc466..437c3ae 100644
> --- a/include/configs/qemu-arm.h
> +++ b/include/configs/qemu-arm.h
> @@ -25,7 +25,8 @@
>  
>  #define BOOT_TARGET_DEVICES(func) \
>  	func(SCSI, scsi, 0) \
> -	func(DHCP, dhcp, na)
> +	func(DHCP, dhcp, na) \
> +	func(VIRTIO, virtio, 0)
>  
>  #include <config_distro_bootcmd.h>
>  

I think typically DHCP is the very last boot option since it can take
quite long to notice if there's no DHCP server on the network and fall
back to the next option. So perhaps an order of

SCSI; VIRTIO; DHCP

would be better.

Other than that, looks fine to me.

- Tuomas