Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Nov 13, 2018 at 10:39:57AM +0100, Markus Armbruster wrote:
> Drive-by comment...
> 
> Cleber Rosa <crosa@redhat.com> writes:
> 
> [...]
> > My impression is that the "infrastructure for block tests" is not that
> > different from the infrastructure needed by other tests, specially other
> > QEMU tests.
> [...]
> 
> Yes.  The actual reason for having a completely separate testing
> infrastructure for block tests is that it predates testing
> infrastructure for anything else.
> 
> Moving the tests to common infrastructure would be a sizable one-time
> effort we can ill afford.  Maintaining multiple testing infrastructures
> is an ongoing effort we can also ill afford.

If we do want to move to a common infrastructure, then IMHO this patch
series should do the work to convert qemu-iotests to use it.

Currently this is simply introducing a 2nd way to write block tests.

We know from bitter experiance that when we introduce a new system in
QEMU without converting the old system, the old system will live forever
increasing our maint burden & creatnig confusion for developers about
which is the preferred approach.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|