From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v6.1 05/11] libxl_qmp: Implementation of libxl__ev_qmp_* Date: Tue, 13 Nov 2018 15:42:55 +0000 Message-ID: <20181113154254.GJ1302@perard.uk.xensource.com> References: <20181113122844.17908-1-anthony.perard@citrix.com> <23530.52790.262983.714138@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gMaqK-0000Op-Cg for xen-devel@lists.xenproject.org; Tue, 13 Nov 2018 15:43:08 +0000 Content-Disposition: inline In-Reply-To: <23530.52790.262983.714138@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Ian Jackson Cc: 23530.46744.511314.551654@mariner.uk.xensource.com, xen-devel@lists.xenproject.org, Wei Liu List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBOb3YgMTMsIDIwMTggYXQgMDE6MTQ6MzBQTSArMDAwMCwgSWFuIEphY2tzb24gd3Jv dGU6Cj4gQW50aG9ueSBQRVJBUkQgd3JpdGVzICgiW1BBVENIIHY2LjEgMDUvMTFdIGxpYnhsX3Ft cDogSW1wbGVtZW50YXRpb24gb2YgbGlieGxfX2V2X3FtcF8qIik6Cj4gLi4uCj4gCj4gSSB0aGlu ayB0aGlzIHdhcyBpbnRlbmRlZCB0byBzYXRpc2Z5IG15IHJlcXVlc3QgZm9yIGNvbW1lbnRzIGFi b3V0Cj4gbGVnYWwgc3RhdGVzOgo+IAo+ID4gKy8qIGhlbHBlcnMgKi8KPiA+ICsKPiA+ICtzdGF0 aWMgdm9pZCBxbXBfZXZfZW5zdXJlX3JlYWRpbmdfd3JpdGluZyhsaWJ4bF9fZ2MgKmdjLCBsaWJ4 bF9fZXZfcW1wICpldikKPiA+ICt7Cj4gPiArICAgIGJvb2wgZW5hYmxlID0gZmFsc2U7Cj4gCj4g VGhpcyBvbmUgaXMgcHJvYmFibHkgYW4gYXNpc3N0YW50IGZvciB0cmFuc2l0aW9uaW5nIGJldHdl ZW4gc3RhdGVzIHNvCj4gdGhlIHByZS0gYW5kIHBvc3QtY29uZGl0aW9ucyBtYXkgbm90IGJlIHB1 cmUuICBXaGF0ZXZlciBpdCBpcyBzaG91bGQKPiBiZSBkb2N1bWVudGVkLi4uCgpJdCdzIGhhcmQg dG8gZG9jdW1lbnQgdGhlIHN0YXRlIHRyYW5zaXRpb24gb2YgYSBmdW5jdGlvbiB0aGF0IGRvZXNu J3QKY2FyZSBvZiB0aGUgY3VycmVudCBzdGF0ZSB3aGVuIHRoZSBmdW5jdGlvbiBpcyBjYWxsZWQs IGFuZCB3aWxsIGF0dGVtcHQKdG8gZmlndXJlIG91dCB0aGUgY3VycmVudCBzdGF0ZSB0byBmaW5k IG91dCBpZiBhIGZ1bmN0aW9uIGB3cml0YWJsZWAKbmVlZHMgdG8gYmUgY2FsbGVkIGxhdGVyLgoK QnV0IG5vdyBJIHJlYWxpc2UgdGhhdCBgZGlzY29ubmVjdGVkYCB3b3VsZCBiZSBhbiBpbGxpZ2Fs IHN0YXRlLgoKV2hhdCBhYm91dDoKCiAgUHJlY29uZGl0aW9uOiAhZGlzY29ubmVjdGVkCiAgZW5z dXJlIHRoYXQgcW1wX2V2X2NhbGxiYWNrX3dyaXRhYmxlIGlzIGJlZW4gY2FsbGVkIHdoZW4gbmVl ZGVkCgo+ID4gK3N0YXRpYyB2b2lkIHFtcF9ldl9zZXRfc3RhdGUobGlieGxfX2djICpnYywgbGli eGxfX2V2X3FtcCAqZXYsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9f cW1wX3N0YXRlIG5ld19zdGF0ZSkKPiA+ICt7Cj4gCj4gVGhpcyBvbmUgYXQgbGVhc3QgZG9lcyBu b3QgbmVlZCBhIGNvbW1lbnQgOi0pLgo+IAo+ID4gK3N0YXRpYyBpbnQgcW1wX2V2X3ByZXBhcmVf Y21kKGxpYnhsX19nYyAqZ2MsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGli eGxfX2V2X3FtcCAqZXYsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg Y2hhciAqY21kLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhs X19qc29uX29iamVjdCAqYXJncykKPiA+ICt7Cj4gPiArICAgIGNoYXIgKmJ1ZiA9IE5VTEw7Cj4g Cj4gTWlzc2luZyBzdGF0ZSBjb21tZW50LgoKTWF5YmU6CgogIFByZWNvbmRpdGlvbjogY29ubmVj dGluZy9jb25uZWN0ZWQKCj4gPiArc3RhdGljIHZvaWQgcW1wX2V2X2ZkX2NhbGxiYWNrKGxpYnhs X19lZ2MgKmVnYywgbGlieGxfX2V2X2ZkICpldl9mZCwKPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaW50IGZkLCBzaG9ydCBldmVudHMsIHNob3J0IHJldmVudHMpCj4gPiArewo+ IAo+IE1pc3Npbmcgc3RhdGUgY29tbWVudCwgYWx0aG91Z2ggSSB0aGluayB0aGUgcHJlY29uZGl0 aW9uIGNhbiBiZSBlYXNpbHkKPiBpbmZlcnJlZCBmcm9tIHRoZSBzdGF0ZSBvZiBldl9mZCBhbmQg dGhlIHBvc3Rjb25kaXRpb24gdmFyaWVzLCBidXQKPiB3b3VsZCBzdGlsbCBiZSBuaWNlIHRvIGRp c2N1c3MgaXQuCgpUaGlzIGZ1bmN0aW9uIGlzIHRoZSBtYWluIGxvb3AgZnVuY3Rpb24sIHNvIGFs bW9zdCBldmVyeXRoaW5nIGhhcHBlbiBpbgp0aGlzIGZ1bmN0aW9uLiBJdCBzaG91bGQgbm90IGJl IGNhbGxlZCBkaXJlY3RseS4gU28gSSdtIG5vdCBzdXJlIHdoYXQKa2luZCBvZiBjb21tZW50IHdv dWxkIGJlIHVzZWZ1bGwgaGVyZS4KCk1heWJlOgogIFByZWNvbmRpdGlvbnM6CiAgICBgZXZfZmRg IGlzIEFjdGl2ZQogICAgdGhpcyBtZWFucyB0aGF0IGBldmAgaXNuJ3QgZGlzY29ubmVjdGVkCiAg QW55IGFsbG93ZWQgaW50ZXJuYWwgc3RhdGUgdHJhbnNpdGlvbiBjYW4gaGFwcGVuLgogIEEgdXNl ciBjYWxsYmFjayBtYXkgYmUgY2FsbGVkLCB3aGVuIHRoYXQgaGFwcGVuLCB0aGUgZnVuY3Rpb24g c2hvdWxkCiAgcmV0dXJuLgoKPiA+ICtzdGF0aWMgaW50IHFtcF9ldl9jYWxsYmFja193cml0YWJs ZShsaWJ4bF9fZ2MgKmdjLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGxpYnhsX19ldl9xbXAgKmV2LCBpbnQgZmQpCj4gPiArICAgIC8qIGNvbm5lY3RlZCAtPiB3YWl0 aW5nX3JlcGx5Cj4gPiArICAgICAqIHRoZSBzdGF0ZSBpc24ndCBjaGFuZ2Ugb3RoZXJ3aXNlLiAq Lwo+ID4gK3sKPiAKPiBJIGRvbid0IGtub3cgd2hhdCBgb3RoZXJ3aXNlJyBtZWFucy4gIE1heWJl IHlvdSBtZWFuIGFsbCBvdGhlciBzdGF0ZXMKPiBhcmUgbGVnYWwgYW5kIHJlbWFpbiB1bmNoYW5n ZWQgPyAgQnV0IHRoYXQgZG9lcyBub3Qgc2VlbSB0byBiZQo+IGxpa2VseS4gIFByZXN1bWFibHkg ZGlzY29ubmVjdGVkIGlzIHJ1bGVkIG91dCwgYXQgbGVhc3QuCgpJZiBmb3Igc29tZSByYW5kb20g cmVhc29uIHRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIHdpdGggdGhlIHN0YXRlCmRpc2Nvbm5lY3Rl ZCwgaXQgd291bGQganVzdCByZXR1cm4uIFVubGVzcyB0aGUgc3RhdGUgaXMgZGlzY29ubmVjdGlu ZwphbmQgdHhfYnVmIGhhdmVuJ3QgYmVlbiBjbGVhcmVkIHlldC4KCmBPdGhlcndpc2VgIHdvdWxk IGJlIHRoZSBgb3RoZXJ3aXNlYCBvZiBoYXNrZWxsLCBvciB0aGUgYGRlZmF1bHRgIG9mIGEKc3dp dGNoIGNhc2UgaW4gQy4KClNvIGEgZGlmZmVyZW50IGNvbW1lbnQgY291bGQgYmU6CiAgUHJlY29u ZGl0aW9uOgogICAgIWRpc2Nvbm5lY3RlZAogIFN0YXRlIHRyYW5zaXRpb24KICAgIGNvbm5lY3Rl ZCAtPiB3YWl0aW5nX3JlcGx5CiAgICAqIC0+IHN0YXRlIHVuY2hhbmdlCiAgICBvbiBlcnJvcjog ZGlzY29ubmVjdGVkCiAgVGhlIHN0YXRlIG9mIHRoZSB0cmFuc21pdGluZyBidWZmZXIgd2lsbCBi ZSBjaGFuZ2VkLgoKCgo+ID4gK3N0YXRpYyBpbnQgcW1wX2V2X2NhbGxiYWNrX3JlYWRhYmxlKGxp YnhsX19lZ2MgKmVnYywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBs aWJ4bF9fZXZfcW1wICpldiwgaW50IGZkKQo+ID4gKyAgICAvKiBvbiBlcnJvcjogKiAtPiBkaXNj b25uZWN0ZWQgKi8KPiAKPiBQcmVjb25kaXRpb24gPyAgQW5kIG9uIG5vbi1lcnJvciA/CgpIZXJl IGlzIGEgbW9yZSBjb21wbGV0ZSBjb21tZW50OgogIFByZWNvbmRpdGlvbjoKICAgICFkaXNjb25u ZWN0ZWQKICBTdGF0ZSB0cmFuc2l0aW9uOgogICAgT25seSB0aGUgc3RhdGUgb2YgdGhlIHJlY2Vp dmluZyBidWZmZXIgaXMgY2hhbmdlIG9uIHN1Y2Nlc3MKICAgIG9uIGVycm9yOiBkaXNjb25uZWN0 ZWQKCj4gPiArc3RhdGljIGludCBxbXBfZXZfZ2V0X25leHRfbXNnKGxpYnhsX19lZ2MgKmVnYywg bGlieGxfX2V2X3FtcCAqZXYsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxp YnhsX19qc29uX29iamVjdCAqKm9fcikKPiA+ICsgICAgLyogRmluZCBhIEpTT04gb2JqZWN0IGFu ZCBzdG9yZSBpdCBpbiBvX3IuCj4gPiArICAgICAqIHJldHVybiBFUlJPUl9OT1RGT1VORCBpZiBu byBvYmplY3QgaXMgZm91bmQuCj4gPiArICAgICAqIGBvX3JgIGlzIGFsbG9jYXRlZCB3aXRoaW4g YGVnY2AuCj4gPiArICAgICAqLwo+ID4gK3sKPiAKPiBNaXNzaW5nIHN0YXRlIGNvbW1lbnQuCgog IHByZWNvbmRpdGlvbjogIWRpc2Nvbm5lY3RlZAogIHN0YXRlIG9mIHRoZSByZWNlaXZpbmcgYnVm ZmVyIGNhbiBiZSBjaGFuZ2VkLgoKPiA+ICtzdGF0aWMgaW50IHFtcF9ldl9wYXJzZV9lcnJvcl9t ZXNzYWdlcyhsaWJ4bF9fZWdjICplZ2MsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbGlieGxfX2V2X3FtcCAqZXYsCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY29uc3QgbGlieGxfX2pzb25fb2JqZWN0ICpyZXNwKQo+ID4gK3sK PiAKPiBUaGlzIGRvZXNuJ3QgdG91Y2ggdGhlIHN0YXRlIEkgdGhpbmsuICBTaG91bGQgcGVyaGFw cyBiZSBtZW50aW9uZWQgaW4KPiBhIGNvbW1lbnQuCgpUaGUgb25seSB0aGluZyB0aGF0IHRoaXMg ZnVuY3Rpb24gdXNlIGlzIHNldCBieSBhIHVzZXIgKG9mCmxpYnhsX19ldl9xbXApOiBldi0+ZG9t aWQuIEJ1dCBJIGd1ZXNzIHRoYXQgY29tbWVudCB3b3VsZCBkbzoKCiAgbm8gc3RhdGUgY2hhbmdl CgoKQXJlIGFsbCB0aG9zZSBjb21tZW50cyBnb29kIGVub3VnaD8gQWxzbyBzb21ldGltZSB0aGUg aW50ZXJuYWwgc3RhdGUKaXNuJ3QgZnVsbHkgY2hhbmdlZCBpbiBvbmUgZ28sIGFuZCB0aGUgdHJh bnNpdGlvbiBjb3VsZCBoYXBwZW4gaW4Kc2V2ZXJhbCBmdW5jdGlvbnMgKEkgdGhpbmspLiBEbyB3 ZSBuZWVkcyBzdGF0ZXMgbGlrZSBkaXNjb25uZWN0aW5nLApjb25uZWN0aW5naW5nLCAuLi4gPyB3 aXRoIGEgY29tbWVudCB0aGF0IHNheSB0aGF0IHRoZSB2YWx1ZSBvZiB0aGUKaW50ZXJuYWwgdmFy aWFibGVzIGNhbiBiZSBvbmUgb2YgYmVmb3JlIG9yIGFmdGVyIHRoZSBzdGF0ZSB0cmFuc2l0aW9u LgoKTmV4dCB0aW1lIEknbGwgd3JpdGUgb25lIEJJRyBmdW5jdGlvbiwgYW5kIHRoZXJlIHdpbGwg YmUgbGVzcyBvZiB0aG9zZQpjb21tZW50cyB0byB3cml0ZSA6KS4KClRoYW5rcywKCi0tIApBbnRo b255IFBFUkFSRAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcK aHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==