From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Always write both TILEOFF and LINOFF plane registers Date: Tue, 13 Nov 2018 17:59:59 +0200 Message-ID: <20181113155959.GZ9144@intel.com> References: <20181108150955.23948-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED2176E387 for ; Tue, 13 Nov 2018 16:00:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181108150955.23948-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMDgsIDIwMTggYXQgMDU6MDk6NTVQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFJlZHVjZSB0aGUgY2x1dHRlciBpbiB0aGUgc3ByaXRlIHVwZGF0ZSBmdW5jdGlv bnMgYnkgd3JpdGluZwo+IGJvdGggVElMRU9GRiBhbmQgTElOT0ZGIHJlZ2lzdGVycyB1bmNvbmRp dGlvbmFsbHkuIFdlIGFscmVhZHkKPiBkaWQgdGhpcyBmb3IgcHJpbWFyeSBwbGFuZXMgc28gbWln aHQgYXMgd2VsbCBkbyBpdCBmb3IgdGhlCj4gc3ByaXRlcyB0b28uCj4gCj4gVGhlcmUgaXMgbm8g aGFybSBpbiB3cml0aW5nIGJvdGggcmVnaXN0ZXJzLiBXaGljaCBvbmUgZ2V0cwo+IHVzZWQgZGVw ZW5kcyBvbiB0aGUgdGlsaW1nIG1vZGUgc2VsZWN0ZWQgaW4gdGhlIHBsYW5lIGNvbnRyb2wKPiBy ZWdpc3RlcnMuCj4gCj4gSXQgbWlnaHQgZXZlbiBtYWtlIHNlbnNlIHRvIGNsZWFyIHRoZSByZWdp c3RlciB0aGF0IHdvbid0Cj4gZ2V0IHVzZWQuIFRoYXQgY291bGQgbWFrZSByZWdpc3RlciBkdW1w cyBhIGxpdHRsZSBlYXNpZXIgdG8KPiBwYXJzZS4gQnV0IEknbSBub3Qgc3VyZSBpdCdzIHdvcnRo IHRoZSBleHRyYSBoYXNzbGUuCj4gCj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGlu dGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgoKUHVzaGVkIHdpdGggTWFhcnRlbidzIGlyYyByLWIuCgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDIxICsrKysrKystLS0tLS0t LS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IDEyOTMxODJkYmNi MC4uMDZlODg0NWIwNzFkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3Nwcml0ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBA QCAtNzkyLDcgKzc5Miw2IEBAIHZsdl91cGRhdGVfcGxhbmUoc3RydWN0IGludGVsX3BsYW5lICpw bGFuZSwKPiAgCQkgY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkK PiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFu ZS0+YmFzZS5kZXYpOwo+IC0JY29uc3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBwbGFu ZV9zdGF0ZS0+YmFzZS5mYjsKPiAgCWVudW0gcGlwZSBwaXBlID0gcGxhbmUtPnBpcGU7Cj4gIAll bnVtIHBsYW5lX2lkIHBsYW5lX2lkID0gcGxhbmUtPmlkOwo+ICAJdTMyIHNwcmN0bCA9IHBsYW5l X3N0YXRlLT5jdGw7Cj4gQEAgLTgyOSwxMCArODI4LDggQEAgdmx2X3VwZGF0ZV9wbGFuZShzdHJ1 Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICAJCSAgICAgIHBsYW5lX3N0YXRlLT5jb2xvcl9wbGFu ZVswXS5zdHJpZGUpOwo+ICAJSTkxNV9XUklURV9GVyhTUFBPUyhwaXBlLCBwbGFuZV9pZCksIChj cnRjX3kgPDwgMTYpIHwgY3J0Y194KTsKPiAgCj4gLQlpZiAoZmItPm1vZGlmaWVyID09IEk5MTVf Rk9STUFUX01PRF9YX1RJTEVEKQo+IC0JCUk5MTVfV1JJVEVfRlcoU1BUSUxFT0ZGKHBpcGUsIHBs YW5lX2lkKSwgKHkgPDwgMTYpIHwgeCk7Cj4gLQllbHNlCj4gLQkJSTkxNV9XUklURV9GVyhTUExJ Tk9GRihwaXBlLCBwbGFuZV9pZCksIGxpbmVhcl9vZmZzZXQpOwo+ICsJSTkxNV9XUklURV9GVyhT UFRJTEVPRkYocGlwZSwgcGxhbmVfaWQpLCAoeSA8PCAxNikgfCB4KTsKPiArCUk5MTVfV1JJVEVf RlcoU1BMSU5PRkYocGlwZSwgcGxhbmVfaWQpLCBsaW5lYXJfb2Zmc2V0KTsKPiAgCj4gIAlJOTE1 X1dSSVRFX0ZXKFNQQ09OU1RBTFBIQShwaXBlLCBwbGFuZV9pZCksIDApOwo+ICAKPiBAQCAtOTUw LDcgKzk0Nyw2IEBAIGl2Yl91cGRhdGVfcGxhbmUoc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSwK PiAgCQkgY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiAgewo+ ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFuZS0+YmFz ZS5kZXYpOwo+IC0JY29uc3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBwbGFuZV9zdGF0 ZS0+YmFzZS5mYjsKPiAgCWVudW0gcGlwZSBwaXBlID0gcGxhbmUtPnBpcGU7Cj4gIAl1MzIgc3By Y3RsID0gcGxhbmVfc3RhdGUtPmN0bCwgc3Byc2NhbGUgPSAwOwo+ICAJdTMyIHNwcnN1cmZfb2Zm c2V0ID0gcGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5lWzBdLm9mZnNldDsKPiBAQCAtOTkwLDEyICs5 ODYsMTIgQEAgaXZiX3VwZGF0ZV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICAK PiAgCS8qIEhTVyBjb25zb2xpZGF0ZXMgU1BSVElMRU9GRiBhbmQgU1BSTElOT0ZGIGludG8gYSBz aW5nbGUgU1BST0ZGU0VUCj4gIAkgKiByZWdpc3RlciAqLwo+IC0JaWYgKElTX0hBU1dFTEwoZGV2 X3ByaXYpIHx8IElTX0JST0FEV0VMTChkZXZfcHJpdikpCj4gKwlpZiAoSVNfSEFTV0VMTChkZXZf cHJpdikgfHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkgewo+ICAJCUk5MTVfV1JJVEVfRlcoU1BS T0ZGU0VUKHBpcGUpLCAoeSA8PCAxNikgfCB4KTsKPiAtCWVsc2UgaWYgKGZiLT5tb2RpZmllciA9 PSBJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRCkKPiArCX0gZWxzZSB7Cj4gIAkJSTkxNV9XUklURV9G VyhTUFJUSUxFT0ZGKHBpcGUpLCAoeSA8PCAxNikgfCB4KTsKPiAtCWVsc2UKPiAgCQlJOTE1X1dS SVRFX0ZXKFNQUkxJTk9GRihwaXBlKSwgbGluZWFyX29mZnNldCk7Cj4gKwl9Cj4gIAo+ICAJSTkx NV9XUklURV9GVyhTUFJTSVpFKHBpcGUpLCAoY3J0Y19oIDw8IDE2KSB8IGNydGNfdyk7Cj4gIAlp ZiAoSVNfSVZZQlJJREdFKGRldl9wcml2KSkKPiBAQCAtMTExOSw3ICsxMTE1LDYgQEAgZzR4X3Vw ZGF0ZV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICAJCSBjb25zdCBzdHJ1Y3Qg aW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KHBsYW5lLT5iYXNlLmRldik7Cj4gLQljb25zdCBz dHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRlLT5iYXNlLmZiOwo+ICAJZW51 bSBwaXBlIHBpcGUgPSBwbGFuZS0+cGlwZTsKPiAgCXUzMiBkdnNjbnRyID0gcGxhbmVfc3RhdGUt PmN0bCwgZHZzc2NhbGUgPSAwOwo+ICAJdTMyIGR2c3N1cmZfb2Zmc2V0ID0gcGxhbmVfc3RhdGUt PmNvbG9yX3BsYW5lWzBdLm9mZnNldDsKPiBAQCAtMTE1NywxMCArMTE1Miw4IEBAIGc0eF91cGRh dGVfcGxhbmUoc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSwKPiAgCUk5MTVfV1JJVEVfRlcoRFZT U1RSSURFKHBpcGUpLCBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0uc3RyaWRlKTsKPiAgCUk5 MTVfV1JJVEVfRlcoRFZTUE9TKHBpcGUpLCAoY3J0Y195IDw8IDE2KSB8IGNydGNfeCk7Cj4gIAo+ IC0JaWYgKGZiLT5tb2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRCkKPiAtCQlJOTE1 X1dSSVRFX0ZXKERWU1RJTEVPRkYocGlwZSksICh5IDw8IDE2KSB8IHgpOwo+IC0JZWxzZQo+IC0J CUk5MTVfV1JJVEVfRlcoRFZTTElOT0ZGKHBpcGUpLCBsaW5lYXJfb2Zmc2V0KTsKPiArCUk5MTVf V1JJVEVfRlcoRFZTVElMRU9GRihwaXBlKSwgKHkgPDwgMTYpIHwgeCk7Cj4gKwlJOTE1X1dSSVRF X0ZXKERWU0xJTk9GRihwaXBlKSwgbGluZWFyX29mZnNldCk7Cj4gIAo+ICAJSTkxNV9XUklURV9G VyhEVlNTSVpFKHBpcGUpLCAoY3J0Y19oIDw8IDE2KSB8IGNydGNfdyk7Cj4gIAlJOTE1X1dSSVRF X0ZXKERWU1NDQUxFKHBpcGUpLCBkdnNzY2FsZSk7Cj4gLS0gCj4gMi4xOC4xCgotLSAKVmlsbGUg U3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=