From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] drm/i915: Account for scale factor when calculating initial phase Date: Tue, 13 Nov 2018 18:00:11 +0200 Message-ID: <20181113160011.GA9144@intel.com> References: <20181029173440.19943-1-ville.syrjala@linux.intel.com> <20181029181820.21956-1-ville.syrjala@linux.intel.com> <4ae08803-2955-74a4-39f8-3c636773e027@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4EFC6E392 for ; Tue, 13 Nov 2018 16:00:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <4ae08803-2955-74a4-39f8-3c636773e027@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Juha-Pekka Heikkila Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMDIsIDIwMTggYXQgMTE6NDc6MTNBTSArMDIwMCwgSnVoYS1QZWtrYSBIZWlr a2lsYSB3cm90ZToKPiBUaGlzIHNlZW1zIHRvIGZpeCBzb21lIERSTV9GT1JNQVRfUkdCNTY1ICh1 cC0pc2NhbGluZyBJR1QgdGVzdHMgb24gb24gbXkgCj4gS0JMLgo+IAo+IFRlc3RlZC1ieTogSnVo YS1QZWtrYSBIZWlra2lsYSA8anVoYXBla2thLmhlaWtraWxhQGdtYWlsLmNvbT4KClB1c2hlZCB3 aXRoIE1hYXJ0ZW4ncyBpcmMgci1iIGFuZCB0LWIuIFRoYW5rcyBmb3IgdGhlIHJldmlldyBhbmQK dGVzdGluZy4KCj4gCj4gT24gMjkuMTAuMjAxOCAyMDoxOCwgVmlsbGUgU3lyamFsYSB3cm90ZToK PiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gPiAKPiA+IFRvIGdldCB0aGUgaW5pdGlhbCBwaGFzZSBjb3JyZWN0IHdlIG5lZWQgdG8gYWNj b3VudCBmb3IgdGhlIHNjYWxlCj4gPiBmYWN0b3IgYXMgd2VsbC4gSSBmb3Jnb3QgdGhpcyBpbml0 aWFsbHkgYW5kIHdhcyBtb3N0bHkgbG9va2luZyBhdAo+ID4gaGVhdmlseSB1cHNjYWxlZCBjb250 ZW50IHdoZXJlIHRoZSBtaW5vciBkaWZmZXJlbmNlIGJldHdlZW4gLTAuNQo+ID4gYW5kIHRoZSBw cm9wZXIgaW5pdGlhbCBwaGFzZSB3YXMgbm90IHJlYWRpbHkgYXBwYXJlbnQuCj4gPiAKPiA+IEFu ZCBsZXQncyB0b3NzIGluIGEgY29tbWVudCB0aGF0IHRyaWVzIHRvIGV4cGxhaW4gdGhlIGZvcm11 bGEKPiA+IGEgbGl0dGxlIGJpdC4KPiA+IAo+ID4gdjI6IFRoZSBpbml0aWFsIHBoYXNlIHVwcGVy IGxpbWl0IGlzIDEuNSwgbm90IDI0LjAhCj4gPiAKPiA+IENjOiBNYWFydGVuIExhbmtob3JzdCA8 bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4gRml4ZXM6IDBhNTk5NTJiMjRl MiAoImRybS9pOTE1OiBDb25maWd1cmUgU0tMKyBzY2FsZXIgaW5pdGlhbCBwaGFzZSBjb3JyZWN0 bHkiKQo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMgfCA0NSArKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICAyICstCj4gPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3Nwcml0ZS5jICB8IDIwICsrKysrKysrKy0tLS0KPiA+ICAgMyBmaWxlcyBj aGFuZ2VkLCA1NyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggZmUwNDVhYmI2NDcyLi4zM2RkMmU5 NzUxZTYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAg LTQ3ODYsOCArNDc4NiwzMSBAQCBzdGF0aWMgdm9pZCBjcHRfdmVyaWZ5X21vZGVzZXQoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwgaW50IHBpcGUpCj4gPiAgICAqIGNocm9tYSBzYW1wbGVzIGZvciBi b3RoIG9mIHRoZSBsdW1hIHNhbXBsZXMsIGFuZCB0aHVzIHdlIGRvbid0Cj4gPiAgICAqIGFjdHVh bGx5IGdldCB0aGUgZXhwZWN0ZWQgTVBFRzIgY2hyb21hIHNpdGluZyBjb252ZW50aW9uIDooCj4g PiAgICAqIFRoZSBzYW1lIGJlaGF2aW91ciBpcyBvYnNlcnZlZCBvbiBwcmUtU0tMIHBsYXRmb3Jt cyBhcyB3ZWxsLgo+ID4gKyAqCj4gPiArICogVGhlb3J5IGJlaGluZCB0aGUgZm9ybXVsYSAobm90 ZSB0aGF0IHdlIGlnbm9yZSBzdWItcGl4ZWwKPiA+ICsgKiBzb3VyY2UgY29vcmRpbmF0ZXMpOgo+ ID4gKyAqIHMgPSBzb3VyY2Ugc2FtcGxlIHBvc2l0aW9uCj4gPiArICogZCA9IGRlc3RpbmF0aW9u IHNhbXBsZSBwb3NpdGlvbgo+ID4gKyAqCj4gPiArICogRG93bnNjYWxpbmcgNDoxOgo+ID4gKyAq IC0wLjUKPiA+ICsgKiB8IDAuMAo+ID4gKyAqIHwgfCAgICAgMS41IChpbml0aWFsIHBoYXNlKQo+ ID4gKyAqIHwgfCAgICAgfAo+ID4gKyAqIHYgdiAgICAgdgo+ID4gKyAqIHwgcyB8IHMgfCBzIHwg cyB8Cj4gPiArICogfCAgICAgICBkICAgICAgIHwKPiA+ICsgKgo+ID4gKyAqIFVwc2NhbGluZyAx OjQ6Cj4gPiArICogLTAuNQo+ID4gKyAqIHwgLTAuMzc1IChpbml0aWFsIHBoYXNlKQo+ID4gKyAq IHwgfCAgICAgMC4wCj4gPiArICogfCB8ICAgICB8Cj4gPiArICogdiB2ICAgICB2Cj4gPiArICog fCAgICAgICBzICAgICAgIHwKPiA+ICsgKiB8IGQgfCBkIHwgZCB8IGQgfAo+ID4gICAgKi8KPiA+ IC11MTYgc2tsX3NjYWxlcl9jYWxjX3BoYXNlKGludCBzdWIsIGJvb2wgY2hyb21hX2Nvc2l0ZWQp Cj4gPiArdTE2IHNrbF9zY2FsZXJfY2FsY19waGFzZShpbnQgc3ViLCBpbnQgc2NhbGUsIGJvb2wg Y2hyb21hX2Nvc2l0ZWQpCj4gPiAgIHsKPiA+ICAgCWludCBwaGFzZSA9IC0weDgwMDA7Cj4gPiAg IAl1MTYgdHJpcCA9IDA7Cj4gPiBAQCAtNDc5NSw2ICs0ODE4LDE1IEBAIHUxNiBza2xfc2NhbGVy X2NhbGNfcGhhc2UoaW50IHN1YiwgYm9vbCBjaHJvbWFfY29zaXRlZCkKPiA+ICAgCWlmIChjaHJv bWFfY29zaXRlZCkKPiA+ICAgCQlwaGFzZSArPSAoc3ViIC0gMSkgKiAweDgwMDAgLyBzdWI7Cj4g PiAgIAo+ID4gKwlwaGFzZSArPSBzY2FsZSAvICgyICogc3ViKTsKPiA+ICsKPiA+ICsJLyoKPiA+ ICsJICogSGFyZHdhcmUgaW5pdGlhbCBwaGFzZSBsaW1pdGVkIHRvIFstMC41OjEuNV0uCj4gPiAr CSAqIFNpbmNlIHRoZSBtYXggaGFyZHdhcmUgc2NhbGUgZmFjdG9yIGlzIDMuMCwgd2UKPiA+ICsJ ICogc2hvdWxkIG5ldmVyIGFjdHVhbGx5IGV4Y2RlZWQgMS4wIGhlcmUuCj4gPiArCSAqLwo+ID4g KwlXQVJOX09OKHBoYXNlIDwgLTB4ODAwMCB8fCBwaGFzZSA+IDB4MTgwMDApOwo+ID4gKwo+ID4g ICAJaWYgKHBoYXNlIDwgMCkKPiA+ICAgCQlwaGFzZSA9IDB4MTAwMDAgKyBwaGFzZTsKPiA+ICAg CWVsc2UKPiA+IEBAIC01MDAzLDEzICs1MDM1LDIwIEBAIHN0YXRpYyB2b2lkIHNreWxha2VfcGZp dF9lbmFibGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gPiAg IAo+ID4gICAJaWYgKGNydGNfc3RhdGUtPnBjaF9wZml0LmVuYWJsZWQpIHsKPiA+ICAgCQl1MTYg dXZfcmdiX2hwaGFzZSwgdXZfcmdiX3ZwaGFzZTsKPiA+ICsJCWludCBwZml0X3csIHBmaXRfaCwg aHNjYWxlLCB2c2NhbGU7Cj4gPiAgIAkJaW50IGlkOwo+ID4gICAKPiA+ICAgCQlpZiAoV0FSTl9P TihjcnRjX3N0YXRlLT5zY2FsZXJfc3RhdGUuc2NhbGVyX2lkIDwgMCkpCj4gPiAgIAkJCXJldHVy bjsKPiA+ICAgCj4gPiAtCQl1dl9yZ2JfaHBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDEs IGZhbHNlKTsKPiA+IC0JCXV2X3JnYl92cGhhc2UgPSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMSwg ZmFsc2UpOwo+ID4gKwkJcGZpdF93ID0gKGNydGNfc3RhdGUtPnBjaF9wZml0LnNpemUgPj4gMTYp ICYgMHhGRkZGOwo+ID4gKwkJcGZpdF9oID0gY3J0Y19zdGF0ZS0+cGNoX3BmaXQuc2l6ZSAmIDB4 RkZGRjsKPiA+ICsKPiA+ICsJCWhzY2FsZSA9IChjcnRjX3N0YXRlLT5waXBlX3NyY193IDw8IDE2 KSAvIHBmaXRfdzsKPiA+ICsJCXZzY2FsZSA9IChjcnRjX3N0YXRlLT5waXBlX3NyY19oIDw8IDE2 KSAvIHBmaXRfaDsKPiA+ICsKPiA+ICsJCXV2X3JnYl9ocGhhc2UgPSBza2xfc2NhbGVyX2NhbGNf cGhhc2UoMSwgaHNjYWxlLCBmYWxzZSk7Cj4gPiArCQl1dl9yZ2JfdnBoYXNlID0gc2tsX3NjYWxl cl9jYWxjX3BoYXNlKDEsIHZzY2FsZSwgZmFsc2UpOwo+ID4gICAKPiA+ICAgCQlpZCA9IHNjYWxl cl9zdGF0ZS0+c2NhbGVyX2lkOwo+ID4gICAJCUk5MTVfV1JJVEUoU0tMX1BTX0NUUkwocGlwZSwg aWQpLCBQU19TQ0FMRVJfRU4gfAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IGluZGV4 IGRiMjQzMDg3MjliNC4uODZkNTUxYTMzMWIxIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rydi5oCj4gPiBAQCAtMTcwOSw3ICsxNzA5LDcgQEAgdm9pZCBpbnRlbF9tb2RlX2Zyb21fcGlw ZV9jb25maWcoc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUsCj4gPiAgIHZvaWQgaW50ZWxf Y3J0Y19hcm1fZmlmb191bmRlcnJ1bihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiA+ICAgCQkJ CSAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ID4gICAKPiA+IC11MTYg c2tsX3NjYWxlcl9jYWxjX3BoYXNlKGludCBzdWIsIGJvb2wgY2hyb21hX2NlbnRlcik7Cj4gPiAr dTE2IHNrbF9zY2FsZXJfY2FsY19waGFzZShpbnQgc3ViLCBpbnQgc2NhbGUsIGJvb2wgY2hyb21h X2NlbnRlcik7Cj4gPiAgIGludCBza2xfdXBkYXRlX3NjYWxlcl9jcnRjKHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlKTsKPiA+ICAgaW50IHNrbF9tYXhfc2NhbGUoY29uc3Qgc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gPiAgIAkJICB1MzIgcGl4ZWxfZm9y bWF0KTsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiBpbmRleCBjZmFkZGMw NWZlYTYuLmZiYjkxNjUwNmM3NyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3Nwcml0ZS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJp dGUuYwo+ID4gQEAgLTMyNiwyNyArMzI2LDM1IEBAIHNrbF9wcm9ncmFtX3NjYWxlcihzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgIAl1aW50MzJfdCBjcnRjX2ggPSBkcm1f cmVjdF9oZWlnaHQoJnBsYW5lX3N0YXRlLT5iYXNlLmRzdCk7Cj4gPiAgIAl1MTYgeV9ocGhhc2Us IHV2X3JnYl9ocGhhc2U7Cj4gPiAgIAl1MTYgeV92cGhhc2UsIHV2X3JnYl92cGhhc2U7Cj4gPiAr CWludCBoc2NhbGUsIHZzY2FsZTsKPiA+ICAgCj4gPiAgIAkvKiBTaXplcyBhcmUgMCBiYXNlZCAq Lwo+ID4gICAJY3J0Y193LS07Cj4gPiAgIAljcnRjX2gtLTsKPiA+ICAgCj4gPiArCWhzY2FsZSA9 IGRybV9yZWN0X2NhbGNfaHNjYWxlKCZwbGFuZV9zdGF0ZS0+YmFzZS5zcmMsCj4gPiArCQkJCSAg ICAgICZwbGFuZV9zdGF0ZS0+YmFzZS5kc3QsCj4gPiArCQkJCSAgICAgIDAsIElOVF9NQVgpOwo+ ID4gKwl2c2NhbGUgPSBkcm1fcmVjdF9jYWxjX3ZzY2FsZSgmcGxhbmVfc3RhdGUtPmJhc2Uuc3Jj LAo+ID4gKwkJCQkgICAgICAmcGxhbmVfc3RhdGUtPmJhc2UuZHN0LAo+ID4gKwkJCQkgICAgICAw LCBJTlRfTUFYKTsKPiA+ICsKPiA+ICAgCS8qIFRPRE86IGhhbmRsZSBzdWItcGl4ZWwgY29vcmRp bmF0ZXMgKi8KPiA+ICAgCWlmIChwbGFuZV9zdGF0ZS0+YmFzZS5mYi0+Zm9ybWF0LT5mb3JtYXQg PT0gRFJNX0ZPUk1BVF9OVjEyICYmCj4gPiAgIAkgICAgIWljbF9pc19oZHJfcGxhbmUocGxhbmUp KSB7Cj4gPiAtCQl5X2hwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgxLCBmYWxzZSk7Cj4g PiAtCQl5X3ZwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgxLCBmYWxzZSk7Cj4gPiArCQl5 X2hwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgxLCBoc2NhbGUsIGZhbHNlKTsKPiA+ICsJ CXlfdnBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDEsIHZzY2FsZSwgZmFsc2UpOwo+ID4g ICAKPiA+ICAgCQkvKiBNUEVHMiBjaHJvbWEgc2l0aW5nIGNvbnZlbnRpb24gKi8KPiA+IC0JCXV2 X3JnYl9ocGhhc2UgPSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMiwgdHJ1ZSk7Cj4gPiAtCQl1dl9y Z2JfdnBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDIsIGZhbHNlKTsKPiA+ICsJCXV2X3Jn Yl9ocGhhc2UgPSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMiwgaHNjYWxlLCB0cnVlKTsKPiA+ICsJ CXV2X3JnYl92cGhhc2UgPSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMiwgdnNjYWxlLCBmYWxzZSk7 Cj4gPiAgIAl9IGVsc2Ugewo+ID4gICAJCS8qIG5vdCB1c2VkICovCj4gPiAgIAkJeV9ocGhhc2Ug PSAwOwo+ID4gICAJCXlfdnBoYXNlID0gMDsKPiA+ICAgCj4gPiAtCQl1dl9yZ2JfaHBoYXNlID0g c2tsX3NjYWxlcl9jYWxjX3BoYXNlKDEsIGZhbHNlKTsKPiA+IC0JCXV2X3JnYl92cGhhc2UgPSBz a2xfc2NhbGVyX2NhbGNfcGhhc2UoMSwgZmFsc2UpOwo+ID4gKwkJdXZfcmdiX2hwaGFzZSA9IHNr bF9zY2FsZXJfY2FsY19waGFzZSgxLCBoc2NhbGUsIGZhbHNlKTsKPiA+ICsJCXV2X3JnYl92cGhh c2UgPSBza2xfc2NhbGVyX2NhbGNfcGhhc2UoMSwgdnNjYWxlLCBmYWxzZSk7Cj4gPiAgIAl9Cj4g PiAgIAo+ID4gICAJSTkxNV9XUklURV9GVyhTS0xfUFNfQ1RSTChwaXBlLCBzY2FsZXJfaWQpLAo+ ID4gCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=