From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com,
martin.peres@intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH xf86-video-intel v8 2/2] sna: Added AYUV format support for textured and sprite video adapters.
Date: Tue, 13 Nov 2018 21:13:40 +0200 [thread overview]
Message-ID: <20181113191340.GK9144@intel.com> (raw)
In-Reply-To: <154213496891.16646.7888484771170149723@skylake-alporthouse-com>
On Tue, Nov 13, 2018 at 06:49:38PM +0000, Chris Wilson wrote:
> Quoting Stanislav Lisovskiy (2018-11-13 07:45:02)
> > @@ -408,6 +424,9 @@ void sna_video_textured_setup(struct sna *sna, ScreenPtr screen)
> > } else if (sna->kgem.gen < 040) {
> > adaptor->nImages = ARRAY_SIZE(gen3_Images);
> > adaptor->pImages = (XvImageRec *)gen3_Images;
> > + } else if (sna->kgem.gen >= 0110) {
> > + adaptor->nImages = ARRAY_SIZE(gen9_Images);
> > + adaptor->pImages = (XvImageRec *)gen9_Images;
> > } else {
> > adaptor->nImages = ARRAY_SIZE(gen4_Images);
> > adaptor->pImages = (XvImageRec *)gen4_Images;
>
> Grr. Aside from the minor nits, ok. Ville?
Yeah. Seems good enough. For both
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-13 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 7:45 [PATCH xf86-video-intel v8 0/2] Added AYUV format support Stanislav Lisovskiy
2018-11-13 7:45 ` [PATCH xf86-video-intel v8 1/2] sna/gen9+: Split out wm_kernel from the sna_composite_op flags Stanislav Lisovskiy
2018-11-13 7:45 ` [PATCH xf86-video-intel v8 2/2] sna: Added AYUV format support for textured and sprite video adapters Stanislav Lisovskiy
2018-11-13 18:49 ` Chris Wilson
2018-11-13 19:13 ` Ville Syrjälä [this message]
2018-11-13 20:39 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113191340.GK9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=martin.peres@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.