From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,net-next,18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks From: Andrew Lunn Message-Id: <20181113205041.GA9828@lunn.ch> Date: Tue, 13 Nov 2018 21:50:41 +0100 To: Igor Russkikh Cc: "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Dmitry Bezrukov List-ID: T24gVHVlLCBOb3YgMTMsIDIwMTggYXQgMDI6NDU6MTNQTSArMDAwMCwgSWdvciBSdXNza2lraCB3 cm90ZToKPiArc3RhdGljIGludCBhcWMxMTFfZ2V0X2xpbmtfa3NldHRpbmdzKHN0cnVjdCBuZXRf ZGV2aWNlICpuZXQsCj4gKwkJCQkgICAgIHN0cnVjdCBldGh0b29sX2xpbmtfa3NldHRpbmdzICpl bGspCj4gK3sKPiArCXN0cnVjdCB1c2JuZXQgKmRldiA9IG5ldGRldl9wcml2KG5ldCk7Cj4gKwlz dHJ1Y3QgYXFjMTExX2RhdGEgKmFxYzExMV9kYXRhID0gZGV2LT5kcml2ZXJfcHJpdjsKPiArCWVu dW0gdXNiX2RldmljZV9zcGVlZCB1c2Jfc3BlZWQgPSBkZXYtPnVkZXYtPnNwZWVkOwo+ICsJdTMy IHNwZWVkID0gU1BFRURfVU5LTk9XTjsKPiArCj4gKwlldGh0b29sX2xpbmtfa3NldHRpbmdzX3pl cm9fbGlua19tb2RlKGVsaywgc3VwcG9ydGVkKTsKPiArCWV0aHRvb2xfbGlua19rc2V0dGluZ3Nf YWRkX2xpbmtfbW9kZShlbGssIHN1cHBvcnRlZCwKPiArCQkJCQkgICAgIDEwMGJhc2VUX0Z1bGwp Owo+ICsJZXRodG9vbF9saW5rX2tzZXR0aW5nc19hZGRfbGlua19tb2RlKGVsaywgc3VwcG9ydGVk LAo+ICsJCQkJCSAgICAgMTAwMGJhc2VUX0Z1bGwpOwo+ICsJaWYgKHVzYl9zcGVlZCA9PSBVU0Jf U1BFRURfU1VQRVIpIHsKPiArCQlldGh0b29sX2xpbmtfa3NldHRpbmdzX2FkZF9saW5rX21vZGUo ZWxrLCBzdXBwb3J0ZWQsCj4gKwkJCQkJCSAgICAgMjUwMGJhc2VUX0Z1bGwpOwo+ICsJCWV0aHRv b2xfbGlua19rc2V0dGluZ3NfYWRkX2xpbmtfbW9kZShlbGssIHN1cHBvcnRlZCwKPiArCQkJCQkJ ICAgICA1MDAwYmFzZVRfRnVsbCk7Cj4gKwl9CgpIaSBJZ29yCgpXZSBkaXNjdXNzZWQgdGhpcyB3 aXRoIHRoZSBmaXJzdCB2ZXJzaW9uIG9mIHRoZSBwYXRjaGVzLiBJIHRoaW5rIHlvdQpzaG91bGQg YWRkIGEgY29tbWVudCBleHBsYWluaW5nIHdoeSAyLjVHIGFuZCA1RyBpcyBkaXNhYmxlZCB1bmxl c3MKU3VwZXIgc3BlZWQgaXMgYXZhaWxhYmxlLgoKPiArCWlmIChhcWMxMTFfZGF0YS0+YXV0b25l ZykKPiArCQliaXRtYXBfY29weShlbGstPmxpbmtfbW9kZXMuYWR2ZXJ0aXNpbmcsCj4gKwkJCSAg ICBlbGstPmxpbmtfbW9kZXMuc3VwcG9ydGVkLAo+ICsJCQkgICAgX19FVEhUT09MX0xJTktfTU9E RV9NQVNLX05CSVRTKTsKCmxpbmttb2RlX2NvcHkoKS4gSXQgaXMgcXVpdGUgbmV3LCBzbyB5b3Ug cHJvYmFibHkgZG9uJ3Qga25vdyBhYm91dCBpdC4KCgkgQW5kcmV3Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v2 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks Date: Tue, 13 Nov 2018 21:50:41 +0100 Message-ID: <20181113205041.GA9828@lunn.ch> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Dmitry Bezrukov To: Igor Russkikh Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:33794 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725748AbeKNGui (ORCPT ); Wed, 14 Nov 2018 01:50:38 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Nov 13, 2018 at 02:45:13PM +0000, Igor Russkikh wrote: > +static int aqc111_get_link_ksettings(struct net_device *net, > + struct ethtool_link_ksettings *elk) > +{ > + struct usbnet *dev = netdev_priv(net); > + struct aqc111_data *aqc111_data = dev->driver_priv; > + enum usb_device_speed usb_speed = dev->udev->speed; > + u32 speed = SPEED_UNKNOWN; > + > + ethtool_link_ksettings_zero_link_mode(elk, supported); > + ethtool_link_ksettings_add_link_mode(elk, supported, > + 100baseT_Full); > + ethtool_link_ksettings_add_link_mode(elk, supported, > + 1000baseT_Full); > + if (usb_speed == USB_SPEED_SUPER) { > + ethtool_link_ksettings_add_link_mode(elk, supported, > + 2500baseT_Full); > + ethtool_link_ksettings_add_link_mode(elk, supported, > + 5000baseT_Full); > + } Hi Igor We discussed this with the first version of the patches. I think you should add a comment explaining why 2.5G and 5G is disabled unless Super speed is available. > + if (aqc111_data->autoneg) > + bitmap_copy(elk->link_modes.advertising, > + elk->link_modes.supported, > + __ETHTOOL_LINK_MODE_MASK_NBITS); linkmode_copy(). It is quite new, so you probably don't know about it. Andrew