From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
Juan Quintela <quintela@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Yanan Fu <yfu@redhat.com>, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile
Date: Wed, 14 Nov 2018 18:48:57 +0800 [thread overview]
Message-ID: <20181114104857.GC3955@xz-x1> (raw)
In-Reply-To: <20181114103723.GB2390@work-vm>
On Wed, Nov 14, 2018 at 10:37:23AM +0000, Dr. David Alan Gilbert wrote:
> * Peter Xu (peterx@redhat.com) wrote:
> > We've fixed it before like 38bb54f323 ("replication: Make
> > --disable-replication compile again", 2017-04-28) but it's failing
> > again. So fix it again.
> >
> > There could be even cleaner way to fix this but current way is the
> > simplest. Let's start from simple.
>
> This is I think the same as the patch posted 1st November:
> Fix compilation issue when disable replication
Yep, thanks for pointing out. Please ignore this patch.
Regards,
--
Peter Xu
next prev parent reply other threads:[~2018-11-14 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 7:16 [Qemu-devel] [PATCH] replication: Make --disable-replication compile Peter Xu
2018-11-14 10:37 ` Dr. David Alan Gilbert
2018-11-14 10:48 ` Peter Xu [this message]
2018-11-14 15:23 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114104857.GC3955@xz-x1 \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yfu@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.