From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH -fixes 3/3] drm/i915: Account for scale
 factor when calculating initial phase
Date: Wed, 14 Nov 2018 15:28:09 +0200
Message-ID: <20181114132809.GP9144@intel.com>
References: <154219479771.8476.5785497597600629344@jlahtine-desk.ger.corp.intel.com>
 <20181114114925.6818-1-ville.syrjala@linux.intel.com>
 <20181114114925.6818-3-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B70AC6E571
 for <intel-gfx@lists.freedesktop.org>; Wed, 14 Nov 2018 13:28:12 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20181114114925.6818-3-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBOb3YgMTQsIDIwMTggYXQgMDE6NDk6MjVQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3
cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IAo+IFRvIGdldCB0aGUgaW5pdGlhbCBwaGFzZSBjb3JyZWN0IHdlIG5lZWQgdG8gYWNj
b3VudCBmb3IgdGhlIHNjYWxlCj4gZmFjdG9yIGFzIHdlbGwuIEkgZm9yZ290IHRoaXMgaW5pdGlh
bGx5IGFuZCB3YXMgbW9zdGx5IGxvb2tpbmcgYXQKPiBoZWF2aWx5IHVwc2NhbGVkIGNvbnRlbnQg
d2hlcmUgdGhlIG1pbm9yIGRpZmZlcmVuY2UgYmV0d2VlbiAtMC41Cj4gYW5kIHRoZSBwcm9wZXIg
aW5pdGlhbCBwaGFzZSB3YXMgbm90IHJlYWRpbHkgYXBwYXJlbnQuCj4gCj4gQW5kIGxldCdzIHRv
c3MgaW4gYSBjb21tZW50IHRoYXQgdHJpZXMgdG8gZXhwbGFpbiB0aGUgZm9ybXVsYQo+IGEgbGl0
dGxlIGJpdC4KPiAKPiB2MjogVGhlIGluaXRpYWwgcGhhc2UgdXBwZXIgbGltaXQgaXMgMS41LCBu
b3QgMjQuMCEKPiAKPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxp
bnV4LmludGVsLmNvbT4KPiBGaXhlczogMGE1OTk1MmIyNGUyICgiZHJtL2k5MTU6IENvbmZpZ3Vy
ZSBTS0wrIHNjYWxlciBpbml0aWFsIHBoYXNlIGNvcnJlY3RseSIpCj4gU2lnbmVkLW9mZi1ieTog
VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBMaW5rOiBo
dHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNnaWQvMjAxODEwMjkxODE4
MjAuMjE5NTYtMS12aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbQo+IFRlc3RlZC1ieTogSnVo
YS1QZWtrYSBIZWlra2lsYSA8anVoYXBla2thLmhlaWtraWxhQGdtYWlsLmNvbT4KPiBUZXN0ZWQt
Ynk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+
ICNpcmMKPiBSZXZpZXdlZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0
QGxpbnV4LmludGVsLmNvbT4gI2lyYwo+IChjaGVycnkgcGlja2VkIGZyb20gY29tbWl0IGU3YTI3
OGEzMjlkZDhhYTJjNzBjNTY0ODQ5ZjE2NGNiNTY3MzY4OWMpCj4gLS0tCj4gIGRyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQ1ICsrKysrKysrKysrKysrKysrKysrKysrKysr
LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDIgKy0KPiAgZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgIHwgMjAgKysrKysrKysrLS0tLQo+ICAz
IGZpbGVzIGNoYW5nZWQsIDU3IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+IAo+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCAyM2Q4MDA4YTkzYmIuLjYzNjcz
OGMwNGViMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5
LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtNDg1
MCw4ICs0ODUwLDMxIEBAIHN0YXRpYyB2b2lkIGNwdF92ZXJpZnlfbW9kZXNldChzdHJ1Y3QgZHJt
X2RldmljZSAqZGV2LCBpbnQgcGlwZSkKPiAgICogY2hyb21hIHNhbXBsZXMgZm9yIGJvdGggb2Yg
dGhlIGx1bWEgc2FtcGxlcywgYW5kIHRodXMgd2UgZG9uJ3QKPiAgICogYWN0dWFsbHkgZ2V0IHRo
ZSBleHBlY3RlZCBNUEVHMiBjaHJvbWEgc2l0aW5nIGNvbnZlbnRpb24gOigKPiAgICogVGhlIHNh
bWUgYmVoYXZpb3VyIGlzIG9ic2VydmVkIG9uIHByZS1TS0wgcGxhdGZvcm1zIGFzIHdlbGwuCj4g
KyAqCj4gKyAqIFRoZW9yeSBiZWhpbmQgdGhlIGZvcm11bGEgKG5vdGUgdGhhdCB3ZSBpZ25vcmUg
c3ViLXBpeGVsCj4gKyAqIHNvdXJjZSBjb29yZGluYXRlcyk6Cj4gKyAqIHMgPSBzb3VyY2Ugc2Ft
cGxlIHBvc2l0aW9uCj4gKyAqIGQgPSBkZXN0aW5hdGlvbiBzYW1wbGUgcG9zaXRpb24KPiArICoK
PiArICogRG93bnNjYWxpbmcgNDoxOgo+ICsgKiAtMC41Cj4gKyAqIHwgMC4wCj4gKyAqIHwgfCAg
ICAgMS41IChpbml0aWFsIHBoYXNlKQo+ICsgKiB8IHwgICAgIHwKPiArICogdiB2ICAgICB2Cj4g
KyAqIHwgcyB8IHMgfCBzIHwgcyB8Cj4gKyAqIHwgICAgICAgZCAgICAgICB8Cj4gKyAqCj4gKyAq
IFVwc2NhbGluZyAxOjQ6Cj4gKyAqIC0wLjUKPiArICogfCAtMC4zNzUgKGluaXRpYWwgcGhhc2Up
Cj4gKyAqIHwgfCAgICAgMC4wCj4gKyAqIHwgfCAgICAgfAo+ICsgKiB2IHYgICAgIHYKPiArICog
fCAgICAgICBzICAgICAgIHwKPiArICogfCBkIHwgZCB8IGQgfCBkIHwKPiAgICovCj4gLXUxNiBz
a2xfc2NhbGVyX2NhbGNfcGhhc2UoaW50IHN1YiwgYm9vbCBjaHJvbWFfY29zaXRlZCkKPiArdTE2
IHNrbF9zY2FsZXJfY2FsY19waGFzZShpbnQgc3ViLCBpbnQgc2NhbGUsIGJvb2wgY2hyb21hX2Nv
c2l0ZWQpCj4gIHsKPiAgCWludCBwaGFzZSA9IC0weDgwMDA7Cj4gIAl1MTYgdHJpcCA9IDA7Cj4g
QEAgLTQ4NTksNiArNDg4MiwxNSBAQCB1MTYgc2tsX3NjYWxlcl9jYWxjX3BoYXNlKGludCBzdWIs
IGJvb2wgY2hyb21hX2Nvc2l0ZWQpCj4gIAlpZiAoY2hyb21hX2Nvc2l0ZWQpCj4gIAkJcGhhc2Ug
Kz0gKHN1YiAtIDEpICogMHg4MDAwIC8gc3ViOwo+ICAKPiArCXBoYXNlICs9IHNjYWxlIC8gKDIg
KiBzdWIpOwo+ICsKPiArCS8qCj4gKwkgKiBIYXJkd2FyZSBpbml0aWFsIHBoYXNlIGxpbWl0ZWQg
dG8gWy0wLjU6MS41XS4KPiArCSAqIFNpbmNlIHRoZSBtYXggaGFyZHdhcmUgc2NhbGUgZmFjdG9y
IGlzIDMuMCwgd2UKPiArCSAqIHNob3VsZCBuZXZlciBhY3R1YWxseSBleGNkZWVkIDEuMCBoZXJl
Lgo+ICsJICovCj4gKwlXQVJOX09OKHBoYXNlIDwgLTB4ODAwMCB8fCBwaGFzZSA+IDB4MTgwMDAp
Owo+ICsKPiAgCWlmIChwaGFzZSA8IDApCj4gIAkJcGhhc2UgPSAweDEwMDAwICsgcGhhc2U7Cj4g
IAllbHNlCj4gQEAgLTUwNjcsMTMgKzUwOTksMjAgQEAgc3RhdGljIHZvaWQgc2t5bGFrZV9wZml0
X2VuYWJsZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCj4gIAlpZiAoY3J0Yy0+Y29uZmln
LT5wY2hfcGZpdC5lbmFibGVkKSB7Cj4gIAkJdTE2IHV2X3JnYl9ocGhhc2UsIHV2X3JnYl92cGhh
c2U7Cj4gKwkJaW50IHBmaXRfdywgcGZpdF9oLCBoc2NhbGUsIHZzY2FsZTsKPiAgCQlpbnQgaWQ7
Cj4gIAo+ICAJCWlmIChXQVJOX09OKGNydGMtPmNvbmZpZy0+c2NhbGVyX3N0YXRlLnNjYWxlcl9p
ZCA8IDApKQo+ICAJCQlyZXR1cm47Cj4gIAo+IC0JCXV2X3JnYl9ocGhhc2UgPSBza2xfc2NhbGVy
X2NhbGNfcGhhc2UoMSwgZmFsc2UpOwo+IC0JCXV2X3JnYl92cGhhc2UgPSBza2xfc2NhbGVyX2Nh
bGNfcGhhc2UoMSwgZmFsc2UpOwo+ICsJCXBmaXRfdyA9IChjcnRjX3N0YXRlLT5wY2hfcGZpdC5z
aXplID4+IDE2KSAmIDB4RkZGRjsKPiArCQlwZml0X2ggPSBjcnRjX3N0YXRlLT5wY2hfcGZpdC5z
aXplICYgMHhGRkZGOwo+ICsKPiArCQloc2NhbGUgPSAoY3J0Y19zdGF0ZS0+cGlwZV9zcmNfdyA8
PCAxNikgLyBwZml0X3c7Cj4gKwkJdnNjYWxlID0gKGNydGNfc3RhdGUtPnBpcGVfc3JjX2ggPDwg
MTYpIC8gcGZpdF9oOwoKQmFoLiBUaGlzIGRvZXNuJ3QgYnVpbGQuIEknbGwgZml4IGFuZCByZXNl
bmQsIGFuZCBtYWtlIGRvdWJseSBzdXJlIHRvCmJ1aWxkIHRlc3QgdGhpcyB0aW1lLiBTb3JyeSBm
b3IgdGhlIG5vaXNlLgoKPiArCj4gKwkJdXZfcmdiX2hwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19w
aGFzZSgxLCBoc2NhbGUsIGZhbHNlKTsKPiArCQl1dl9yZ2JfdnBoYXNlID0gc2tsX3NjYWxlcl9j
YWxjX3BoYXNlKDEsIHZzY2FsZSwgZmFsc2UpOwo+ICAKPiAgCQlpZCA9IHNjYWxlcl9zdGF0ZS0+
c2NhbGVyX2lkOwo+ICAJCUk5MTVfV1JJVEUoU0tMX1BTX0NUUkwocGlwZSwgaWQpLCBQU19TQ0FM
RVJfRU4gfAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5kZXggZjhkYzg0YjJkMmQzLi44
YjI5OGU1ZjAxMmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2
LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC0xNjQ2LDcg
KzE2NDYsNyBAQCB2b2lkIGludGVsX21vZGVfZnJvbV9waXBlX2NvbmZpZyhzdHJ1Y3QgZHJtX2Rp
c3BsYXlfbW9kZSAqbW9kZSwKPiAgdm9pZCBpbnRlbF9jcnRjX2FybV9maWZvX3VuZGVycnVuKHN0
cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJCQkJICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq
Y3J0Y19zdGF0ZSk7Cj4gIAo+IC11MTYgc2tsX3NjYWxlcl9jYWxjX3BoYXNlKGludCBzdWIsIGJv
b2wgY2hyb21hX2NlbnRlcik7Cj4gK3UxNiBza2xfc2NhbGVyX2NhbGNfcGhhc2UoaW50IHN1Yiwg
aW50IHNjYWxlLCBib29sIGNocm9tYV9jZW50ZXIpOwo+ICBpbnQgc2tsX3VwZGF0ZV9zY2FsZXJf
Y3J0YyhzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7Cj4gIGludCBza2xfbWF4
X3NjYWxlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJCSAg
dTMyIHBpeGVsX2Zvcm1hdCk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX3Nwcml0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBpbmRl
eCBmYTdlYWFjZTVmOTIuLmQzMDkwYTc1MzdiYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X3Nwcml0ZS5jCj4gQEAgLTMxOCwyMiArMzE4LDMwIEBAIHNrbF9wcm9ncmFtX3NjYWxlcihzdHJ1
Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICAJdWludDMyX3QgY3J0Y19oID0gZHJtX3JlY3RfaGVp
Z2h0KCZwbGFuZV9zdGF0ZS0+YmFzZS5kc3QpOwo+ICAJdTE2IHlfaHBoYXNlLCB1dl9yZ2JfaHBo
YXNlOwo+ICAJdTE2IHlfdnBoYXNlLCB1dl9yZ2JfdnBoYXNlOwo+ICsJaW50IGhzY2FsZSwgdnNj
YWxlOwo+ICsKPiArCWhzY2FsZSA9IGRybV9yZWN0X2NhbGNfaHNjYWxlKCZwbGFuZV9zdGF0ZS0+
YmFzZS5zcmMsCj4gKwkJCQkgICAgICAmcGxhbmVfc3RhdGUtPmJhc2UuZHN0LAo+ICsJCQkJICAg
ICAgMCwgSU5UX01BWCk7Cj4gKwl2c2NhbGUgPSBkcm1fcmVjdF9jYWxjX3ZzY2FsZSgmcGxhbmVf
c3RhdGUtPmJhc2Uuc3JjLAo+ICsJCQkJICAgICAgJnBsYW5lX3N0YXRlLT5iYXNlLmRzdCwKPiAr
CQkJCSAgICAgIDAsIElOVF9NQVgpOwo+ICAKPiAgCS8qIFRPRE86IGhhbmRsZSBzdWItcGl4ZWwg
Y29vcmRpbmF0ZXMgKi8KPiAgCWlmIChwbGFuZV9zdGF0ZS0+YmFzZS5mYi0+Zm9ybWF0LT5mb3Jt
YXQgPT0gRFJNX0ZPUk1BVF9OVjEyKSB7Cj4gLQkJeV9ocGhhc2UgPSBza2xfc2NhbGVyX2NhbGNf
cGhhc2UoMSwgZmFsc2UpOwo+IC0JCXlfdnBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDEs
IGZhbHNlKTsKPiArCQl5X2hwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgxLCBoc2NhbGUs
IGZhbHNlKTsKPiArCQl5X3ZwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgxLCB2c2NhbGUs
IGZhbHNlKTsKPiAgCj4gIAkJLyogTVBFRzIgY2hyb21hIHNpdGluZyBjb252ZW50aW9uICovCj4g
LQkJdXZfcmdiX2hwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgyLCB0cnVlKTsKPiAtCQl1
dl9yZ2JfdnBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDIsIGZhbHNlKTsKPiArCQl1dl9y
Z2JfaHBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDIsIGhzY2FsZSwgdHJ1ZSk7Cj4gKwkJ
dXZfcmdiX3ZwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFzZSgyLCB2c2NhbGUsIGZhbHNlKTsK
PiAgCX0gZWxzZSB7Cj4gIAkJLyogbm90IHVzZWQgKi8KPiAgCQl5X2hwaGFzZSA9IDA7Cj4gIAkJ
eV92cGhhc2UgPSAwOwo+ICAKPiAtCQl1dl9yZ2JfaHBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3Bo
YXNlKDEsIGZhbHNlKTsKPiAtCQl1dl9yZ2JfdnBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNl
KDEsIGZhbHNlKTsKPiArCQl1dl9yZ2JfaHBoYXNlID0gc2tsX3NjYWxlcl9jYWxjX3BoYXNlKDEs
IGhzY2FsZSwgZmFsc2UpOwo+ICsJCXV2X3JnYl92cGhhc2UgPSBza2xfc2NhbGVyX2NhbGNfcGhh
c2UoMSwgdnNjYWxlLCBmYWxzZSk7Cj4gIAl9Cj4gIAo+ICAJSTkxNV9XUklURV9GVyhTS0xfUFNf
Q1RSTChwaXBlLCBzY2FsZXJfaWQpLAo+IC0tIAo+IDIuMTguMQoKLS0gClZpbGxlIFN5cmrDpGzD
pApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ
bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK