All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	devel@linuxdriverproject.org, linux-fsdevel@vger.kernel.org,
	linux-pm@vger.kernel.org, xen-devel@lists.xenproject.org,
	David Hildenbrand <david@redhat.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	Michal Hocko <mhocko@suse.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH RFC 6/6] PM / Hibernate: exclude all PageOffline() pages
Date: Wed, 14 Nov 2018 22:17:04 +0100	[thread overview]
Message-ID: <20181114211704.6381-7-david@redhat.com> (raw)
In-Reply-To: <20181114211704.6381-1-david@redhat.com>

The content of pages that are marked PG_offline is not of interest
(e.g. inflated by a balloon driver), let's skip these pages.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Len Brown <len.brown@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 kernel/power/snapshot.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index b0308a2c6000..01db1d13481a 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -1222,7 +1222,7 @@ static struct page *saveable_highmem_page(struct zone *zone, unsigned long pfn)
 	BUG_ON(!PageHighMem(page));
 
 	if (swsusp_page_is_forbidden(page) ||  swsusp_page_is_free(page) ||
-	    PageReserved(page))
+	    PageReserved(page) || PageOffline(page))
 		return NULL;
 
 	if (page_is_guard(page))
@@ -1286,6 +1286,9 @@ static struct page *saveable_page(struct zone *zone, unsigned long pfn)
 	if (swsusp_page_is_forbidden(page) || swsusp_page_is_free(page))
 		return NULL;
 
+	if (PageOffline(page))
+		return NULL;
+
 	if (PageReserved(page)
 	    && (!kernel_page_present(page) || pfn_is_nosave(pfn)))
 		return NULL;
-- 
2.17.2


  parent reply	other threads:[~2018-11-14 21:18 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14 21:16 [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline David Hildenbrand
2018-11-14 21:16 ` David Hildenbrand
2018-11-14 21:16 ` [PATCH RFC 1/6] mm: balloon: update comment about isolation/migration/compaction David Hildenbrand
2018-11-14 21:16 ` David Hildenbrand
2018-11-14 21:17 ` [PATCH RFC 2/6] mm: convert PG_balloon to PG_offline David Hildenbrand
2018-11-14 21:17   ` David Hildenbrand
2018-11-14 22:23   ` Matthew Wilcox
2018-11-14 22:23     ` Matthew Wilcox
2018-11-14 22:49     ` David Hildenbrand
2018-11-14 22:49     ` David Hildenbrand
2018-11-14 22:49       ` David Hildenbrand
2018-11-15  2:07       ` Mike Rapoport
2018-11-15  2:07         ` Mike Rapoport
2018-11-15  9:21         ` David Hildenbrand
2018-11-15  9:21           ` David Hildenbrand
2018-11-15 12:19           ` Michal Hocko
2018-11-15 12:19             ` Michal Hocko
2018-11-15 12:19           ` Michal Hocko
2018-11-15  9:21         ` David Hildenbrand
2018-11-15  2:07       ` Mike Rapoport
2018-11-14 22:23   ` Matthew Wilcox
2018-11-14 21:17 ` David Hildenbrand
2018-11-14 21:17 ` [PATCH RFC 3/6] kexec: export PG_offline to VMCOREINFO David Hildenbrand
2018-11-15  6:19   ` Dave Young
2018-11-15  6:19   ` Dave Young
2018-11-15  9:23     ` David Hildenbrand
2018-11-15  9:23       ` David Hildenbrand
2018-11-15  9:23     ` David Hildenbrand
2018-11-15 11:10     ` Borislav Petkov
2018-11-15 11:20       ` David Hildenbrand
2018-11-15 11:20         ` David Hildenbrand
2018-11-15 11:52         ` Borislav Petkov
2018-11-15 11:52         ` Borislav Petkov
2018-11-15 12:01           ` David Hildenbrand
2018-11-15 17:58             ` Borislav Petkov
2018-11-15 17:58             ` Borislav Petkov
2018-11-15 12:01           ` David Hildenbrand
2018-11-15 12:11           ` Michal Hocko
2018-11-15 14:13             ` Borislav Petkov
2018-11-15 14:13             ` Borislav Petkov
2018-11-15 14:13               ` Borislav Petkov
2018-11-15 12:11           ` Michal Hocko
2018-11-15 11:20       ` David Hildenbrand
2018-11-15 11:10     ` Borislav Petkov
2018-11-14 21:17 ` David Hildenbrand
2018-11-14 21:17 ` [PATCH RFC 4/6] xen/balloon: mark inflated pages PG_offline David Hildenbrand
2018-11-14 21:17 ` David Hildenbrand
2018-11-14 21:17 ` [PATCH RFC 5/6] hv_balloon: " David Hildenbrand
2018-11-14 21:17 ` David Hildenbrand
2018-11-14 21:17 ` [PATCH RFC 6/6] PM / Hibernate: exclude all PageOffline() pages David Hildenbrand
2018-11-14 21:17 ` David Hildenbrand [this message]
2018-11-15  7:48   ` Pavel Machek
2018-11-15  7:48   ` Pavel Machek
2018-11-15 12:23   ` Michal Hocko
2018-11-15 12:23   ` Michal Hocko
2018-11-15 12:29     ` David Hildenbrand
2018-11-15 12:29     ` David Hildenbrand
2018-11-14 22:57 ` [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline Nadav Amit
2018-11-14 22:57   ` Nadav Amit
2018-11-14 23:05   ` David Hildenbrand
2018-11-14 23:05     ` David Hildenbrand
2018-11-14 23:41     ` Nadav Amit
2018-11-14 23:41       ` Nadav Amit
2018-11-15  1:42       ` Julien Freche
2018-11-15  1:42       ` Julien Freche
2018-11-15  1:42         ` Julien Freche
2018-11-14 23:41     ` Nadav Amit
2018-11-14 23:05   ` David Hildenbrand
2018-11-14 22:57 ` Nadav Amit
2018-11-16 18:23 ` David Hildenbrand
2018-11-16 18:23   ` David Hildenbrand
2018-11-16 18:23 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181114211704.6381-7-david@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=devel@linuxdriverproject.org \
    --cc=len.brown@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=mst@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=willy@infradead.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.