From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,net-next,19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet From: Andrew Lunn Message-Id: <20181114213038.GG32305@lunn.ch> Date: Wed, 14 Nov 2018 22:30:38 +0100 To: Igor Russkikh Cc: "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Dmitry Bezrukov List-ID: PiBXZSd2ZSBjb25zaWRlcmVkIHRoYXQsIGJ1dCB0aGVuIHRob3VnaHQgYWJvdXQgdGhlIGZvbGxv d2luZyBjYXNlOgo+IAo+IEFmdGVyIHN1Y2ggYSBzbGVlcCBzdGF0ZSB3aGVyZSBwYXJ0bmVyJ3Mg Y2FwYWJpbGl0aWVzIHdlcmUgY29uc2lkZXJlZCwKPiB1c2VyIG1heSBtb3ZlIHdpdGggdGhlIHVu aXQgYW5kIHJlcGx1ZyBpdCBpbnRvIGRpZmZlcmVudCBsaW5rIHBhcnRuZXIgd2l0aAo+IG90aGVy LCBpbmNvbXBhdGlibGUgc3BlZWQgbWFzay4gVGhhdCB3aWxsIGFueXdheSBsZWFkIHRvIHdvbCBs aW5rIGZhaWx1cmUuCgpXT0wgZm9yIGEgbm9tYWRpYyBkZXZpY2U/IElzIHRoYXQgZXZlbiBhIHJl YWwgdXNlIGNhc2U/CgpBbnl3YXksIGxvb2tpbmcgYXQgdGhlIGxpbmsgcGFydG5lciBjYXBhYmls aXRpZXMgaXMganVzdCByZWFsbHkgYQpjb3JuZXIgY2FzZSwgdGhhdCB0aGUgTFAgb25seSBzdXBw b3J0cyAxRy4gRG8gc3VjaCBkZXZpY2VzIGV4aXN0PwoKU28gc2tpcHBpbmcgdGhpcyBpcyBmaW5l LiBCdXQgaWYgeW91IHVzZSBwaHlsaWIsIHlvdSBwcmV0dHkgbXVjaCBnZXQKaXQgZm9yIGZyZWUg aWYgeW91IHdhbnQgaXQuCgogICBBbmRyZXcK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet Date: Wed, 14 Nov 2018 22:30:38 +0100 Message-ID: <20181114213038.GG32305@lunn.ch> References: <20181113210241.GC9828@lunn.ch> <3c322e27-06c7-69a1-cbe8-271741da0bb3@aquantia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Dmitry Bezrukov To: Igor Russkikh Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:34909 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbeKOHfg (ORCPT ); Thu, 15 Nov 2018 02:35:36 -0500 Content-Disposition: inline In-Reply-To: <3c322e27-06c7-69a1-cbe8-271741da0bb3@aquantia.com> Sender: netdev-owner@vger.kernel.org List-ID: > We've considered that, but then thought about the following case: > > After such a sleep state where partner's capabilities were considered, > user may move with the unit and replug it into different link partner with > other, incompatible speed mask. That will anyway lead to wol link failure. WOL for a nomadic device? Is that even a real use case? Anyway, looking at the link partner capabilities is just really a corner case, that the LP only supports 1G. Do such devices exist? So skipping this is fine. But if you use phylib, you pretty much get it for free if you want it. Andrew