From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:39948 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727067AbeKORDk (ORCPT ); Thu, 15 Nov 2018 12:03:40 -0500 Date: Thu, 15 Nov 2018 06:57:03 +0000 From: Al Viro To: Chengguang Xu Cc: jack@suse.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] mbcache: change setting entry->e_reusable for more readable code Message-ID: <20181115065702.GG32577@ZenIV.linux.org.uk> References: <20181115064233.21294-1-cgxu519@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181115064233.21294-1-cgxu519@gmx.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Nov 15, 2018 at 02:42:33PM +0800, Chengguang Xu wrote: > Instead of directly setting entry->e_reusable to parameter reusable, > cheek the bool value for more readable code. > > Signed-off-by: Chengguang Xu > --- > fs/mbcache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/mbcache.c b/fs/mbcache.c > index 081ccf0caee3..39ec9fd8bacf 100644 > --- a/fs/mbcache.c > +++ b/fs/mbcache.c > @@ -93,7 +93,7 @@ int mb_cache_entry_create(struct mb_cache *cache, gfp_t mask, u32 key, > atomic_set(&entry->e_refcnt, 1); > entry->e_key = key; > entry->e_value = value; > - entry->e_reusable = reusable; > + entry->e_reusable = reusable ? 1 : 0; Huh? How is that more readable?