From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: Fix show-build-order stdout pollution
Date: Thu, 15 Nov 2018 17:33:36 +0100 [thread overview]
Message-ID: <20181115163336.GI10271@scaer> (raw)
In-Reply-To: <20181115154542.29277-1-serj.kalichev@gmail.com>
Serj, All,
On 2018-11-15 18:45 +0300, Serj Kalichev spake thusly:
> The commands like "make show-build-order" or "make <package>-show-build-order" show
> the build order and then print "make[1]: Nothing to be done for 'show-build-order'" to
> stdout. It pollutes output. Technically this message is true but it's not true for user
> because he gets an information.
>
> The <package>-show-build-order targets use $(info) for package name printing.
> The make utility doesn't consider the internal directive as a command so it
> think that it's "Nothing to be done". The patch adds the empty command to
> <package>-show-build-order to inform make utility that taget makes some real
> actions.
>
> Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com>
> ---
> package/pkg-generic.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index f34f46afc8..74f3c55394 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -819,6 +819,7 @@ $(1)-show-recursive-rdepends:
>
> $(1)-show-build-order: $$(patsubst %,%-show-build-order,$$($(2)_FINAL_ALL_DEPENDENCIES))
> $$(info $(1))
> + @:
The other places where we use that construct, we put the command first,
and the info last, for example:
https://git.buildroot.org/buildroot/tree/Makefile#n1001
With that fixed (which a maintainer may do when applying, no need to
resend), or even as-is (if the maintainers prefer this way):
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> $(1)-graph-depends: graph-depends-requirements
> $(call pkg-graph-depends,$(1),--direct)
> --
> 2.17.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-11-15 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 15:45 [Buildroot] [PATCH 1/1] package/pkg-generic.mk: Fix show-build-order stdout pollution Serj Kalichev
2018-11-15 16:33 ` Yann E. MORIN [this message]
2018-11-19 21:27 ` Thomas Petazzoni
2018-11-26 16:19 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115163336.GI10271@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.