From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Li Dongyang <dongyangli@ddn.com>
Cc: linux-ext4@vger.kernel.org, adilger@dilger.ca
Subject: Re: [v2] e2fsck: check xattr 'system.data' before setting inline_data feature
Date: Thu, 15 Nov 2018 13:17:08 -0500 [thread overview]
Message-ID: <20181115181708.GA19411@thunk.org> (raw)
In-Reply-To: <20181113044603.1089-1-dongyangli@ddn.com>
On Tue, Nov 13, 2018 at 03:46:03PM +1100, Li Dongyang wrote:
> ext2fs_inline_data_size will happy return 0 and set size to
> EXT4_MIN_INLINE_DATA_SIZE even when inode doesn't have
> xattr 'system.data', a corrupted i_flags could make e2fsck
> enable the inline_data on the superblock.
>
> We should only offer to enable inline_data when i_flags is set
> and xattr 'system.data' can be found.
>
> Also use correct prompt for PR_1_INLINE_DATA_FEATURE.
>
> Signed-off-by: Li Dongyang <dongyangli@ddn.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2018-11-16 4:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 4:46 [PATCH v2] e2fsck: check xattr 'system.data' before setting inline_data feature Li Dongyang
2018-11-15 18:17 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115181708.GA19411@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=dongyangli@ddn.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.