From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] lost idr_destroy for ls_recover_idr in release_lockspace() ?
Date: Thu, 15 Nov 2018 12:22:59 -0600 [thread overview]
Message-ID: <20181115182259.GC18025@redhat.com> (raw)
In-Reply-To: <702f661c-7227-7c2e-ade5-c4d40d5862f2@virtuozzo.com>
On Thu, Nov 15, 2018 at 09:49:17AM +0300, Vasily Averin wrote:
> Dear David,
> I've noticed that release_lockspace() lacks idr_destroy(&ls->ls_recover_idr),
> though it is called on rollback in new_lockspace().
>
> It seems for me it is not critical, and should not lead to any leaks,
> however could you please re-check it?
>
> Thank you,
> Vasily Averin
Thanks for the patches, I've pushed them to linux-dlm next, and added
another for the missing idr_destroy.
Dave
prev parent reply other threads:[~2018-11-15 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 6:49 [Cluster-devel] lost idr_destroy for ls_recover_idr in release_lockspace() ? Vasily Averin
2018-11-15 18:22 ` David Teigland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115182259.GC18025@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.