From: Andy Gross <andy.gross@linaro.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: david.brown@linaro.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: msm8998-mtp: Add external SD
Date: Thu, 15 Nov 2018 11:05:59 -0800 [thread overview]
Message-ID: <20181115190559.GA17484@hector> (raw)
In-Reply-To: <1542302291-6864-5-git-send-email-jhugo@codeaurora.org>
On Thu, Nov 15, 2018 at 10:18:11AM -0700, Jeffrey Hugo wrote:
> The externally accessible SD card slot on the MTP is driven by SDCC2.
> Wire it up for use.
>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 13 +++++++++++++
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> index b4276da..a90b427 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> @@ -241,3 +241,16 @@
> };
> };
> };
> +
> +&sdhc2 {
> + status = "okay";
> + cd-gpios = <&tlmm 95 GPIO_ACTIVE_LOW>;
> +
> + vmmc-supply = <&vreg_l21a_2p95>;
> + vqmmc-supply = <&vreg_l13a_2p95>;
> +
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
> + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>;
Fix to use tabs instead of spaces.
Regards,
Andy
next prev parent reply other threads:[~2018-11-15 19:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 17:18 [PATCH 0/4] Enable SD crd slot on msm8998 MTP Jeffrey Hugo
2018-11-15 17:18 ` [PATCH 1/4] arm64: dts: qcom: msm8998: correct xo clock name Jeffrey Hugo
2018-11-15 18:26 ` Bjorn Andersson
2018-11-15 17:18 ` [PATCH 2/4] arm64: dts: qcom: msm8998: Add SDCC2 Jeffrey Hugo
2018-11-15 18:26 ` Bjorn Andersson
2018-11-15 17:18 ` [PATCH 3/4] arm64: dts: qcom: msm8998: Add SDC2 control pins Jeffrey Hugo
2018-11-15 19:16 ` Bjorn Andersson
2018-11-15 20:15 ` Jeffrey Hugo
2018-11-15 17:18 ` [PATCH 4/4] arm64: dts: qcom: msm8998-mtp: Add external SD Jeffrey Hugo
2018-11-15 19:05 ` Andy Gross [this message]
2018-11-15 20:11 ` Jeffrey Hugo
2018-11-15 19:20 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115190559.GA17484@hector \
--to=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.