From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 2/6] drm/vc4: Move LBM creation out of vc4_plane_mode_set() Date: Thu, 15 Nov 2018 22:10:00 +0100 Message-ID: <20181115221000.653b6654@bbrezillon> References: <20181115103721.25601-1-boris.brezillon@bootlin.com> <20181115103721.25601-3-boris.brezillon@bootlin.com> <878t1u2hyp.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id A32516E131 for ; Thu, 15 Nov 2018 21:10:11 +0000 (UTC) In-Reply-To: <878t1u2hyp.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAxNSBOb3YgMjAxOCAxMjozOTo0MiAtMDgwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxp bi5jb20+IHdyaXRlczoKPiAKPiA+IFdlIGFyZSBhYm91dCB0byB1c2UgdmM0X3BsYW5lX21vZGVf c2V0KCkgaW4gdGhlIGFzeW5jIGNoZWNrIHBhdGgsIGFuZAo+ID4gYXN5bmMgdXBkYXRlcyByZXF1 aXJlIHRoYXQgTEJNIHNpemUgc3RheSB0aGUgc2FtZSBzaW5jZSB0aGV5IHJldXNlIHRoZQo+ID4g TEJNIGZyb20gdGhlIHByZXZpb3VzIHN0YXRlLiBTbyB3ZSBkZWZpbml0ZWx5IGRvbid0IHdhbnQg dG8gYWxsb2NhdGUgYQo+ID4gbmV3IExCTSByZWdpb24gdGhhdCB3ZSBrbm93IGZvciBzdXJlIHdp bGwgYmUgZnJlZSByaWdodCBhd2F5Lgo+ID4KPiA+IE1vdmUgdGhlIExCTSBhbGxvY2F0aW9uIG91 dCBvZiB2YzRfcGxhbmVfbW9kZV9zZXQoKSBhbmQgY2FsbCB0aGUgbmV3Cj4gPiBmdW5jdGlvbiAo dmM0X3BsYW5lX3VwZGF0ZV9sYm0oKSkgZnJvbSB2YzRfcGxhbmVfYXRvbWljX2NoZWNrKCkuCj4g Pgo+ID4gU2lnbmVkLW9mZi1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9v dGxpbi5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuaCAgIHwg IDEgKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMgfCA4MiArKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDU1IGluc2VydGlv bnMoKyksIDI4IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vdmM0L3ZjNF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5oCj4gPiBpbmRl eCBiZDZlZjFmMzE4MjIuLjllZDA1ZmI2MWViNiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS92YzQvdmM0X2Rydi5oCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYu aAo+ID4gQEAgLTMzOCw2ICszMzgsNyBAQCBzdHJ1Y3QgdmM0X3BsYW5lX3N0YXRlIHsKPiA+ICAJ dTMyIHBvczBfb2Zmc2V0Owo+ID4gIAl1MzIgcG9zMl9vZmZzZXQ7Cj4gPiAgCXUzMiBwdHIwX29m ZnNldDsKPiA+ICsJdTMyIGxibV9vZmZzZXQ7Cj4gPiAgCj4gPiAgCS8qIE9mZnNldCB3aGVyZSB0 aGUgcGxhbmUncyBkbGlzdCB3YXMgbGFzdCBzdG9yZWQgaW4gdGhlCj4gPiAgCSAqIGhhcmR3YXJl IGF0IHZjNF9jcnRjX2F0b21pY19mbHVzaCgpIHRpbWUuCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5l LmMKPiA+IGluZGV4IGY2ZTNlOGQzMzExNS4uMzkyYTUxZjJiZjhmIDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3ZjNC92YzRfcGxhbmUuYwo+ID4gQEAgLTQ1Miw2ICs0NTIsNDMgQEAgc3RhdGljIHZvaWQgdmM0 X3dyaXRlX3NjYWxpbmdfcGFyYW1ldGVycyhzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSwK PiA+ICAJfQo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgaW50IHZjNF9wbGFuZV91cGRhdGVfbGJt KHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ID4gK3sKPiA+ICsJc3RydWN0IHZjNF9k ZXYgKnZjNCA9IHRvX3ZjNF9kZXYoc3RhdGUtPnBsYW5lLT5kZXYpOwo+ID4gKwlzdHJ1Y3QgdmM0 X3BsYW5lX3N0YXRlICp2YzRfc3RhdGUgPSB0b192YzRfcGxhbmVfc3RhdGUoc3RhdGUpOwo+ID4g Kwl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+ID4gKwl1MzIgbGJtX3NpemU7Cj4gPiArCj4gPiAr CWxibV9zaXplID0gdmM0X2xibV9zaXplKHN0YXRlKTsKPiA+ICsJaWYgKCFsYm1fc2l6ZSkKPiA+ ICsJCXJldHVybiAwOwo+ID4gKwo+ID4gKwlpZiAoV0FSTl9PTighdmM0X3N0YXRlLT5sYm1fb2Zm c2V0KSkKPiA+ICsJCXJldHVybiAtRUlOVkFMOwo+ID4gKwo+ID4gKwkvKiBBbGxvY2F0ZSB0aGUg TEJNIG1lbW9yeSB0aGF0IHRoZSBIVlMgd2lsbCB1c2UgZm9yIHRlbXBvcmFyeQo+ID4gKwkgKiBz dG9yYWdlIGR1ZSB0byBvdXIgc2NhbGluZy9mb3JtYXQgY29udmVyc2lvbi4KPiA+ICsJICovCj4g PiArCWlmICghdmM0X3N0YXRlLT5sYm0uYWxsb2NhdGVkKSB7Cj4gPiArCQlpbnQgcmV0Owo+ID4g Kwo+ID4gKwkJc3Bpbl9sb2NrX2lycXNhdmUoJnZjNC0+aHZzLT5tbV9sb2NrLCBpcnFmbGFncyk7 Cj4gPiArCQlyZXQgPSBkcm1fbW1faW5zZXJ0X25vZGVfZ2VuZXJpYygmdmM0LT5odnMtPmxibV9t bSwKPiA+ICsJCQkJCQkgJnZjNF9zdGF0ZS0+bGJtLAo+ID4gKwkJCQkJCSBsYm1fc2l6ZSwgMzIs IDAsIDApOwo+ID4gKwkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmdmM0LT5odnMtPm1tX2xvY2ss IGlycWZsYWdzKTsKPiA+ICsKPiA+ICsJCWlmIChyZXQpCj4gPiArCQkJcmV0dXJuIHJldDsKPiA+ ICsJfSBlbHNlIHsKPiA+ICsJCVdBUk5fT05fT05DRShsYm1fc2l6ZSAhPSB2YzRfc3RhdGUtPmxi bS5zaXplKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwl2YzRfc3RhdGUtPmRsaXN0W3ZjNF9zdGF0ZS0+ bGJtX29mZnNldF0gPSB2YzRfc3RhdGUtPmxibS5zdGFydDsKPiA+ICsKPiA+ICsJcmV0dXJuIDA7 Cj4gPiArfQo+ID4gKwo+ID4gIC8qIFdyaXRlcyBvdXQgYSBmdWxsIGRpc3BsYXkgbGlzdCBmb3Ig YW4gYWN0aXZlIHBsYW5lIHRvIHRoZSBwbGFuZSdzCj4gPiAgICogcHJpdmF0ZSBkbGlzdCBzdGF0 ZS4KPiA+ICAgKi8KPiA+IEBAIC00NjksMzEgKzUwNiwxMiBAQCBzdGF0aWMgaW50IHZjNF9wbGFu ZV9tb2RlX3NldChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAJYm9vbCBtaXhfcGxhbmVf YWxwaGE7Cj4gPiAgCWJvb2wgY292ZXJzX3NjcmVlbjsKPiA+ICAJdTMyIHNjbDAsIHNjbDEsIHBp dGNoMDsKPiA+IC0JdTMyIGxibV9zaXplLCB0aWxpbmc7Cj4gPiAtCXVuc2lnbmVkIGxvbmcgaXJx ZmxhZ3M7Cj4gPiArCXUzMiB0aWxpbmc7Cj4gPiAgCXUzMiBodnNfZm9ybWF0ID0gZm9ybWF0LT5o dnM7Cj4gPiAgCWludCByZXQsIGk7Cj4gPiAgCj4gPiAtCXJldCA9IHZjNF9wbGFuZV9zZXR1cF9j bGlwcGluZ19hbmRfc2NhbGluZyhzdGF0ZSk7Cj4gPiAtCWlmIChyZXQpCj4gPiAtCQlyZXR1cm4g cmV0Owo+ID4gLQo+ID4gLQkvKiBBbGxvY2F0ZSB0aGUgTEJNIG1lbW9yeSB0aGF0IHRoZSBIVlMg d2lsbCB1c2UgZm9yIHRlbXBvcmFyeQo+ID4gLQkgKiBzdG9yYWdlIGR1ZSB0byBvdXIgc2NhbGlu Zy9mb3JtYXQgY29udmVyc2lvbi4KPiA+IC0JICovCj4gPiAtCWxibV9zaXplID0gdmM0X2xibV9z aXplKHN0YXRlKTsKPiA+IC0JaWYgKGxibV9zaXplKSB7Cj4gPiAtCQlpZiAoIXZjNF9zdGF0ZS0+ bGJtLmFsbG9jYXRlZCkgewo+ID4gLQkJCXNwaW5fbG9ja19pcnFzYXZlKCZ2YzQtPmh2cy0+bW1f bG9jaywgaXJxZmxhZ3MpOwo+ID4gLQkJCXJldCA9IGRybV9tbV9pbnNlcnRfbm9kZV9nZW5lcmlj KCZ2YzQtPmh2cy0+bGJtX21tLAo+ID4gLQkJCQkJCQkgJnZjNF9zdGF0ZS0+bGJtLAo+ID4gLQkJ CQkJCQkgbGJtX3NpemUsIDMyLCAwLCAwKTsKPiA+IC0JCQlzcGluX3VubG9ja19pcnFyZXN0b3Jl KCZ2YzQtPmh2cy0+bW1fbG9jaywgaXJxZmxhZ3MpOwo+ID4gLQkJfSBlbHNlIHsKPiA+IC0JCQlX QVJOX09OX09OQ0UobGJtX3NpemUgIT0gdmM0X3N0YXRlLT5sYm0uc2l6ZSk7Cj4gPiAtCQl9Cj4g PiAtCX0KPiA+ICAKPiA+ICsJcmV0ID0gdmM0X3BsYW5lX3NldHVwX2NsaXBwaW5nX2FuZF9zY2Fs aW5nKHN0YXRlKTsKPiA+ICAJaWYgKHJldCkKPiA+ICAJCXJldHVybiByZXQ7Cj4gPiAgCj4gPiBA QCAtNzE3LDE1ICs3MzUsMTggQEAgc3RhdGljIGludCB2YzRfcGxhbmVfbW9kZV9zZXQoc3RydWN0 IGRybV9wbGFuZSAqcGxhbmUsCj4gPiAgCQl2YzRfZGxpc3Rfd3JpdGUodmM0X3N0YXRlLCBTQ0FM RVJfQ1NDMl9JVFJfUl82MDFfNSk7Cj4gPiAgCX0KPiA+ICAKPiA+ICsJdmM0X3N0YXRlLT5sYm1f b2Zmc2V0ID0gMDsKPiA+ICsKPiA+ICAJaWYgKHZjNF9zdGF0ZS0+eF9zY2FsaW5nWzBdICE9IFZD NF9TQ0FMSU5HX05PTkUgfHwKPiA+ICAJICAgIHZjNF9zdGF0ZS0+eF9zY2FsaW5nWzFdICE9IFZD NF9TQ0FMSU5HX05PTkUgfHwKPiA+ICAJICAgIHZjNF9zdGF0ZS0+eV9zY2FsaW5nWzBdICE9IFZD NF9TQ0FMSU5HX05PTkUgfHwKPiA+ICAJICAgIHZjNF9zdGF0ZS0+eV9zY2FsaW5nWzFdICE9IFZD NF9TQ0FMSU5HX05PTkUpIHsKPiA+IC0JCS8qIExCTSBCYXNlIEFkZHJlc3MuICovCj4gPiArCQkv KiBSZXNlcnZlIGEgc2xvdCBmb3IgdGhlIExCTSBCYXNlIEFkZHJlc3MuIFRoZSByZWFsIHZhbHVl IHdpbGwKPiA+ICsJCSAqIGJlIHNldCB3aGVuIGNhbGxpbmcgdmM0X3BsYW5lX3VwZGF0ZV9sYm0o KS4KPiA+ICsJCSAqLwo+ID4gIAkJaWYgKHZjNF9zdGF0ZS0+eV9zY2FsaW5nWzBdICE9IFZDNF9T Q0FMSU5HX05PTkUgfHwKPiA+IC0JCSAgICB2YzRfc3RhdGUtPnlfc2NhbGluZ1sxXSAhPSBWQzRf U0NBTElOR19OT05FKSB7Cj4gPiAtCQkJdmM0X2RsaXN0X3dyaXRlKHZjNF9zdGF0ZSwgdmM0X3N0 YXRlLT5sYm0uc3RhcnQpOwo+ID4gLQkJfQo+ID4gKwkJICAgIHZjNF9zdGF0ZS0+eV9zY2FsaW5n WzFdICE9IFZDNF9TQ0FMSU5HX05PTkUpCj4gPiArCQkJdmM0X3N0YXRlLT5sYm1fb2Zmc2V0ID0g dmM0X3N0YXRlLT5kbGlzdF9jb3VudCsrOwo+ID4gIAo+ID4gIAkJaWYgKG51bV9wbGFuZXMgPiAx KSB7Cj4gPiAgCQkJLyogRW1pdCBDYi9DciBhcyBjaGFubmVsIDAgYW5kIFkgYXMgY2hhbm5lbAo+ ID4gQEAgLTc4NSwxMyArODA2LDE4IEBAIHN0YXRpYyBpbnQgdmM0X3BsYW5lX2F0b21pY19jaGVj ayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAJCQkJICBzdHJ1Y3QgZHJtX3BsYW5lX3N0 YXRlICpzdGF0ZSkKPiA+ICB7Cj4gPiAgCXN0cnVjdCB2YzRfcGxhbmVfc3RhdGUgKnZjNF9zdGF0 ZSA9IHRvX3ZjNF9wbGFuZV9zdGF0ZShzdGF0ZSk7Cj4gPiArCWludCByZXQ7Cj4gPiAgCj4gPiAg CXZjNF9zdGF0ZS0+ZGxpc3RfY291bnQgPSAwOwo+ID4gIAo+ID4gLQlpZiAocGxhbmVfZW5hYmxl ZChzdGF0ZSkpCj4gPiAtCQlyZXR1cm4gdmM0X3BsYW5lX21vZGVfc2V0KHBsYW5lLCBzdGF0ZSk7 Cj4gPiAtCWVsc2UKPiA+ICsJaWYgKCFwbGFuZV9lbmFibGVkKHN0YXRlKSkKPiA+ICAJCXJldHVy biAwOwo+ID4gKwo+ID4gKwlyZXQgPSB2YzRfcGxhbmVfbW9kZV9zZXQocGxhbmUsIHN0YXRlKTsK PiA+ICsJaWYgKHJldCkKPiA+ICsJCXJldHVybiByZXQ7Cj4gPiArCj4gPiArCXJldHVybiB2YzRf cGxhbmVfdXBkYXRlX2xibShzdGF0ZSk7Cj4gPiAgfSAgCj4gCj4gQ291bGRuJ3QgeW91IGNhbGwg dXBkYXRlX2xibSgpIChtYXliZSBjYWxsZWQgYWxsb2NhdGVfbGJtKCkpIGZpcnN0LCBhbmQKPiB0 aGVuIGxlYXZlIHRoZSBkbGlzdCBzZXR1cCBhcyBpcyB3aXRob3V0IG5lZWRpbmcgbGJtX29mZnNl dD8KCkknbGwgYW55d2F5IG5lZWQgbGJtX29mZnNldCBmb3IgdGhlIGRsaXN0IGNoZWNrIEkgZG8g aW4gYXN5bmNfY2hlY2soKS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==