From: Christoph Hellwig <hch@infradead.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-xfs@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: fix 32 bit overflow in __blkdev_issue_discard()
Date: Fri, 16 Nov 2018 00:53:33 -0800 [thread overview]
Message-ID: <20181116085333.GA4544@infradead.org> (raw)
In-Reply-To: <20181116084658.GT23828@vader>
On Fri, Nov 16, 2018 at 12:46:58AM -0800, Omar Sandoval wrote:
> > > generic/349 [not run] scsi_debug module not found
> > > generic/350 [not run] scsi_debug module not found
> > > generic/351 [not run] scsi_debug module not found
> >
> > Same here, btw. Any test that requires modules is a rather bad idea.
>
> I'll plug my vm.py script that supports running a kernel build with
> modules without installing them into the VM (by mounting the modules
> over 9p): https://github.com/osandov/osandov-linux#vm-setup
All nice and good, but avoiding complexity is even better :)
Especially as there should be no reason to only allowing to configure
something at module load time in this century.
next prev parent reply other threads:[~2018-11-16 8:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 21:43 [PATCH] block: fix 32 bit overflow in __blkdev_issue_discard() Dave Chinner
2018-11-14 2:36 ` Darrick J. Wong
2018-11-14 2:53 ` Ming Lei
2018-11-14 8:08 ` Dave Chinner
2018-11-14 8:15 ` Ming Lei
2018-11-14 15:18 ` Jens Axboe
2018-11-15 1:06 ` Ming Lei
2018-11-15 1:22 ` Dave Chinner
2018-11-15 3:10 ` Ming Lei
2018-11-15 22:13 ` Dave Chinner
2018-11-15 22:24 ` Darrick J. Wong
2018-11-16 4:04 ` Dave Chinner
2018-11-16 8:32 ` Christoph Hellwig
2018-11-16 8:46 ` Omar Sandoval
2018-11-16 8:53 ` Christoph Hellwig [this message]
2018-11-16 12:06 ` Ming Lei
2018-11-15 1:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116085333.GA4544@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.